You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/28 18:05:08 UTC
[GitHub] [arrow] drabastomek opened a new pull request, #13027: MINOR: [C++] Adding support for DATE type in SQLite FlightSQL example
drabastomek opened a new pull request, #13027:
URL: https://github.com/apache/arrow/pull/13027
While it works in the integration tests, some SQLite databases have been created (erroneously) with `DATE` data type (instead of `TEXT`). This minor fix handle this edge case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13027: ARROW-16408: [C++] MINOR Adding support for DATE type in SQLite FlightSQL example
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13027:
URL: https://github.com/apache/arrow/pull/13027#issuecomment-1112539005
https://issues.apache.org/jira/browse/ARROW-16408
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #13027: ARROW-16408: [C++] Add support for DATE type in SQLite FlightSQL example
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #13027:
URL: https://github.com/apache/arrow/pull/13027#issuecomment-1118291709
Benchmark runs are scheduled for baseline = c8339b76371c660813726698a6c419956c24b9e9 and contender = d6ca3e2e9e995ff42df2465484ebf86de853a136. d6ca3e2e9e995ff42df2465484ebf86de853a136 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/cb8b1e60e759494f9021a159c8104582...aa4f5198864a45fb93c277efcec0502b/)
[Finished :arrow_down:0.39% :arrow_up:0.0%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/00d4d5ead45447d7b68b410ad03e4a51...bfd8e9857ea347ee87da0196b95c335c/)
[Finished :arrow_down:0.36% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/38e721c1090e494e9fd416dca95443be...b22575ccfb3d486188634e1d65b44503/)
[Finished :arrow_down:0.08% :arrow_up:0.04%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/5d9dcb028aa045c1af8404f7269ca5fd...edea5efa880c4a4c802f657396a0d895/)
Buildkite builds:
[Finished] [`d6ca3e2e` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/670)
[Finished] [`d6ca3e2e` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/667)
[Finished] [`d6ca3e2e` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/656)
[Finished] [`d6ca3e2e` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/672)
[Finished] [`c8339b76` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/669)
[Finished] [`c8339b76` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/666)
[Finished] [`c8339b76` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/655)
[Finished] [`c8339b76` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/671)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm closed pull request #13027: ARROW-16408: [C++] Add support for DATE type in SQLite FlightSQL example
Posted by GitBox <gi...@apache.org>.
lidavidm closed pull request #13027: ARROW-16408: [C++] Add support for DATE type in SQLite FlightSQL example
URL: https://github.com/apache/arrow/pull/13027
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] lidavidm commented on pull request #13027: ARROW-16408: [C++] MINOR Adding support for DATE type in SQLite FlightSQL example
Posted by GitBox <gi...@apache.org>.
lidavidm commented on PR #13027:
URL: https://github.com/apache/arrow/pull/13027#issuecomment-1112537189
Thanks! Looks like clang-format wants some changes:
```diff
--- /arrow/cpp/src/arrow/flight/sql/example/sqlite_server.cc
+++ /arrow/cpp/src/arrow/flight/sql/example/sqlite_server.cc (after clang format)
@@ -206,8 +206,7 @@
return float64();
} else if (boost::iequals(sqlite_type, "BLOB")) {
return binary();
- } else if (boost::iequals(sqlite_type, "TEXT") ||
- boost::iequals(sqlite_type, "DATE") ||
+ } else if (boost::iequals(sqlite_type, "TEXT") || boost::iequals(sqlite_type, "DATE") ||
boost::istarts_with(sqlite_type, "char") ||
boost::istarts_with(sqlite_type, "varchar")) {
return utf8();
@@ -228,8 +227,7 @@
return SQLITE_FLOAT;
} else if (boost::iequals(sqlite_type, "BLOB")) {
return SQLITE_BLOB;
- } else if (boost::iequals(sqlite_type, "TEXT") ||
- boost::iequals(sqlite_type, "DATE") ||
+ } else if (boost::iequals(sqlite_type, "TEXT") || boost::iequals(sqlite_type, "DATE") ||
boost::istarts_with(sqlite_type, "char") ||
boost::istarts_with(sqlite_type, "varchar")) {
return SQLITE_TEXT;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13027: ARROW-16408: [C++] MINOR Adding support for DATE type in SQLite FlightSQL example
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13027:
URL: https://github.com/apache/arrow/pull/13027#issuecomment-1112539026
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org