You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2019/01/15 20:01:26 UTC

Review Request 69749: CMake: Cleaned up a block of platform-specific sources.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69749/
-----------------------------------------------------------

Review request for mesos, Benjamin Bannier and Till Toenshoff.


Repository: mesos


Description
-------

This change slightly modifies Posix and Windows builds.

The following isolators were included in all platforms, but the sources
were excluded from Windows builds:
  * environment_secret
  * filesystem/posix
  * posix/disk
  * posix/rlimits
  * volume/sandbox_path
These sources are now included in all platforms.

The `docker/volume` and `network/cni` sources were built on Posix,
but were only used on Linux.  These sources and targets are now excluded
on Posix.


Diffs
-----

  src/CMakeLists.txt a574d449dc26b820cbef7ff0b5e94b42b6fe86cf 
  src/slave/CMakeLists.txt f42a4a6bda7ebb0af05df051bd5f07fbef33bf6d 
  src/slave/containerizer/mesos/CMakeLists.txt 92f4a49fdab43bb6767021e0332e2eaa205b0fec 


Diff: https://reviews.apache.org/r/69749/diff/1/


Testing
-------

cmake --build . --target tests

On OSX and Windows.


Thanks,

Joseph Wu