You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by orhankislal <gi...@git.apache.org> on 2016/03/15 21:17:32 UTC
[GitHub] incubator-madlib pull request: Recursive_partitioning: Fix random ...
GitHub user orhankislal opened a pull request:
https://github.com/apache/incubator-madlib/pull/32
Recursive_partitioning: Fix random forrest error message
JIRA: MADLIB-975
Random forest train gave a non-descript error if every data point had a NULL feature. Added an if check and and assert to give a proper description of the situation.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/orhankislal/incubator-madlib bugfix/random_forest
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/32.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #32
----
commit 795723a421276b9c46aa7b90c096cd5ddfd5bc12
Author: Orhan Kislal <ok...@pivotal.io>
Date: 2016-03-10T19:30:03Z
Recursive_partitioning: Fix random forrest error message
JIRA: MADLIB-975
Random forest train gave a non-descript error if every data point had a NULL feature. Added an if check and and assert to give a proper description of the situation.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request: Recursive_partitioning: Fix random ...
Posted by iyerr3 <gi...@git.apache.org>.
Github user iyerr3 commented on a diff in the pull request:
https://github.com/apache/incubator-madlib/pull/32#discussion_r57494868
--- Diff: src/ports/postgres/modules/recursive_partitioning/decision_tree.py_in ---
@@ -669,6 +669,8 @@ def _get_n_and_deplist(training_table_name, dependent_variable, filter_null):
source=training_table_name,
filter_null=filter_null)
r = plpy.execute(sql)[0]
+ if r['n_rows'] is None:
+ return None, None
--- End diff --
It's better to return `0` instead of the `None` for `n_rows`. The _assert in the calling function could be changed to `n_rows > 0`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request: Recursive_partitioning: Fix random ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-madlib/pull/32
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---