You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2021/03/08 12:25:38 UTC

[GitHub] [hbase] wchevreuil commented on pull request #2923: HBASE-25548 Optionally allow snapshots to preserve cluster's max file…

wchevreuil commented on pull request #2923:
URL: https://github.com/apache/hbase/pull/2923#issuecomment-792722054


   > Great! Please fix the reported static checks. I only have 1 question on the shell help text.
   
   Had addresse the whitespace and checkstyle issues. I'm not sure about the reported spotbugs issue, it's complaining about `org.apache.hadoop.hbase.rest.client.Client`, which I had not even touched here. As for the rubocop, it's complaining about the size of the `admin.rb:1208:30` complaint is not added by this PR. The remaining ones are related to the overall size of the snapshot method, but we need the three extra lines added here to handle the extra optional param.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org