You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "kou (via GitHub)" <gi...@apache.org> on 2023/08/25 22:44:39 UTC
[GitHub] [arrow] kou opened a new pull request, #37395: GH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile()
kou opened a new pull request, #37395:
URL: https://github.com/apache/arrow/pull/37395
### Rationale for this change
I don't know why but `try_compile()` based `Aws::SDKOptions::ioOptions` detection seems not work on some environments. Some unrelated errors may be happen.
### What changes are included in this PR?
Using `AWS_SDK_VERSION_{MAJOR,MINOR,PATCH}` instead of `try_compile()`.
Downside: `AWS_SDK_VERSION_*` are available since 1.9.7 or later but `Aws::SDKOptions::ioOptions` is available since 1.9.0. So we can't detect `Aws::SDKOptions::ioOptions` with [1.9.0,1.9.6]. I think that it's acceptable.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #37395: GH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #37395:
URL: https://github.com/apache/arrow/pull/37395#issuecomment-1698305080
Thanks for confirming this.
I'll merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37395: GH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile()
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37395:
URL: https://github.com/apache/arrow/pull/37395#issuecomment-1694008664
:warning: GitHub issue #37394 **has been automatically assigned in GitHub** to PR creator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] conbench-apache-arrow[bot] commented on pull request #37395: GH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile()
Posted by "conbench-apache-arrow[bot] (via GitHub)" <gi...@apache.org>.
conbench-apache-arrow[bot] commented on PR #37395:
URL: https://github.com/apache/arrow/pull/37395#issuecomment-1700859315
After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 8ba3264e5a647d817f17be29f744b55c87e6fff7.
There were no benchmark performance regressions. 🎉
The [full Conbench report](https://github.com/apache/arrow/runs/16379463811) has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #37395: GH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #37395:
URL: https://github.com/apache/arrow/pull/37395#issuecomment-1694014681
@github-actions crossbow submit wheel-manylinux-2014-cp38-amd64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou merged pull request #37395: GH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #37395:
URL: https://github.com/apache/arrow/pull/37395
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #37395: GH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile()
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37395:
URL: https://github.com/apache/arrow/pull/37395#issuecomment-1694015834
Revision: 2a39548d7eca5498d2e67497da2ab11c2fe97e4f
Submitted crossbow builds: [ursacomputing/crossbow @ actions-354116d456](https://github.com/ursacomputing/crossbow/branches/all?query=actions-354116d456)
|Task|Status|
|----|------|
|wheel-manylinux-2014-cp38-amd64|[](https://github.com/ursacomputing/crossbow/actions/runs/5981141898/job/16228534004)|
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kou commented on pull request #37395: GH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile()
Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #37395:
URL: https://github.com/apache/arrow/pull/37395#issuecomment-1694008645
@austinzh Could you try this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] austinzh commented on pull request #37395: GH-37394: [C++][S3] Use AWS_SDK_VERSION_* instead of try_compile()
Posted by "austinzh (via GitHub)" <gi...@apache.org>.
austinzh commented on PR #37395:
URL: https://github.com/apache/arrow/pull/37395#issuecomment-1697713964
> @austinzh Could you try this?
OMP_NUM_THREADS=1 python
```python
>>> os.getpid()
676616
>>> import pyarrow as pa
>>> import pyarrow.fs as fs
```
```bash
ps -T -p 676616
PID SPID TTY TIME CMD
676616 676616 pts/309 00:00:00 python
676616 698827 pts/309 00:00:00 jemalloc_bg_thd
676616 700384 pts/309 00:00:00 AwsEventLoop 1
```
It work!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org