You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by kdubb <gi...@git.apache.org> on 2015/10/13 23:07:03 UTC

[GitHub] thrift pull request: Thrift 2905 fixes

GitHub user kdubb opened a pull request:

    https://github.com/apache/thrift/pull/652

    Thrift 2905 fixes

    * Fixes incorrect generics generation for boxed types
    • Fixes rendering of complex constant values (e.g. maps of structs & ints)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/reTXT/thrift THRIFT-2905-Fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/652.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #652
    
----
commit bbace44067ba568add3211b7b6fab17eb31925f3
Author: Kevin Wooten <ke...@wooten.com>
Date:   2015-10-13T20:53:39Z

    Fix generics declarations for boxed types

commit 67b75507b449f87a4ba1b6aa1b1866318eee1c3f
Author: Kevin Wooten <ke...@wooten.com>
Date:   2015-10-13T20:53:58Z

    Fix complex constant rendering

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Thrift 2905 fixes

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/652


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: Thrift 2905 fixes

Posted by Jens-G <gi...@git.apache.org>.
Github user Jens-G commented on the pull request:

    https://github.com/apache/thrift/pull/652#issuecomment-147864780
  
    Tracked in THRIFT-3381
    
    (@kdubb: if you create the JIRA ticket before the PR and reference the ticket within the PR we get the PR message into the ticket automatically.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---