You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/07/09 10:23:24 UTC
[GitHub] [calcite] danny0405 opened a new pull request #2061: [CALCITE-4115] Improve the prompt of using SQL keywords for sql parser
danny0405 opened a new pull request #2061:
URL: https://github.com/apache/calcite/pull/2061
When the parser encounters a reserved-keyword and throws, change the
error message format to:
Incorrect syntax near the keyword '{keyword}' at line {line_number}, column {column_number}.
The new format indicates that the next token is a keyword clearly so
that user can choose to use a non-reserved keyword or quotes the keyword instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] DonnyZone commented on pull request #2061: [CALCITE-4115] Improve the prompt of using SQL keywords for sql parser
Posted by GitBox <gi...@apache.org>.
DonnyZone commented on pull request #2061:
URL: https://github.com/apache/calcite/pull/2061#issuecomment-656503325
+1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] rubenada commented on pull request #2061: [CALCITE-4115] Improve the prompt of using SQL keywords for sql parser
Posted by GitBox <gi...@apache.org>.
rubenada commented on pull request #2061:
URL: https://github.com/apache/calcite/pull/2061#issuecomment-656059817
LGTM
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] danny0405 merged pull request #2061: [CALCITE-4115] Improve the prompt of using SQL keywords for sql parser
Posted by GitBox <gi...@apache.org>.
danny0405 merged pull request #2061:
URL: https://github.com/apache/calcite/pull/2061
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [calcite] Aaaaaaron commented on pull request #2061: [CALCITE-4115] Improve the prompt of using SQL keywords for sql parser
Posted by GitBox <gi...@apache.org>.
Aaaaaaron commented on pull request #2061:
URL: https://github.com/apache/calcite/pull/2061#issuecomment-656053478
+1 more readable err msg.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org