You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/14 18:02:35 UTC

[GitHub] [kafka] cmccabe commented on pull request #10688: KAFKA-12778: Fix QuorumController request timeouts and electLeaders

cmccabe commented on pull request #10688:
URL: https://github.com/apache/kafka/pull/10688#issuecomment-841410862


   > Generally, I don't like that we need to explicitly extract the timeout from the request and pass it into the controller call. It would nice if this could be generalized or automated somehow. However, something like this is not needed for this minor fix.
   
   If we were starting all over again, we could give all RPC requests a timeout, located in the request header itself.  But that isn't really the case today -- some requests don't have timeouts, some do, and we have to extract it from the specific request schema.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org