You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kafka.apache.org by gw...@apache.org on 2016/05/18 02:18:37 UTC

kafka git commit: MINOR: Exclude jline, netty and findbugs annotations

Repository: kafka
Updated Branches:
  refs/heads/trunk ab8fc8638 -> 9a44d938d


MINOR: Exclude jline, netty and findbugs annotations

These dependencies are unnecessary and they are acquired
transitively via zkclient (jline, netty) and reflections (annotations).

Ewen did the hard work in figuring out why we have unexpected
additional dependencies since 0.9.x.

Author: Ismael Juma <is...@juma.me.uk>

Reviewers: Ewen Cheslack-Postava, Guozhang Wang, Gwen Shapira

Closes #1396 from ijuma/exclude-jline-netty-deps-in-streams and squashes the following commits:

3aa366f [Ismael Juma] Exclude findbugs annotations due to LGPL license
2d3d714 [Ismael Juma] Use local exclusion for `jline` and `netty`
482b6c0 [Ismael Juma] Exclude `jline` and `netty` dependencies in the `streams` project


Project: http://git-wip-us.apache.org/repos/asf/kafka/repo
Commit: http://git-wip-us.apache.org/repos/asf/kafka/commit/9a44d938
Tree: http://git-wip-us.apache.org/repos/asf/kafka/tree/9a44d938
Diff: http://git-wip-us.apache.org/repos/asf/kafka/diff/9a44d938

Branch: refs/heads/trunk
Commit: 9a44d938da4badec25e30733409cf7299e945bf6
Parents: ab8fc86
Author: Ismael Juma <is...@juma.me.uk>
Authored: Tue May 17 19:18:33 2016 -0700
Committer: Gwen Shapira <cs...@gmail.com>
Committed: Tue May 17 19:18:33 2016 -0700

----------------------------------------------------------------------
 build.gradle | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/kafka/blob/9a44d938/build.gradle
----------------------------------------------------------------------
diff --git a/build.gradle b/build.gradle
index ab47bce..91f0637 100644
--- a/build.gradle
+++ b/build.gradle
@@ -663,7 +663,11 @@ project(':streams') {
     compile project(':connect:json')  // this dependency should be removed after we unify data API
     compile libs.slf4jlog4j
     compile libs.rocksDBJni
-    compile libs.zkclient // this dependency should be removed after KIP-4
+    // this dependency should be removed after KIP-4
+    compile (libs.zkclient) {
+      exclude module: 'jline'
+      exclude module: 'netty'
+    }
     compile libs.jacksonDatabind // this dependency should be removed after KIP-4
 
     testCompile project(':clients').sourceSets.test.output
@@ -829,7 +833,10 @@ project(':connect:runtime') {
     compile libs.jettyServer
     compile libs.jettyServlet
     compile libs.jettyServlets
-    compile libs.reflections
+    compile(libs.reflections) {
+      // Exclude because of LGPL license
+      exclude group: 'com.google.code.findbugs', module: 'annotations'
+    }
 
     testCompile project(':clients').sourceSets.test.output
     testCompile libs.easymock