[GitHub] brooklyn-library pull request #160: jenkins: don't bind mount .m2

[aledsage <gi...@git.apache.org>]

GitHub user aledsage opened a pull request:

    https://github.com/apache/brooklyn-library/pull/160

    jenkins: don't bind mount .m2

    As per the recommendations from Apache Infra in INFRA-16417 (comments [1] and [2]).
    
    [1] https://issues.apache.org/jira/browse/INFRA-16417?focusedCommentId=16452458&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16452458
    [2] https://issues.apache.org/jira/browse/INFRA-16417?focusedCommentId=16466275&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16466275
    
    ---
    This will make then jenkins build a bit slower (downloading all of the .m2 cache each time), but should fix the permissions errors we've been seeing.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aledsage/brooklyn-library fix-jenkins-build-m2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/brooklyn-library/pull/160.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #160
    
----
commit 83417d46821a1f5dcfc25b5da9dba05b29eafb79
Author: Aled Sage <al...@...>
Date:   2018-09-24T15:11:43Z

    jenkins: don't bind mount .m2

----


---

[GitHub] brooklyn-library pull request #160: jenkins: don't bind mount .m2

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/brooklyn-library/pull/160


---

[GitHub] brooklyn-library issue #160: jenkins: don't bind mount .m2

[aledsage <gi...@git.apache.org>]

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-library/pull/160
  
    I've created https://builds.apache.org/view/B/view/Brooklyn/job/brooklyn-library-master-docker-pipeline/. The first run failed due to the rat check, which this PR fixes.
    
    Merging this now, and will re-run the pipeline build.


---

[GitHub] brooklyn-library issue #160: jenkins: don't bind mount .m2

[tbouron <gi...@git.apache.org>]

Github user tbouron commented on the issue:

    https://github.com/apache/brooklyn-library/pull/160
  
    This looks fine @aledsage but I can see 2 issues there:
    1. what about the `settings.xml`? In the PR context, we don't care because we don't push artifacts to maven central but as soon as it is merged, the real jenkins job will try that and will then fail because the credentials are stored there
    2. This means that we will need to add the same `<exclude>...</exclude>` lines to every brooklyn submodule


---

[GitHub] brooklyn-library issue #160: jenkins: don't bind mount .m2

[aledsage <gi...@git.apache.org>]

Github user aledsage commented on the issue:

    https://github.com/apache/brooklyn-library/pull/160
  
    @tbouron I suspect that the `Jenkinsfile` has no effect, and that it just uses the configuration in https://builds.apache.org/view/B/view/Brooklyn/job/brooklyn-library-master-docker/configure.
    e.g. the most recent build (https://builds.apache.org/view/B/view/Brooklyn/job/brooklyn-library-master-docker/336/consoleFull) has a docker command that matches the `/configure` page rather than the Jenkinsfile.
    
    Am I missing something?
    
    I'm going to create a new job (`brooklyn-library-master-docker-pipeline`) to try to set it up to use the Jenkinsfile (i.e. use pipelines).


---