You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/03/20 23:05:15 UTC

[GitHub] marcoabreu commented on a change in pull request #10169: [MXNET-101] Support float16 in LeakyReLU operator

marcoabreu commented on a change in pull request #10169: [MXNET-101] Support float16 in LeakyReLU operator
URL: https://github.com/apache/incubator-mxnet/pull/10169#discussion_r175949738
 
 

 ##########
 File path: src/operator/leaky_relu-inl.h
 ##########
 @@ -217,7 +237,7 @@ class LeakyReLUOp : public Operator {
 };  // class LeakyReLUOp
 
 template<typename xpu>
-Operator* CreateOp(LeakyReLUParam type);
+Operator* CreateOp(LeakyReLUParam type, int dtype);
 
 Review comment:
   Sorry, I'm not familiar with the cpp code, but is there no typedef for dtype - int is kind of arbitrary.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services