Re: does anyone knows why this code was commented?

[Martin Grigorov <mg...@apache.org>]

https://issues.apache.org/jira/browse/WICKET-6890

For now it is only in master (10.x).
Should I backport it to 9.x ?

On Sat, Apr 24, 2021 at 9:51 AM Ernesto Reinaldo Barreiro <
reiern70@gmail.com> wrote:

> Hi,
>
> On Fri, Apr 23, 2021 at 10:28 PM Martin Grigorov <mg...@apache.org>
> wrote:
>
> > We can fix the issue with the CSS rules with siblings by using HTML
> > attribute instead of HTML comments.
> >
> +1
>
> >
> > Does this count as a behavior break? I.e. do you think that we can make
> > this change in 9.x?
> >
> > I think this would be a valid approach. This would/should not affect
> production systems as it is a development feature. If someone is using this
> in production IMHO it is "fair" to break this for them :-)
>
> On Fri, Apr 23, 2021, 18:12 Maxim Solodovnik <so...@gmail.com> wrote:
> >
> > > Here is the commit:
> > >
> > >
> >
> https://svn.apache.org/viewvc/wicket/trunk/wicket/src/main/java/org/apache/wicket/Application.java?r1=737748&r2=745986&pathrev=1037297&diff_format=h
> > >
> > > On Fri, 23 Apr 2021 at 20:42, Martin Grigorov <mg...@apache.org>
> > > wrote:
> > >
> > > > I think it is disabled because it may break CSS rules with siblings.
> > > >
> > > > On Fri, Apr 23, 2021 at 4:24 PM Ernesto Reinaldo Barreiro <
> > > > reiern70@gmail.com> wrote:
> > > >
> > > > > I always disable this explicitly in my applications (even if I use
> > > > > development mode), because I had this feature breaking some not
> well
> > > > > designed 3rd party JS widgets... But I was just curious how this
> was
> > > > > disabled by commenting it out.
> > > > >
> > > > > On Fri, Apr 23, 2021 at 4:12 PM Martin Grigorov <
> > mgrigorov@apache.org>
> > > > > wrote:
> > > > >
> > > > > > On Fri, Apr 23, 2021 at 4:07 PM Ernesto Reinaldo Barreiro <
> > > > > > reiern70@gmail.com> wrote:
> > > > > >
> > > > > > > Hi Martin,
> > > > > > >
> > > > > > > Thanks for your answer. Better than that (use the source Luke)
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/wicket/blob/master/wicket-core/src/main/java/org/apache/wicket/Application.java#L292
> > > > > >
> > > > > >
> > > > > > I have no idea. And Git history does not remember too.
> > > > > >
> > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Fri, Apr 23, 2021 at 3:59 PM Martin Grigorov <
> > > > mgrigorov@apache.org>
> > > > > > > wrote:
> > > > > > >
> > > > > > > > Hi Ernesto,
> > > > > > > >
> > > > > > > > On Fri, Apr 23, 2021 at 3:57 PM Ernesto Reinaldo Barreiro <
> > > > > > > > reiern70@gmail.com> wrote:
> > > > > > > >
> > > > > > > > > [image: image.png]
> > > > > > > > >
> > > > > > > >
> > > > > > > > The image didn't make it thru the mailing list.
> > > > > > > > Please use an online image pastebin service.
> > > > > > > >
> > > > > > > >
> > > > > > > > >
> > > > > > > > > Someone at work asked a question about how to know how to
> get
> > > > from
> > > > > > HTML
> > > > > > > > to
> > > > > > > > > java code... and I had the impression this was enabled  by
> > > > default
> > > > > on
> > > > > > > > > development mode.
> > > > > > > > >
> > > > > > > > > --
> > > > > > > > > Regards - Ernesto Reinaldo Barreiro
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > --
> > > > > > > Regards - Ernesto Reinaldo Barreiro
> > > > > > >
> > > > > >
> > > > >
> > > > >
> > > > > --
> > > > > Regards - Ernesto Reinaldo Barreiro
> > > > >
> > > >
> > >
> > >
> > > --
> > > Best regards,
> > > Maxim
> > >
> >
>
>
> --
> Regards - Ernesto Reinaldo Barreiro
>