You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by brandtg <gi...@git.apache.org> on 2015/07/18 21:55:52 UTC

[GitHub] helix pull request: Cleaned up ByteBuf usage in IPC

GitHub user brandtg opened a pull request:

    https://github.com/apache/helix/pull/33

    Cleaned up ByteBuf usage in IPC

    Removed dead code in IPC
    
    Made max frame length configurable (also bumped to 128MB default)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/brandtg/helix master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/helix/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #33
    
----
commit 0cf986e1734a8e2261f14d0e5a4463e8826c4457
Author: Greg Brandt <br...@gmail.com>
Date:   2015-07-01T22:50:04Z

    Cleaned up ByteBuf usage in IPC
    
    Removed dead code in IPC
    
    Made max frame length configurable (also bumped to 128MB default)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request: Cleaned up ByteBuf usage in IPC

Posted by kanakb <gi...@git.apache.org>.
Github user kanakb commented on the pull request:

    https://github.com/apache/helix/pull/33#issuecomment-125824667
  
    LGTM as well. Feel free to merge this.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request: Cleaned up ByteBuf usage in IPC

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/helix/pull/33


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] helix pull request: Cleaned up ByteBuf usage in IPC

Posted by kishoreg <gi...@git.apache.org>.
Github user kishoreg commented on the pull request:

    https://github.com/apache/helix/pull/33#issuecomment-122676485
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---