You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/11/15 00:27:01 UTC
[GitHub] [maven-assembly-plugin] hboutemy opened a new pull request, #96: MASSEMBLY-941 keep file permission in Reproducible mode
hboutemy opened a new pull request, #96:
URL: https://github.com/apache/maven-assembly-plugin/pull/96
https://issues.apache.org/jira/browse/MASSEMBLY-941
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] michael-o commented on pull request #96: MASSEMBLY-941 keep file permission in Reproducible mode
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #96:
URL: https://github.com/apache/maven-assembly-plugin/pull/96#issuecomment-1314838447
Use %n
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] hboutemy commented on pull request #96: MASSEMBLY-941 keep file permission in Reproducible mode
Posted by GitBox <gi...@apache.org>.
hboutemy commented on PR #96:
URL: https://github.com/apache/maven-assembly-plugin/pull/96#issuecomment-1328022605
> It is not related, I just noticed it. If you really just need a LF then a comment should tell about your intent.
AFAIK there is nothing related to LF in this PR, then I suppose I should just ignore that comment that looks to me just a mistake (no pun intended, it happens to me also to completely be out of context because I misread something): if you think there is one place in the PR where it applies, please precise the location
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] hboutemy merged pull request #96: MASSEMBLY-941 keep file permission in Reproducible mode
Posted by GitBox <gi...@apache.org>.
hboutemy merged PR #96:
URL: https://github.com/apache/maven-assembly-plugin/pull/96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] michael-o commented on pull request #96: MASSEMBLY-941 keep file permission in Reproducible mode
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #96:
URL: https://github.com/apache/maven-assembly-plugin/pull/96#issuecomment-1328012266
> > @michael-o what does "use %n" mean, please?
>
> In `String.format` instead of `\n` I presume...
Almost, it is replaced with the platform line separator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] michael-o commented on pull request #96: MASSEMBLY-941 keep file permission in Reproducible mode
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #96:
URL: https://github.com/apache/maven-assembly-plugin/pull/96#issuecomment-1328022890
> > It is not related, I just noticed it. If you really just need a LF then a comment should tell about your intent.
>
> AFAIK there is nothing related to LF in this PR, then I suppose I should just ignore that comment that looks to me just a mistake (no pun intended, it happens to me also to completely be out of context because I misread something): if you think there is one place in the PR where it applies, please precise the location
Agreed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] hboutemy commented on pull request #96: MASSEMBLY-941 keep file permission in Reproducible mode
Posted by GitBox <gi...@apache.org>.
hboutemy commented on PR #96:
URL: https://github.com/apache/maven-assembly-plugin/pull/96#issuecomment-1328019752
ok, but how does it relate to this PR?
In the current PR, Windows is a pain not as usual because it has specific newlines, but because it can't detect executable files on filesystem (`100644 executable.txt`) (notice that Unix is a pain because it has 2 representations: `100755 executable.txt`and `100775 executable.txt`)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] pzygielo commented on pull request #96: MASSEMBLY-941 keep file permission in Reproducible mode
Posted by GitBox <gi...@apache.org>.
pzygielo commented on PR #96:
URL: https://github.com/apache/maven-assembly-plugin/pull/96#issuecomment-1328007843
> @michael-o what does "use %n" mean, please?
In `String.format` instead of `\n` I presume...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] hboutemy commented on pull request #96: MASSEMBLY-941 keep file permission in Reproducible mode
Posted by GitBox <gi...@apache.org>.
hboutemy commented on PR #96:
URL: https://github.com/apache/maven-assembly-plugin/pull/96#issuecomment-1327957698
@michael-o what does "use %n" mean, please?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-assembly-plugin] michael-o commented on pull request #96: MASSEMBLY-941 keep file permission in Reproducible mode
Posted by GitBox <gi...@apache.org>.
michael-o commented on PR #96:
URL: https://github.com/apache/maven-assembly-plugin/pull/96#issuecomment-1328021439
> ok, but how does it relate to this PR?
>
> In the current PR, Windows is a pain not as usual because it has specific newlines, but because it can't detect executable files on filesystem (`100644 executable.txt`) (notice that Unix is a pain because it has 2 representations: `100755 executable.txt`and `100775 executable.txt`)
It is not related, I just noticed it. If you really just need a LF then a comment should tell about your intent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org