You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ji...@codehaus.org on 2004/06/10 04:40:06 UTC
[jira] Commented: (MPJAVADOC-26) needed check incorrect
The following comment has been added to this issue:
Author: Denis McLaughlin
Created: Wed, 9 Jun 2004 10:38 PM
Body:
Many thanks!
Denis
---------------------------------------------------------------------
View this comment:
http://jira.codehaus.org/browse/MPJAVADOC-26?page=comments#action_20506
---------------------------------------------------------------------
View the issue:
http://jira.codehaus.org/browse/MPJAVADOC-26
Here is an overview of the issue:
---------------------------------------------------------------------
Key: MPJAVADOC-26
Summary: needed check incorrect
Type: Bug
Status: Closed
Priority: Minor
Resolution: FIXED
Original Estimate: 10 minutes
Time Spent: Unknown
Remaining: 10 minutes
Project: maven-javadoc-plugin
Fix Fors:
1.5.1
Versions:
1.5.1
Assignee: Jason van Zyl
Reporter: Denis McLaughlin
Created: Thu, 3 Jun 2004 11:46 PM
Updated: Wed, 9 Jun 2004 10:38 PM
Description:
The javadoc plugin has undergone some changes adding support for iterating across the directories in the maven.compile.src.set path ref. However, there is an error in the check:needed logic.
Line numbers below are against this version of the plugin:
http://cvs.apache.org/viewcvs.cgi/maven-plugins/javadoc/plugin.jelly?rev=1.42&view=markup
The foreach loop at line 99 iterates across the directories in the maven.compile.src.set. The test at line 101 reads:
<j:if test="${needed == null}">
If there are two directories in maven.compile.src.set, and the first directory has no source files in it, then the first iteration of this loop will leave needed equal to false. The second time through the loop, since needed is no longer equal to null, the loop is short circuited, and, because needed is false, no processing is done, even though there may be valid source files in the second directory.
Changing the test on line 101 to:
<j:if test="${needed != true}">
will correct this problem, short circuiting the loop only after the first directory with valid source files is found.
Denis
---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
If you want more information on JIRA, or have a bug to report see:
http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org