You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "dpogue (via GitHub)" <gi...@apache.org> on 2024/03/26 06:19:55 UTC
[PR] chore(deps): Update npm deps, add Node 20 to CI [cordova-create]
dpogue opened a new pull request, #86:
URL: https://github.com/apache/cordova-create/pull/86
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
All
### Motivation and Context
<!-- Why is this change required? What problem does it solve? -->
<!-- If it fixes an open issue, please link to the issue here. -->
Update some dependencies.
### Description
<!-- Describe your changes in detail -->
* Add node 20 to CI
* Update GitHub Actions dependencies
* Rebuild package-lock to resolve npm audit warnings
* Replace `fs-extra` dependency with Node core `fs` API
### Testing
<!-- Please describe in detail how you tested your changes. -->
Unit tests pass.
### Checklist
- [x] I've run the tests to see all new and existing tests pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore(deps): Update npm deps, add Node 20 to CI [cordova-create]
Posted by "dpogue (via GitHub)" <gi...@apache.org>.
dpogue merged PR #86:
URL: https://github.com/apache/cordova-create/pull/86
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] chore(deps): Update npm deps, add Node 20 to CI [cordova-create]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #86:
URL: https://github.com/apache/cordova-create/pull/86#issuecomment-2055755226
## [Codecov](https://app.codecov.io/gh/apache/cordova-create/pull/86?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `85.71429%` with `1 lines` in your changes are missing coverage. Please review.
> Project coverage is 89.70%. Comparing base [(`3280edc`)](https://app.codecov.io/gh/apache/cordova-create/commit/3280edc1fe1b0ad5fb63df2f1f3377a6fbf30855?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`d1c9c4c`)](https://app.codecov.io/gh/apache/cordova-create/pull/86?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
| [Files](https://app.codecov.io/gh/apache/cordova-create/pull/86?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [index.js](https://app.codecov.io/gh/apache/cordova-create/pull/86?src=pr&el=tree&filepath=index.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW5kZXguanM=) | 85.71% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/cordova-create/pull/86?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 89.55% 89.70% +0.15%
==========================================
Files 1 1
Lines 67 68 +1
==========================================
+ Hits 60 61 +1
Misses 7 7
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cordova-create/pull/86?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org