[GitHub] wohali commented on issue #1160: Add support for Bcrypt password hashing

[GitBox <gi...@apache.org>]

wohali commented on issue #1160: Add support for Bcrypt password hashing
URL: https://github.com/apache/couchdb/pull/1160#issuecomment-405986847
 
 
   @pierrekilly @janl unfortunately bcrypt is terminally broken on Windows, as it is missing the BSD libc extensions (queue.h) and a useful pthreads implementation.
   
   Further, it seems to me that it makes no sense for our NIF to link to a function that is, itself, launching pthreads. Surely this will wreak havoc with the Erlang scheduler? /cc @davisp 
   
   I am unfortunately going to have to remove this functionality to unblock the 2.2 release for now, as we can't hold up the release waiting for a rewrite. 
   
   I have restored the `bcrypt` branch so that work can be ongoing for this in a future release. I will attempt to cherry-pick any bcrypt changes that landed post-`bcrypt` to that branch as a convenience.
   
   Since both PRs have landed, I will open a new ticket for this issue to track work going forward.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services