You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by nitin-amp <gi...@git.apache.org> on 2016/04/02 09:44:18 UTC

[GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

GitHub user nitin-amp opened a pull request:

    https://github.com/apache/incubator-geode/pull/122

    GEODE-1163 Fix branding in Swagger UI

    Fixed residual Pivotal/ Gemfire branding on Swagger UI. Please suggest if using LocalizedString should not be used here.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/nitin-amp/incubator-geode develop

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-geode/pull/122.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #122
    
----
commit 90e02e7cc62b8082e91a424b2da38e74ea4ba225
Author: Nitin Lamba <nl...@apache.org>
Date:   2016-04-02T07:40:58Z

    GEODE-1163 Fix branding in Swagger UI

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

Posted by Anthony Baker <ab...@pivotal.io>.
Done.

Anthony

> On Apr 8, 2016, at 9:07 PM, Dan Smith <ds...@pivotal.io> wrote:
> 
> Hi Nitin,
> 
> Github is just a mirror, you need to push your changes to the apache
> repository. Use this url and your apache credentials:
> 
> https://git-wip-us.apache.org/repos/asf/incubator-geode.git
> 
> -Dan
> 
> On Fri, Apr 8, 2016 at 7:35 PM, Nitin Lamba <ni...@gmail.com> wrote:
> 
>> I tried but get the following error:
>> 
>> Pushing to https://nitin-amp@github.com/apache/incubator-geode.git
>> remote: Permission to apache/incubator-geode.git denied to nitin-amp.
>> 
>> Perhaps, it was not enabled last month OR I may be doing something wrong.
>> 
>> Any help is appreciated. Thanks
>> 
>> 
>> On Fri, Apr 8, 2016 at 3:42 PM, Swapnil Bawaskar <sb...@pivotal.io>
>> wrote:
>> 
>>> I have merged-in my pull requests in the past. So, I think you can too.
>>> Just follow the instructions in "Accepting the Pull-request" section on
>>> https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
>>> 
>>> On Fri, Apr 8, 2016 at 3:34 PM, Nitin Lamba <nl...@apache.org> wrote:
>>> 
>>>> Any takers for merging this in? Don't think I could as I created the
>> pull
>>>> request :)
>>>> 
>>>> Thanks,
>>>> Nitin
>>>> 
>>>> On Thu, Apr 7, 2016 at 10:19 AM, sboorlagadda <gi...@git.apache.org>
>>> wrote:
>>>> 
>>>>> Github user sboorlagadda commented on the pull request:
>>>>> 
>>>>> 
>>>>> 
>>>> 
>>> 
>> https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
>>>>> 
>>>>>    +1
>>>>> 
>>>>> 
>>>>> ---
>>>>> If your project is set up for it, you can reply to this email and
>> have
>>>> your
>>>>> reply appear on GitHub as well. If your project does not have this
>>>> feature
>>>>> enabled and wishes so, or if the feature is enabled but not working,
>>>> please
>>>>> contact infrastructure at infrastructure@apache.org or file a JIRA
>>>> ticket
>>>>> with INFRA.
>>>>> ---
>>>>> 
>>>> 
>>> 
>>

Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

Posted by Nitin Lamba <ni...@gmail.com>.
Hi Dan,

I tried that first (without https) but got a permission denied (pubkey)
error - will try your suggested URL again next time.

Thanks @Anthony!
Nitin

On Friday, April 8, 2016, Dan Smith <ds...@pivotal.io> wrote:

> Hi Nitin,
>
> Github is just a mirror, you need to push your changes to the apache
> repository. Use this url and your apache credentials:
>
> https://git-wip-us.apache.org/repos/asf/incubator-geode.git
>
> -Dan
>
> On Fri, Apr 8, 2016 at 7:35 PM, Nitin Lamba <nitin.lamba@gmail.com
> <javascript:;>> wrote:
>
> > I tried but get the following error:
> >
> > Pushing to https://nitin-amp@github.com/apache/incubator-geode.git
> > remote: Permission to apache/incubator-geode.git denied to nitin-amp.
> >
> > Perhaps, it was not enabled last month OR I may be doing something wrong.
> >
> > Any help is appreciated. Thanks
> >
> >
> > On Fri, Apr 8, 2016 at 3:42 PM, Swapnil Bawaskar <sbawaskar@pivotal.io
> <javascript:;>>
> > wrote:
> >
> > > I have merged-in my pull requests in the past. So, I think you can too.
> > > Just follow the instructions in "Accepting the Pull-request" section on
> > > https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
> > >
> > > On Fri, Apr 8, 2016 at 3:34 PM, Nitin Lamba <nlamba@apache.org
> <javascript:;>> wrote:
> > >
> > > > Any takers for merging this in? Don't think I could as I created the
> > pull
> > > > request :)
> > > >
> > > > Thanks,
> > > > Nitin
> > > >
> > > > On Thu, Apr 7, 2016 at 10:19 AM, sboorlagadda <git@git.apache.org
> <javascript:;>>
> > > wrote:
> > > >
> > > > > Github user sboorlagadda commented on the pull request:
> > > > >
> > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
> > > > >
> > > > >     +1
> > > > >
> > > > >
> > > > > ---
> > > > > If your project is set up for it, you can reply to this email and
> > have
> > > > your
> > > > > reply appear on GitHub as well. If your project does not have this
> > > > feature
> > > > > enabled and wishes so, or if the feature is enabled but not
> working,
> > > > please
> > > > > contact infrastructure at infrastructure@apache.org <javascript:;>
> or file a JIRA
> > > > ticket
> > > > > with INFRA.
> > > > > ---
> > > > >
> > > >
> > >
> >
>

Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

Posted by Dan Smith <ds...@pivotal.io>.
Hi Nitin,

Github is just a mirror, you need to push your changes to the apache
repository. Use this url and your apache credentials:

https://git-wip-us.apache.org/repos/asf/incubator-geode.git

-Dan

On Fri, Apr 8, 2016 at 7:35 PM, Nitin Lamba <ni...@gmail.com> wrote:

> I tried but get the following error:
>
> Pushing to https://nitin-amp@github.com/apache/incubator-geode.git
> remote: Permission to apache/incubator-geode.git denied to nitin-amp.
>
> Perhaps, it was not enabled last month OR I may be doing something wrong.
>
> Any help is appreciated. Thanks
>
>
> On Fri, Apr 8, 2016 at 3:42 PM, Swapnil Bawaskar <sb...@pivotal.io>
> wrote:
>
> > I have merged-in my pull requests in the past. So, I think you can too.
> > Just follow the instructions in "Accepting the Pull-request" section on
> > https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
> >
> > On Fri, Apr 8, 2016 at 3:34 PM, Nitin Lamba <nl...@apache.org> wrote:
> >
> > > Any takers for merging this in? Don't think I could as I created the
> pull
> > > request :)
> > >
> > > Thanks,
> > > Nitin
> > >
> > > On Thu, Apr 7, 2016 at 10:19 AM, sboorlagadda <gi...@git.apache.org>
> > wrote:
> > >
> > > > Github user sboorlagadda commented on the pull request:
> > > >
> > > >
> > > >
> > >
> >
> https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
> > > >
> > > >     +1
> > > >
> > > >
> > > > ---
> > > > If your project is set up for it, you can reply to this email and
> have
> > > your
> > > > reply appear on GitHub as well. If your project does not have this
> > > feature
> > > > enabled and wishes so, or if the feature is enabled but not working,
> > > please
> > > > contact infrastructure at infrastructure@apache.org or file a JIRA
> > > ticket
> > > > with INFRA.
> > > > ---
> > > >
> > >
> >
>

Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

Posted by Nitin Lamba <ni...@gmail.com>.
I tried but get the following error:

Pushing to https://nitin-amp@github.com/apache/incubator-geode.git
remote: Permission to apache/incubator-geode.git denied to nitin-amp.

Perhaps, it was not enabled last month OR I may be doing something wrong.

Any help is appreciated. Thanks


On Fri, Apr 8, 2016 at 3:42 PM, Swapnil Bawaskar <sb...@pivotal.io>
wrote:

> I have merged-in my pull requests in the past. So, I think you can too.
> Just follow the instructions in "Accepting the Pull-request" section on
> https://cwiki.apache.org/confluence/display/GEODE/Code+contributions
>
> On Fri, Apr 8, 2016 at 3:34 PM, Nitin Lamba <nl...@apache.org> wrote:
>
> > Any takers for merging this in? Don't think I could as I created the pull
> > request :)
> >
> > Thanks,
> > Nitin
> >
> > On Thu, Apr 7, 2016 at 10:19 AM, sboorlagadda <gi...@git.apache.org>
> wrote:
> >
> > > Github user sboorlagadda commented on the pull request:
> > >
> > >
> > >
> >
> https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
> > >
> > >     +1
> > >
> > >
> > > ---
> > > If your project is set up for it, you can reply to this email and have
> > your
> > > reply appear on GitHub as well. If your project does not have this
> > feature
> > > enabled and wishes so, or if the feature is enabled but not working,
> > please
> > > contact infrastructure at infrastructure@apache.org or file a JIRA
> > ticket
> > > with INFRA.
> > > ---
> > >
> >
>

Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

Posted by Swapnil Bawaskar <sb...@pivotal.io>.
I have merged-in my pull requests in the past. So, I think you can too.
Just follow the instructions in "Accepting the Pull-request" section on
https://cwiki.apache.org/confluence/display/GEODE/Code+contributions

On Fri, Apr 8, 2016 at 3:34 PM, Nitin Lamba <nl...@apache.org> wrote:

> Any takers for merging this in? Don't think I could as I created the pull
> request :)
>
> Thanks,
> Nitin
>
> On Thu, Apr 7, 2016 at 10:19 AM, sboorlagadda <gi...@git.apache.org> wrote:
>
> > Github user sboorlagadda commented on the pull request:
> >
> >
> >
> https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
> >
> >     +1
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
> >
>

Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

Posted by Nitin Lamba <nl...@apache.org>.
Any takers for merging this in? Don't think I could as I created the pull
request :)

Thanks,
Nitin

On Thu, Apr 7, 2016 at 10:19 AM, sboorlagadda <gi...@git.apache.org> wrote:

> Github user sboorlagadda commented on the pull request:
>
>
> https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
>
>     +1
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

Posted by sboorlagadda <gi...@git.apache.org>.
Github user sboorlagadda commented on the pull request:

    https://github.com/apache/incubator-geode/pull/122#issuecomment-207004440
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

Posted by sbawaska <gi...@git.apache.org>.
Github user sbawaska commented on the pull request:

    https://github.com/apache/incubator-geode/pull/122#issuecomment-206641336
  
    Yes!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

Posted by nitin-amp <gi...@git.apache.org>.
Github user nitin-amp commented on the pull request:

    https://github.com/apache/incubator-geode/pull/122#issuecomment-206624395
  
    Is this OK to merge? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Re: [GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

Posted by Nitin Lamba <nl...@apache.org>.
I've fixed the email

On Monday, April 4, 2016, sbawaska <gi...@git.apache.org> wrote:

> Github user sbawaska commented on the pull request:
>
>
> https://github.com/apache/incubator-geode/pull/122#issuecomment-205461981
>
>     +1
>     A minor nitpick, could you please make the support email user@?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org <javascript:;> or
> file a JIRA ticket
> with INFRA.
> ---
>

[GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

Posted by sbawaska <gi...@git.apache.org>.
Github user sbawaska commented on the pull request:

    https://github.com/apache/incubator-geode/pull/122#issuecomment-205461981
  
    +1
    A minor nitpick, could you please make the support email user@?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-geode pull request: GEODE-1163 Fix branding in Swagger U...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-geode/pull/122


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---