[GitHub] [incubator-kyuubi] yaooqinn commented on a diff in pull request #2447: [KYUUBI #2445] Implement ApplicationManager and Yarn/ JPS-local Application Operation

[GitBox <gi...@apache.org>]

yaooqinn commented on code in PR #2447:
URL: https://github.com/apache/incubator-kyuubi/pull/2447#discussion_r856068147


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala:
##########
@@ -78,34 +75,6 @@ class FlinkProcessBuilder(
 
   override protected def commands: Array[String] = Array(executable)
 
-  override def killApplication(clue: Either[String, String]): String = clue match {
-    case Left(_) => ""
-    case Right(line) => killApplicationByLog(line)
-  }
-
-  def killApplicationByLog(line: String = lastRowsOfLog.toArray.mkString("\n")): String = {
-    "Job ID: .*".r.findFirstIn(line) match {

Review Comment:
   this is an invalid implementation so I didn't move it somewhere but deleted it directly.
   
   
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org