[GitHub] [incubator-pinot] haibow commented on a change in pull request #5137: Fix the ConstantValueDictionary

[GitBox <gi...@apache.org>]

haibow commented on a change in pull request #5137: Fix the ConstantValueDictionary
URL: https://github.com/apache/incubator-pinot/pull/5137#discussion_r390728351
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/io/reader/impl/ConstantSingleValueSortedIndex.java
 ##########
 @@ -59,26 +42,32 @@ public int getInt(int row) {
   }
 
   @Override
-  public int getInt(int rowId, SortedIndexReaderImpl.Context context) {
+  public int getInt(int rowId, ReaderContext context) {
     return 0;
   }
 
   @Override
-  public void close()
-      throws IOException {
+  public void readValues(int[] rows, int rowStartPos, int rowSize, int[] values, int valuesStartPos) {
+    Arrays.fill(values, valuesStartPos, valuesStartPos + rowSize, 0);
 
 Review comment:
   Good catch. Could you fix another older misuse too:
   https://github.com/apache/incubator-pinot/blob/master/pinot-core/src/main/java/org/apache/pinot/core/io/reader/impl/IntSingleValueDataFileReader.java#L54

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org