You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "Attila Doroszlai (Jira)" <ji...@apache.org> on 2024/06/26 09:08:00 UTC
[jira] [Resolved] (HDDS-11031) Merge BaseApprover abstract class with the DefaultApprover
[ https://issues.apache.org/jira/browse/HDDS-11031?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Attila Doroszlai resolved HDDS-11031.
-------------------------------------
Fix Version/s: 1.5.0
Resolution: Done
> Merge BaseApprover abstract class with the DefaultApprover
> ----------------------------------------------------------
>
> Key: HDDS-11031
> URL: https://issues.apache.org/jira/browse/HDDS-11031
> Project: Apache Ozone
> Issue Type: Sub-task
> Reporter: István Fajth
> Assignee: István Fajth
> Priority: Major
> Fix For: 1.5.0
>
>
> Currently we have 3 types defined for approving Certificate Sign Requests:
> - CertificateApprover (the base interface)
> - BaseApprover (an abstract implementation)
> - DefaultApprover (the actual implementation)
> Separating an abstract class is speculative before we have more than one implementation, also scatters the code to different places without any meaningful gain coming from the fact that we have an abstract class.
> As part of this change, the goal is to merge the abstract class with the DefaultApprover, and then simplify and clean up the code, in a way that the CertificateApprover interface does not have any BouncyCastle dependencies, and all BouncyCastle dependencies are encapsulated within the DefaultApprover class as a first step.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org