[GitHub] [incubator-pinot] sunithabeeram commented on issue #4230: NULL value support for all data types

[GitBox <gi...@apache.org>]

sunithabeeram commented on issue #4230: NULL value support for all data types
URL: https://github.com/apache/incubator-pinot/issues/4230#issuecomment-496588574
 
 
   Few thoughts:
   - How would defaultValue and isNullable in the FieldSpec work? Does one take precedence over the other?
   - Although I like the idea of presence vector, would it be better to have it a bit more dynamic by allowing for a metadata field that says whether it indicates the presence or absence depending on the type of data? This is an interesting consideration from storage pov (as we can use whatever results in better storage representation), but would make execution a bit non-straight forward.
   - Do we want to generate the bit vector for metric fields?
   - Regarding the open question, if we don't allow on the fly generation, how would this work with older segments? I think interpreting existing default values to generate the bit vector sounds ok to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org