You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by "adoroszlai (via GitHub)" <gi...@apache.org> on 2024/11/19 09:37:59 UTC
[PR] HDDS-11729. Build fails with -DskipRecon [ozone]
adoroszlai opened a new pull request, #7454:
URL: https://github.com/apache/ozone/pull/7454
## What changes were proposed in this pull request?
`mvn -DskipRecon` removes Recon from the build:
https://github.com/apache/ozone/blob/dd22dbef8958311c2ec5e99822269405d59f8eba/hadoop-ozone/pom.xml#L399-L410}
But it fails due to unconditional dependencies in `ozone-tools` and `ozone-integration-test`.
```
[INFO] --------------------< org.apache.ozone:ozone-tools >--------------------
[INFO] Building Apache Ozone Tools 2.0.0-SNAPSHOT [34/45]
[INFO] --------------------------------[ jar ]---------------------------------
[WARNING] The POM for org.apache.ozone:ozone-recon:jar:2.0.0-SNAPSHOT is missing, no dependency information available
```
I propose to remove this profile. It was introduced for developers to speed up compilation when not working on Recon (HDDS-2316). We can achieve almost similar speedup by skipping just the frontend build. Replaced instruction in CONTRIBUTING.md for that.
Also updated build scripts, replacing `skip.installnpx` with `skip.installnodenpm`. The latter skips `install-node-and-npm` goal of `frontend-maven-plugin`:
https://github.com/eirslett/frontend-maven-plugin/blob/3f70757455b41c399baf742954a9285f93a0f774/frontend-maven-plugin/src/main/java/com/github/eirslett/maven/plugins/frontend/mojo/InstallNodeAndNpmMojo.java#L63-L67
which we use:
https://github.com/apache/ozone/blob/2cef3935e0de763b479f5e3a1c8f72d7393974e3/hadoop-ozone/recon/pom.xml#L141
while `skip.installnpx` does nothing with the current
https://issues.apache.org/jira/browse/HDDS-11729
## How was this patch tested?
Tested Maven options:
```
$ mvn -DskipTests -Dskip.installnodenpm -Dskip.npx clean package
...
[INFO] --- frontend-maven-plugin:1.15.1:install-node-and-npm (Install node and npm locally to the project) @ ozone-recon ---
[INFO] Skipping execution.
[INFO]
[INFO] --- frontend-maven-plugin:1.15.1:npx (set pnpm@8.15.7 store path) @ ozone-recon ---
[INFO] Skipping execution.
[INFO]
[INFO] --- frontend-maven-plugin:1.15.1:npx (install frontend dependencies) @ ozone-recon ---
[INFO] Skipping execution.
[INFO]
[INFO] --- frontend-maven-plugin:1.15.1:npx (Build frontend) @ ozone-recon ---
[INFO] Skipping execution.
```
CI (includes Recon tests):
https://github.com/adoroszlai/ozone/actions/runs/11908206758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11729. Update skipRecon profile to skip only frontend build [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai merged PR #7454:
URL: https://github.com/apache/ozone/pull/7454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11729. Update skipRecon profile to skip only frontend build [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7454:
URL: https://github.com/apache/ozone/pull/7454#issuecomment-2488039050
Thanks @errose28 for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11729. Update skipRecon profile to skip only frontend build [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7454:
URL: https://github.com/apache/ozone/pull/7454#issuecomment-2486360932
> My only comment is that the name `skipRecon` seems to imply that even Recon backend is skipped when this is not the case. Maybe something like `skipFrontend` or `skipReconFrontend` would be better.
The profile can also be enabled directly: `-Pskip-frontend`. (Note `-P` instead of `-D`.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
Re: [PR] HDDS-11729. Update skipRecon profile to skip only frontend build [ozone]
Posted by "adoroszlai (via GitHub)" <gi...@apache.org>.
adoroszlai commented on PR #7454:
URL: https://github.com/apache/ozone/pull/7454#issuecomment-2486302002
Update: keep `skipRecon` and let it set `skip.installnodenpm` and `skip.npx`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org