You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/27 03:53:33 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request, #18623: Remove useless findRuleConfigurations in ShardingSphereRuleMetaData

strongduanmu opened a new pull request, #18623:
URL: https://github.com/apache/shardingsphere/pull/18623

   Changes proposed in this pull request:
   - Remove useless findRuleConfigurations in ShardingSphereRuleMetaData
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tristaZero merged pull request #18623: Remove useless findRuleConfigurations in ShardingSphereRuleMetaData

Posted by GitBox <gi...@apache.org>.
tristaZero merged PR #18623:
URL: https://github.com/apache/shardingsphere/pull/18623


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #18623: Remove useless findRuleConfigurations in ShardingSphereRuleMetaData

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18623:
URL: https://github.com/apache/shardingsphere/pull/18623#issuecomment-1166838312

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18623?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#18623](https://codecov.io/gh/apache/shardingsphere/pull/18623?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c8ed209) into [master](https://codecov.io/gh/apache/shardingsphere/commit/53973fc6395a5add5ad8c4c3cdbf76494d9ee04e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (53973fc) will **increase** coverage by `0.00%`.
   > The diff coverage is `n/a`.
   
   > :exclamation: Current head c8ed209 differs from pull request most recent head 5f903b6. Consider uploading reports for the commit 5f903b6 to get more accurate results
   
   ```diff
   @@            Coverage Diff            @@
   ##             master   #18623   +/-   ##
   =========================================
     Coverage     59.36%   59.36%           
     Complexity     2257     2257           
   =========================================
     Files          3722     3722           
     Lines         54721    54715    -6     
     Branches       9316     9314    -2     
   =========================================
   - Hits          32487    32484    -3     
   + Misses        19491    19488    -3     
     Partials       2743     2743           
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18623?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...data/database/rule/ShardingSphereRuleMetaData.java](https://codecov.io/gh/apache/shardingsphere/pull/18623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9pbmZyYS9tZXRhZGF0YS9kYXRhYmFzZS9ydWxlL1NoYXJkaW5nU3BoZXJlUnVsZU1ldGFEYXRhLmphdmE=) | `73.33% <ø> (+20.95%)` | :arrow_up: |
   | [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/18623/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18623?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18623?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [53973fc...5f903b6](https://codecov.io/gh/apache/shardingsphere/pull/18623?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org