You are viewing a plain text version of this content. The canonical link for it is here.
Posted to scm@geronimo.apache.org by mc...@apache.org on 2009/07/29 22:18:33 UTC
svn commit: r799053 -
/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/src/main/java/org/apache/geronimo/st/core/GeronimoServerBehaviourDelegate.java
Author: mcconne
Date: Wed Jul 29 20:18:33 2009
New Revision: 799053
URL: http://svn.apache.org/viewvc?rev=799053&view=rev
Log:
GERONIMODEVTOOLS-575 Refine error message at the module level after deployment exception(s)
Modified:
geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/src/main/java/org/apache/geronimo/st/core/GeronimoServerBehaviourDelegate.java
Modified: geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/src/main/java/org/apache/geronimo/st/core/GeronimoServerBehaviourDelegate.java
URL: http://svn.apache.org/viewvc/geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/src/main/java/org/apache/geronimo/st/core/GeronimoServerBehaviourDelegate.java?rev=799053&r1=799052&r2=799053&view=diff
==============================================================================
--- geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/src/main/java/org/apache/geronimo/st/core/GeronimoServerBehaviourDelegate.java (original)
+++ geronimo/devtools/eclipse-plugin/trunk/plugins/org.apache.geronimo.st.core/src/main/java/org/apache/geronimo/st/core/GeronimoServerBehaviourDelegate.java Wed Jul 29 20:18:33 2009
@@ -304,6 +304,7 @@
_monitor = monitor;
+ setModuleStatus(module, null);
setModulePublishState(module, IServer.PUBLISH_STATE_NONE);
try {
//NO_CHANGE need if app is associated but not started and no delta
@@ -316,17 +317,16 @@
}
catch (CoreException e) {
//
- // Set the module publish state to UNKNOWN so that WTP will not display "Synchronized"
- // for the module and server. What we should see in the Eclipse Server View in this case
- // is nothing for the module, but "Republish" for the server. This is a very subtle
- // distinction but the only indication to the GEP end-user that their module was not
- // successfully deployed.
+ // Set the module publish state to UNKNOWN so that WTP will display "Republish" instead
+ // "Synchronized" for the server state, and set the module status to an error message
+ // for the GEP end-user to see.
//
+ setModuleStatus(module, new Status(IStatus.ERROR, Activator.PLUGIN_ID, "Error publishing module to server"));
setModulePublishState(module, IServer.PUBLISH_STATE_UNKNOWN);
throw e;
}
- Trace.tracePoint("Exit ", "GeronimoServerBehaviourDelegate.publishModule");
+ // Trace.tracePoint("Exit ", "GeronimoServerBehaviourDelegate.publishModule");
}
/*