You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tamaya.apache.org by pl...@apache.org on 2015/01/21 22:18:41 UTC
incubator-tamaya git commit: BooleanConverter returns now null if it
is not able to convert a property.
Repository: incubator-tamaya
Updated Branches:
refs/heads/master ebe237cb9 -> 3ca337ebe
BooleanConverter returns now null if it is not able to convert a property.
Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
Commit: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/3ca337eb
Tree: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/3ca337eb
Diff: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/3ca337eb
Branch: refs/heads/master
Commit: 3ca337ebe22b75d32332aac211efd3e418163af3
Parents: ebe237c
Author: Oliver B. Fischer <pl...@apache.org>
Authored: Wed Jan 21 22:17:41 2015 +0100
Committer: Oliver B. Fischer <pl...@apache.org>
Committed: Wed Jan 21 22:17:41 2015 +0100
----------------------------------------------------------------------
java8/core/pom.xml | 5 +++++
.../tamaya/core/internal/converters/BooleanConverter.java | 5 ++++-
pom.xml | 7 +++++++
3 files changed, 16 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/pom.xml
----------------------------------------------------------------------
diff --git a/java8/core/pom.xml b/java8/core/pom.xml
index 029b2ff..d9be79f 100644
--- a/java8/core/pom.xml
+++ b/java8/core/pom.xml
@@ -38,6 +38,11 @@ under the License.
</dependency>
<dependency>
+ <groupId>com.google.code.findbugs</groupId>
+ <artifactId>annotations</artifactId>
+ </dependency>
+
+ <dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
</dependency>
http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
----------------------------------------------------------------------
diff --git a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
index a9cb5ad..76fd4d7 100644
--- a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
+++ b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
@@ -20,6 +20,7 @@ package org.apache.tamaya.core.internal.converters;
import org.apache.tamaya.spi.PropertyConverter;
+import javax.annotation.CheckForNull;
import java.util.Locale;
import java.util.Objects;
import java.util.logging.Logger;
@@ -32,6 +33,7 @@ public class BooleanConverter implements PropertyConverter<Boolean> {
private Logger LOG = Logger.getLogger(getClass().getName());
@Override
+ @CheckForNull
public Boolean convert(String value) {
String ignoreCaseValue = Objects.requireNonNull(value)
.trim()
@@ -51,6 +53,7 @@ public class BooleanConverter implements PropertyConverter<Boolean> {
default:
LOG.warning("Unknown boolean value encountered: " + value);
}
- return Boolean.FALSE;
+
+ return null;
}
}
http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/pom.xml
----------------------------------------------------------------------
diff --git a/pom.xml b/pom.xml
index 8f1f46f..384bf2e 100644
--- a/pom.xml
+++ b/pom.xml
@@ -215,6 +215,13 @@ under the License.
<version>${junit.version}</version>
<scope>test</scope>
</dependency>
+
+ <dependency>
+ <groupId>com.google.code.findbugs</groupId>
+ <artifactId>annotations</artifactId>
+ <version>${findbugs.version}</version>
+ </dependency>
+
<dependency>
<groupId>org.hamcrest</groupId>
<artifactId>hamcrest-core</artifactId>
Re: incubator-tamaya git commit: BooleanConverter returns now null
if it is not able to convert a property.
Posted by Mark Struberg <st...@yahoo.de>.
Or to give you a better example:
If you use the LGPLed Hibernate jar as JPA provider at runtime and just use javax.persistence imports then you really are on the save side. If you implement Hibernate interfaces in your own code then you are fuuuuup and this code (and due to the virality also the rest of changes to this very project) also needs to be LGPL.
Many people are not aware of this legal consequence, but we at Apache do care a lot about such things. Because nobody of us likes to get sued, right?
LieGrue,
strub
> On Thursday, 22 January 2015, 12:20, Mark Struberg <st...@yahoo.de> wrote:
> >T hat is really a grey area and up to the lawyer.
>
> LGPL is only widely agreed to be non-viral if you have it as runtime linked
> library.For larger work and direct compile inclusion it is partly assumed to be
> viral.
>
> See our licensing matrix:
>
> http://www.apache.org/legal/resolved.html
>
>
> LieGrue,
> strub
>
>
>
> On Thursday, 22 January 2015, 12:10, Andres Almiray <aa...@gmail.com>
> wrote:
>
>
>>
>>
>> Hi Mark,
>>
>> Perhaps I'm too naive and misunderstood the implications, but I thought
> that LGPL was compatible with ASL2. GPL is the viral one.
>>
>> Anyhow, the jsr305 binary I'm referring to is published under ASL2 :-)
>> See
> https://repository.sonatype.org/service/local/repositories/atlassian/content/com/google/code/findbugs/jsr305/3.0.0/jsr305-3.0.0.pom
>>
>> Cheers,
>> Andres
>>
>>
>>
>>
>> -------------------------------------------
>> Java Champion; Groovy Enthusiast
>> http://jroller.com/aalmiray
>> http://www.linkedin.com/in/aalmiray
>> --
>> What goes up, must come down. Ask any system administrator.
>> There are 10 types of people in the world: Those who understand binary, and
> those who don't.
>> To understand recursion, we must first understand recursion.
>>
>> On Thu, Jan 22, 2015 at 12:03 PM, Mark Struberg <st...@yahoo.de>
> wrote:
>>
>> Hi Andres!
>>>
>>> The problem I have with this package is that it is LGPL. Thus we MUST
> NOT use it in ALv2 licensed code... This is a strict no-go!
>>>
>>>
>>> Is there a JSR-305 jar which has a better license? EPL, ALv2, MIT,
> BSD,...
>>>
>>> LieGrue,
>>> strub
>>>
>>>
>>>
>>>
>>>
>>>
>>>> On Thursday, 22 January 2015, 11:45, Andres Almiray
> <aa...@gmail.com> wrote:
>>>> > FWIW even if JSR305 is marked as dormant and never had an
> official release
>>>> facts are
>>>>
>>>> 1. there's a working binary release that can be used
>>>> 2. IntelliJ IDEA recognizes the annotations and gives you proper
> feedback.
>>>> Most likely NetBeans follows the same pattern. If using Eclipse
> then
>>>> consider switching to a better IDE ;-)
>>>>
>>>> My preferred artifact definition for the binaries is
>>>> "com.google.code.findbugs:jsr305:3.0.0" btw. We make
> extensive use of
>>>> these
>>>> annotations in the Griffon framework and its plugins.
>>>> Considering that Griffon may become the RI of JSR377 in the not so
> distant
>>>> future I think we may be able to "defibrillate" JSR305
> into action
>>>> *crosses
>>>> fingers*.
>>>>
>>>> Cheers,
>>>> Andres
>>>>
>>>> -------------------------------------------
>>>> Java Champion; Groovy Enthusiast
>>>> http://jroller.com/aalmiray
>>>> http://www.linkedin.com/in/aalmiray
>>>> --
>>>> What goes up, must come down. Ask any system administrator.
>>>> There are 10 types of people in the world: Those who understand
> binary, and
>>>> those who don't.
>>>> To understand recursion, we must first understand recursion.
>>>>
>>>>
>>>> On Thu, Jan 22, 2015 at 11:39 AM, Werner Keil
> <we...@gmail.com>
>>>> wrote:
>>>>
>>>>> If we do, then it at least puts Java SE 8 and Optional very
> much in
>>>>> question, the two try to scratch the same itch;-)
>>>>>
>>>>> You are right, there has been little activity putting life
> back into any of
>>>>> these annotations and despite the underlying compiler has some
> further
>>>>> annotation support now in SE 8 (JSR 308) nobody cares and
> nobody uses it,
>>>>> especially Oracle or others who could have used this
> JSR/annotation to
>>>>> facilitate 308. So far it's a "Compiler Zombie"
> barely ever
>>>> used outside a
>>>>> very small niche of "wacky academics";-)
>>>>>
>>>>> Werner
>>>>>
>>>>> On Thu, Jan 22, 2015 at 10:41 AM, Mark Struberg
> <st...@yahoo.de>
>>>> wrote:
>>>>>
>>>>> > I don't understand why we need
> javax.annotation.CheckForNull?
>>>>> >
>>>>> > This JSR is dormant and not widely adopted. It didn't
> even get
>>>> officially
>>>>> > released, right?
>>>>> >
>>>>> > LieGrue,
>>>>> > strub
>>>>> >
>>>>> >
>>>>> >
>>>>> >
>>>>> > > On Wednesday, 21 January 2015, 22:19,
>>>> "plexus@apache.org" <
>>>>> > plexus@apache.org> wrote:
>>>>> > > > Repository: incubator-tamaya
>>>>> > > Updated Branches:
>>>>> > > refs/heads/master ebe237cb9 -> 3ca337ebe
>>>>> > >
>>>>> > >
>>>>> > > BooleanConverter returns now null if it is not able
> to convert a
>>>>> > property.
>>>>> > >
>>>>> > >
>>>>> > > Project:
>>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
>>>>> > > Commit:
>>>>> >
>>>>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/3ca337eb
>>>>> > > Tree:
>>>>> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/3ca337eb
>>>>> > > Diff:
>>>>> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/3ca337eb
>>>>> > >
>>>>> > > Branch: refs/heads/master
>>>>> > > Commit: 3ca337ebe22b75d32332aac211efd3e418163af3
>>>>> > > Parents: ebe237c
>>>>> > > Author: Oliver B. Fischer <pl...@apache.org>
>>>>> > > Authored: Wed Jan 21 22:17:41 2015 +0100
>>>>> > > Committer: Oliver B. Fischer
> <pl...@apache.org>
>>>>> > > Committed: Wed Jan 21 22:17:41 2015 +0100
>>>>> > >
>>>>> > >
>>>>
> ----------------------------------------------------------------------
>>>>> > > java8/core/pom.xml
> | 5
>>>> +++++
>>>>> > >
> .../tamaya/core/internal/converters/BooleanConverter.java | 5
>>>> ++++-
>>>>> > > pom.xml
> | 7
>>>>> +++++++
>>>>> > > 3 files changed, 16 insertions(+), 1 deletion(-)
>>>>> > >
>>>>
> ----------------------------------------------------------------------
>>>>> > >
>>>>> > >
>>>>> > >
>>>>> >
>>>>>
>>>>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/pom.xml
>>>>> > >
>>>>
> ----------------------------------------------------------------------
>>>>> > > diff --git a/java8/core/pom.xml b/java8/core/pom.xml
>>>>> > > index 029b2ff..d9be79f 100644
>>>>> > > --- a/java8/core/pom.xml
>>>>> > > +++ b/java8/core/pom.xml
>>>>> > > @@ -38,6 +38,11 @@ under the License.
>>>>> > > </dependency>
>>>>> > >
>>>>> > > <dependency>
>>>>> > > +
>>>> <groupId>com.google.code.findbugs</groupId>
>>>>> > > +
> <artifactId>annotations</artifactId>
>>>>> > > + </dependency>
>>>>> > > +
>>>>> > > + <dependency>
>>>>> > > <groupId>junit</groupId>
>>>>> > >
> <artifactId>junit</artifactId>
>>>>> > > </dependency>
>>>>> > >
>>>>> > >
>>>>> >
>>>>>
>>>>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>>> > >
>>>>
> ----------------------------------------------------------------------
>>>>> > > diff --git
>>>>> > >
>>>>> >
>>>>>
>>>>
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>>> > >
>>>>> >
>>>>>
>>>>
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>>> > > index a9cb5ad..76fd4d7 100644
>>>>> > > ---
>>>>> > >
>>>>> >
>>>>>
>>>>
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>>> > > +++
>>>>> > >
>>>>> >
>>>>>
>>>>
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>>> > > @@ -20,6 +20,7 @@ package
>>>> org.apache.tamaya.core.internal.converters;
>>>>> > >
>>>>> > > import org.apache.tamaya.spi.PropertyConverter;
>>>>> > >
>>>>> > > +import javax.annotation.CheckForNull;
>>>>> > > import java.util.Locale;
>>>>> > > import java.util.Objects;
>>>>> > > import java.util.logging.Logger;
>>>>> > > @@ -32,6 +33,7 @@ public class BooleanConverter
> implements
>>>>> > > PropertyConverter<Boolean> {
>>>>> > > private Logger LOG =
> Logger.getLogger(getClass().getName());
>>>>> > >
>>>>> > > @Override
>>>>> > > + @CheckForNull
>>>>> > > public Boolean convert(String value) {
>>>>> > > String ignoreCaseValue =
> Objects.requireNonNull(value)
>>>>> > > .trim()
>>>>> > > @@ -51,6 +53,7 @@ public class BooleanConverter
> implements
>>>>> > > PropertyConverter<Boolean> {
>>>>> > > default:
>>>>> > > LOG.warning("Unknown boolean
> value
>>>> encountered: " +
>>>>> > > value);
>>>>> > > }
>>>>> > > - return Boolean.FALSE;
>>>>> > > +
>>>>> > > + return null;
>>>>> > > }
>>>>> > > }
>>>>> > >
>>>>> > >
>>>>> >
>>>>>
>>>>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/pom.xml
>>>>> > >
>>>>
> ----------------------------------------------------------------------
>>>>> > > diff --git a/pom.xml b/pom.xml
>>>>> > > index 8f1f46f..384bf2e 100644
>>>>> > > --- a/pom.xml
>>>>> > > +++ b/pom.xml
>>>>> > > @@ -215,6 +215,13 @@ under the License.
>>>>> > >
>>>> <version>${junit.version}</version>
>>>>> > > <scope>test</scope>
>>>>> > > </dependency>
>>>>> > > +
>>>>> > > + <dependency>
>>>>> > > +
>>>> <groupId>com.google.code.findbugs</groupId>
>>>>> > > +
> <artifactId>annotations</artifactId>
>>>>> > > +
>>>> <version>${findbugs.version}</version>
>>>>> > > + </dependency>
>>>>> > > +
>>>>> > > <dependency>
>>>>> > >
> <groupId>org.hamcrest</groupId>
>>>>> > >
>>>> <artifactId>hamcrest-core</artifactId>
>>>>> > >
>>>>> >
>>>>>
>>>>
>>>
>>
>>
>>
>
Re: incubator-tamaya git commit: BooleanConverter returns now null if
it is not able to convert a property.
Posted by Anatole Tresch <at...@gmail.com>.
But the annotations are part of the code, so no-go still. They should be
removed...
2015-01-22 20:48 GMT+01:00 Reinhard Sandtner <re...@gmail.com>:
> the dependency is compile scoped so if i use tamaya i’ll get this dep to -
> for me, this is an absolute no-go
>
> if we really want to have these checks, we should add the dependency with
> optional
> findbugs-maven-plugin has a dependency to the annotations too so it should
> work
>
> lg
> reini
>
>
> > Am 22.01.2015 um 20:30 schrieb Mark Struberg <st...@yahoo.de>:
> >
> > +1 for removing. Our core is really that small that we should not need
> it. And with Java8 this JSR is not only dormant but really obsolete.
> >
> > LieGrue,
> > strub
> >
> >
> >
> >
> >
> >> On Thursday, 22 January 2015, 20:28, Anatole Tresch <at...@gmail.com>
> wrote:
> >>> If you ask me, I am against adding an additional dependency for tool
> >> support. I would to remove these annotations and the dep completely.
> Other
> >> opinions? Am I the only one?
> >>
> >>
> >> 2015-01-22 20:25 GMT+01:00 Oliver B. Fischer <o.b.fischer@swe-blog.net
> >:
> >>
> >>> Hi Reinhard,
> >>>
> >>> FindBugs and similar tools can use these annotations not only to
> suppress
> >>> errors. They use it even for flow analysis.
> >>>
> >>> For example @CheckForNull allows FindBugs do detect what a caller of
> this
> >>> method does not perform a null check and might end in an NPE. Therefor
> >>> these annotations are very usefull for us to improve the quality of our
> >>> code base. Even the users of Tamaya will benefit from it if they also
> use
> >>> FindBugs.
> >>>
> >>>
> >>> Oliver
> >>>
> >>>
> >>> Am 22.01.15 um 12:25 schrieb Reinhard Sandtner:
> >>>
> >>>> whats the benefit of this lib?
> >>>>
> >>>> is it only for findbugs?
> >>>> we use a filter file - i think its better to have all our exclusions
> in
> >>>> the filter file with comments why it is excluded. so all are in one
> >> place
> >>>> and its very easy to find
> >>>>
> >>>> lg
> >>>> reini
> >>>>
> >>>>
> >>>> Am 22.01.2015 um 12:17 schrieb Mark Struberg
> >> <st...@yahoo.de>:
> >>>>>
> >>>>> That is really a grey area and up to the lawyer.
> >>>>>
> >>>>> LGPL is only widely agreed to be non-viral if you have it as
> >> runtime
> >>>>> linked library.For larger work and direct compile inclusion it is
> >> partly
> >>>>> assumed to be viral.
> >>>>>
> >>>>> See our licensing matrix:
> >>>>>
> >>>>> http://www.apache.org/legal/resolved.html
> >>>>>
> >>>>>
> >>>>> LieGrue,
> >>>>> strub
> >>>>>
> >>>>>
> >>>>> On Thursday, 22 January 2015, 12:10, Andres Almiray
> >> <aa...@gmail.com>
> >>>>> wrote:
> >>>>>
> >>>>>
> >>>>>
> >>> --
> >>> N Oliver B. Fischer
> >>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> >>> P +49 30 44793251
> >>> M +49 178 7903538
> >>> E o.b.fischer@swe-blog.net
> >>> S oliver.b.fischer
> >>> J oliver.b.fischer@jabber.org
> >>> X http://xing.to/obf
> >>>
> >>>
> >>
> >>
> >> --
> >> *Anatole Tresch*
> >> Java Engineer & Architect, JSR Spec Lead
> >> Glärnischweg 10
> >> CH - 8620 Wetzikon
> >>
> >> *Switzerland, Europe Zurich, GMT+1*
> >> *Twitter: @atsticks*
> >> *Blogs: **http://javaremarkables.blogspot.ch/
> >> <http://javaremarkables.blogspot.ch/>*
> >>
> >> *Google: atsticksMobile +41-76 344 62 79*
> >>
>
>
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79*
Re: incubator-tamaya git commit: BooleanConverter returns now null if it is not able to convert a property.
Posted by Reinhard Sandtner <re...@gmail.com>.
the dependency is compile scoped so if i use tamaya i’ll get this dep to - for me, this is an absolute no-go
if we really want to have these checks, we should add the dependency with optional
findbugs-maven-plugin has a dependency to the annotations too so it should work
lg
reini
> Am 22.01.2015 um 20:30 schrieb Mark Struberg <st...@yahoo.de>:
>
> +1 for removing. Our core is really that small that we should not need it. And with Java8 this JSR is not only dormant but really obsolete.
>
> LieGrue,
> strub
>
>
>
>
>
>> On Thursday, 22 January 2015, 20:28, Anatole Tresch <at...@gmail.com> wrote:
>>> If you ask me, I am against adding an additional dependency for tool
>> support. I would to remove these annotations and the dep completely. Other
>> opinions? Am I the only one?
>>
>>
>> 2015-01-22 20:25 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>>
>>> Hi Reinhard,
>>>
>>> FindBugs and similar tools can use these annotations not only to suppress
>>> errors. They use it even for flow analysis.
>>>
>>> For example @CheckForNull allows FindBugs do detect what a caller of this
>>> method does not perform a null check and might end in an NPE. Therefor
>>> these annotations are very usefull for us to improve the quality of our
>>> code base. Even the users of Tamaya will benefit from it if they also use
>>> FindBugs.
>>>
>>>
>>> Oliver
>>>
>>>
>>> Am 22.01.15 um 12:25 schrieb Reinhard Sandtner:
>>>
>>>> whats the benefit of this lib?
>>>>
>>>> is it only for findbugs?
>>>> we use a filter file - i think its better to have all our exclusions in
>>>> the filter file with comments why it is excluded. so all are in one
>> place
>>>> and its very easy to find
>>>>
>>>> lg
>>>> reini
>>>>
>>>>
>>>> Am 22.01.2015 um 12:17 schrieb Mark Struberg
>> <st...@yahoo.de>:
>>>>>
>>>>> That is really a grey area and up to the lawyer.
>>>>>
>>>>> LGPL is only widely agreed to be non-viral if you have it as
>> runtime
>>>>> linked library.For larger work and direct compile inclusion it is
>> partly
>>>>> assumed to be viral.
>>>>>
>>>>> See our licensing matrix:
>>>>>
>>>>> http://www.apache.org/legal/resolved.html
>>>>>
>>>>>
>>>>> LieGrue,
>>>>> strub
>>>>>
>>>>>
>>>>> On Thursday, 22 January 2015, 12:10, Andres Almiray
>> <aa...@gmail.com>
>>>>> wrote:
>>>>>
>>>>>
>>>>>
>>> --
>>> N Oliver B. Fischer
>>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>>> P +49 30 44793251
>>> M +49 178 7903538
>>> E o.b.fischer@swe-blog.net
>>> S oliver.b.fischer
>>> J oliver.b.fischer@jabber.org
>>> X http://xing.to/obf
>>>
>>>
>>
>>
>> --
>> *Anatole Tresch*
>> Java Engineer & Architect, JSR Spec Lead
>> Glärnischweg 10
>> CH - 8620 Wetzikon
>>
>> *Switzerland, Europe Zurich, GMT+1*
>> *Twitter: @atsticks*
>> *Blogs: **http://javaremarkables.blogspot.ch/
>> <http://javaremarkables.blogspot.ch/>*
>>
>> *Google: atsticksMobile +41-76 344 62 79*
>>
Re: incubator-tamaya git commit: BooleanConverter returns now null
if it is not able to convert a property.
Posted by Mark Struberg <st...@yahoo.de>.
+1 for removing. Our core is really that small that we should not need it. And with Java8 this JSR is not only dormant but really obsolete.
LieGrue,
strub
> On Thursday, 22 January 2015, 20:28, Anatole Tresch <at...@gmail.com> wrote:
> > If you ask me, I am against adding an additional dependency for tool
> support. I would to remove these annotations and the dep completely. Other
> opinions? Am I the only one?
>
>
> 2015-01-22 20:25 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
>
>> Hi Reinhard,
>>
>> FindBugs and similar tools can use these annotations not only to suppress
>> errors. They use it even for flow analysis.
>>
>> For example @CheckForNull allows FindBugs do detect what a caller of this
>> method does not perform a null check and might end in an NPE. Therefor
>> these annotations are very usefull for us to improve the quality of our
>> code base. Even the users of Tamaya will benefit from it if they also use
>> FindBugs.
>>
>>
>> Oliver
>>
>>
>> Am 22.01.15 um 12:25 schrieb Reinhard Sandtner:
>>
>>> whats the benefit of this lib?
>>>
>>> is it only for findbugs?
>>> we use a filter file - i think its better to have all our exclusions in
>>> the filter file with comments why it is excluded. so all are in one
> place
>>> and its very easy to find
>>>
>>> lg
>>> reini
>>>
>>>
>>> Am 22.01.2015 um 12:17 schrieb Mark Struberg
> <st...@yahoo.de>:
>>>>
>>>> That is really a grey area and up to the lawyer.
>>>>
>>>> LGPL is only widely agreed to be non-viral if you have it as
> runtime
>>>> linked library.For larger work and direct compile inclusion it is
> partly
>>>> assumed to be viral.
>>>>
>>>> See our licensing matrix:
>>>>
>>>> http://www.apache.org/legal/resolved.html
>>>>
>>>>
>>>> LieGrue,
>>>> strub
>>>>
>>>>
>>>> On Thursday, 22 January 2015, 12:10, Andres Almiray
> <aa...@gmail.com>
>>>> wrote:
>>>>
>>>>
>>>>
>> --
>> N Oliver B. Fischer
>> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
>> P +49 30 44793251
>> M +49 178 7903538
>> E o.b.fischer@swe-blog.net
>> S oliver.b.fischer
>> J oliver.b.fischer@jabber.org
>> X http://xing.to/obf
>>
>>
>
>
> --
> *Anatole Tresch*
> Java Engineer & Architect, JSR Spec Lead
> Glärnischweg 10
> CH - 8620 Wetzikon
>
> *Switzerland, Europe Zurich, GMT+1*
> *Twitter: @atsticks*
> *Blogs: **http://javaremarkables.blogspot.ch/
> <http://javaremarkables.blogspot.ch/>*
>
> *Google: atsticksMobile +41-76 344 62 79*
>
Re: incubator-tamaya git commit: BooleanConverter returns now null if
it is not able to convert a property.
Posted by Anatole Tresch <at...@gmail.com>.
If you ask me, I am against adding an additional dependency for tool
support. I would to remove these annotations and the dep completely. Other
opinions? Am I the only one?
2015-01-22 20:25 GMT+01:00 Oliver B. Fischer <o....@swe-blog.net>:
> Hi Reinhard,
>
> FindBugs and similar tools can use these annotations not only to suppress
> errors. They use it even for flow analysis.
>
> For example @CheckForNull allows FindBugs do detect what a caller of this
> method does not perform a null check and might end in an NPE. Therefor
> these annotations are very usefull for us to improve the quality of our
> code base. Even the users of Tamaya will benefit from it if they also use
> FindBugs.
>
>
> Oliver
>
>
> Am 22.01.15 um 12:25 schrieb Reinhard Sandtner:
>
>> whats the benefit of this lib?
>>
>> is it only for findbugs?
>> we use a filter file - i think its better to have all our exclusions in
>> the filter file with comments why it is excluded. so all are in one place
>> and its very easy to find
>>
>> lg
>> reini
>>
>>
>> Am 22.01.2015 um 12:17 schrieb Mark Struberg <st...@yahoo.de>:
>>>
>>> That is really a grey area and up to the lawyer.
>>>
>>> LGPL is only widely agreed to be non-viral if you have it as runtime
>>> linked library.For larger work and direct compile inclusion it is partly
>>> assumed to be viral.
>>>
>>> See our licensing matrix:
>>>
>>> http://www.apache.org/legal/resolved.html
>>>
>>>
>>> LieGrue,
>>> strub
>>>
>>>
>>> On Thursday, 22 January 2015, 12:10, Andres Almiray <aa...@gmail.com>
>>> wrote:
>>>
>>>
>>>
> --
> N Oliver B. Fischer
> A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
> P +49 30 44793251
> M +49 178 7903538
> E o.b.fischer@swe-blog.net
> S oliver.b.fischer
> J oliver.b.fischer@jabber.org
> X http://xing.to/obf
>
>
--
*Anatole Tresch*
Java Engineer & Architect, JSR Spec Lead
Glärnischweg 10
CH - 8620 Wetzikon
*Switzerland, Europe Zurich, GMT+1*
*Twitter: @atsticks*
*Blogs: **http://javaremarkables.blogspot.ch/
<http://javaremarkables.blogspot.ch/>*
*Google: atsticksMobile +41-76 344 62 79*
Re: incubator-tamaya git commit: BooleanConverter returns now null
if it is not able to convert a property.
Posted by "Oliver B. Fischer" <o....@swe-blog.net>.
Hi Reinhard,
FindBugs and similar tools can use these annotations not only to
suppress errors. They use it even for flow analysis.
For example @CheckForNull allows FindBugs do detect what a caller of
this method does not perform a null check and might end in an NPE.
Therefor these annotations are very usefull for us to improve the
quality of our code base. Even the users of Tamaya will benefit from it
if they also use FindBugs.
Oliver
Am 22.01.15 um 12:25 schrieb Reinhard Sandtner:
> whats the benefit of this lib?
>
> is it only for findbugs?
> we use a filter file - i think its better to have all our exclusions in the filter file with comments why it is excluded. so all are in one place and its very easy to find
>
> lg
> reini
>
>
>> Am 22.01.2015 um 12:17 schrieb Mark Struberg <st...@yahoo.de>:
>>
>> That is really a grey area and up to the lawyer.
>>
>> LGPL is only widely agreed to be non-viral if you have it as runtime linked library.For larger work and direct compile inclusion it is partly assumed to be viral.
>>
>> See our licensing matrix:
>>
>> http://www.apache.org/legal/resolved.html
>>
>>
>> LieGrue,
>> strub
>>
>>
>> On Thursday, 22 January 2015, 12:10, Andres Almiray <aa...@gmail.com> wrote:
>>
>>
--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fischer@swe-blog.net
S oliver.b.fischer
J oliver.b.fischer@jabber.org
X http://xing.to/obf
Re: incubator-tamaya git commit: BooleanConverter returns now null if it is not able to convert a property.
Posted by Reinhard Sandtner <re...@gmail.com>.
whats the benefit of this lib?
is it only for findbugs?
we use a filter file - i think its better to have all our exclusions in the filter file with comments why it is excluded. so all are in one place and its very easy to find
lg
reini
> Am 22.01.2015 um 12:17 schrieb Mark Struberg <st...@yahoo.de>:
>
> That is really a grey area and up to the lawyer.
>
> LGPL is only widely agreed to be non-viral if you have it as runtime linked library.For larger work and direct compile inclusion it is partly assumed to be viral.
>
> See our licensing matrix:
>
> http://www.apache.org/legal/resolved.html
>
>
> LieGrue,
> strub
>
>
> On Thursday, 22 January 2015, 12:10, Andres Almiray <aa...@gmail.com> wrote:
>
>
>>
>>
>> Hi Mark,
>>
>> Perhaps I'm too naive and misunderstood the implications, but I thought that LGPL was compatible with ASL2. GPL is the viral one.
>>
>> Anyhow, the jsr305 binary I'm referring to is published under ASL2 :-)
>> See https://repository.sonatype.org/service/local/repositories/atlassian/content/com/google/code/findbugs/jsr305/3.0.0/jsr305-3.0.0.pom
>>
>> Cheers,
>> Andres
>>
>>
>>
>>
>> -------------------------------------------
>> Java Champion; Groovy Enthusiast
>> http://jroller.com/aalmiray
>> http://www.linkedin.com/in/aalmiray
>> --
>> What goes up, must come down. Ask any system administrator.
>> There are 10 types of people in the world: Those who understand binary, and those who don't.
>> To understand recursion, we must first understand recursion.
>>
>> On Thu, Jan 22, 2015 at 12:03 PM, Mark Struberg <st...@yahoo.de> wrote:
>>
>> Hi Andres!
>>>
>>> The problem I have with this package is that it is LGPL. Thus we MUST NOT use it in ALv2 licensed code... This is a strict no-go!
>>>
>>>
>>> Is there a JSR-305 jar which has a better license? EPL, ALv2, MIT, BSD,...
>>>
>>> LieGrue,
>>> strub
>>>
>>>
>>>
>>>
>>>
>>>
>>>> On Thursday, 22 January 2015, 11:45, Andres Almiray <aa...@gmail.com> wrote:
>>>>> FWIW even if JSR305 is marked as dormant and never had an official release
>>>> facts are
>>>>
>>>> 1. there's a working binary release that can be used
>>>> 2. IntelliJ IDEA recognizes the annotations and gives you proper feedback.
>>>> Most likely NetBeans follows the same pattern. If using Eclipse then
>>>> consider switching to a better IDE ;-)
>>>>
>>>> My preferred artifact definition for the binaries is
>>>> "com.google.code.findbugs:jsr305:3.0.0" btw. We make extensive use of
>>>> these
>>>> annotations in the Griffon framework and its plugins.
>>>> Considering that Griffon may become the RI of JSR377 in the not so distant
>>>> future I think we may be able to "defibrillate" JSR305 into action
>>>> *crosses
>>>> fingers*.
>>>>
>>>> Cheers,
>>>> Andres
>>>>
>>>> -------------------------------------------
>>>> Java Champion; Groovy Enthusiast
>>>> http://jroller.com/aalmiray
>>>> http://www.linkedin.com/in/aalmiray
>>>> --
>>>> What goes up, must come down. Ask any system administrator.
>>>> There are 10 types of people in the world: Those who understand binary, and
>>>> those who don't.
>>>> To understand recursion, we must first understand recursion.
>>>>
>>>>
>>>> On Thu, Jan 22, 2015 at 11:39 AM, Werner Keil <we...@gmail.com>
>>>> wrote:
>>>>
>>>>> If we do, then it at least puts Java SE 8 and Optional very much in
>>>>> question, the two try to scratch the same itch;-)
>>>>>
>>>>> You are right, there has been little activity putting life back into any of
>>>>> these annotations and despite the underlying compiler has some further
>>>>> annotation support now in SE 8 (JSR 308) nobody cares and nobody uses it,
>>>>> especially Oracle or others who could have used this JSR/annotation to
>>>>> facilitate 308. So far it's a "Compiler Zombie" barely ever
>>>> used outside a
>>>>> very small niche of "wacky academics";-)
>>>>>
>>>>> Werner
>>>>>
>>>>> On Thu, Jan 22, 2015 at 10:41 AM, Mark Struberg <st...@yahoo.de>
>>>> wrote:
>>>>>
>>>>>> I don't understand why we need javax.annotation.CheckForNull?
>>>>>>
>>>>>> This JSR is dormant and not widely adopted. It didn't even get
>>>> officially
>>>>>> released, right?
>>>>>>
>>>>>> LieGrue,
>>>>>> strub
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> On Wednesday, 21 January 2015, 22:19,
>>>> "plexus@apache.org" <
>>>>>> plexus@apache.org> wrote:
>>>>>>>> Repository: incubator-tamaya
>>>>>>> Updated Branches:
>>>>>>> refs/heads/master ebe237cb9 -> 3ca337ebe
>>>>>>>
>>>>>>>
>>>>>>> BooleanConverter returns now null if it is not able to convert a
>>>>>> property.
>>>>>>>
>>>>>>>
>>>>>>> Project:
>>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
>>>>>>> Commit:
>>>>>>
>>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/3ca337eb
>>>>>>> Tree:
>>>>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/3ca337eb
>>>>>>> Diff:
>>>>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/3ca337eb
>>>>>>>
>>>>>>> Branch: refs/heads/master
>>>>>>> Commit: 3ca337ebe22b75d32332aac211efd3e418163af3
>>>>>>> Parents: ebe237c
>>>>>>> Author: Oliver B. Fischer <pl...@apache.org>
>>>>>>> Authored: Wed Jan 21 22:17:41 2015 +0100
>>>>>>> Committer: Oliver B. Fischer <pl...@apache.org>
>>>>>>> Committed: Wed Jan 21 22:17:41 2015 +0100
>>>>>>>
>>>>>>>
>>>> ----------------------------------------------------------------------
>>>>>>> java8/core/pom.xml | 5
>>>> +++++
>>>>>>> .../tamaya/core/internal/converters/BooleanConverter.java | 5
>>>> ++++-
>>>>>>> pom.xml | 7
>>>>> +++++++
>>>>>>> 3 files changed, 16 insertions(+), 1 deletion(-)
>>>>>>>
>>>> ----------------------------------------------------------------------
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/pom.xml
>>>>>>>
>>>> ----------------------------------------------------------------------
>>>>>>> diff --git a/java8/core/pom.xml b/java8/core/pom.xml
>>>>>>> index 029b2ff..d9be79f 100644
>>>>>>> --- a/java8/core/pom.xml
>>>>>>> +++ b/java8/core/pom.xml
>>>>>>> @@ -38,6 +38,11 @@ under the License.
>>>>>>> </dependency>
>>>>>>>
>>>>>>> <dependency>
>>>>>>> +
>>>> <groupId>com.google.code.findbugs</groupId>
>>>>>>> + <artifactId>annotations</artifactId>
>>>>>>> + </dependency>
>>>>>>> +
>>>>>>> + <dependency>
>>>>>>> <groupId>junit</groupId>
>>>>>>> <artifactId>junit</artifactId>
>>>>>>> </dependency>
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>>>>>
>>>> ----------------------------------------------------------------------
>>>>>>> diff --git
>>>>>>>
>>>>>>
>>>>>
>>>> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>>>>>
>>>>>>
>>>>>
>>>> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>>>>> index a9cb5ad..76fd4d7 100644
>>>>>>> ---
>>>>>>>
>>>>>>
>>>>>
>>>> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>>>>> +++
>>>>>>>
>>>>>>
>>>>>
>>>> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>>>>> @@ -20,6 +20,7 @@ package
>>>> org.apache.tamaya.core.internal.converters;
>>>>>>>
>>>>>>> import org.apache.tamaya.spi.PropertyConverter;
>>>>>>>
>>>>>>> +import javax.annotation.CheckForNull;
>>>>>>> import java.util.Locale;
>>>>>>> import java.util.Objects;
>>>>>>> import java.util.logging.Logger;
>>>>>>> @@ -32,6 +33,7 @@ public class BooleanConverter implements
>>>>>>> PropertyConverter<Boolean> {
>>>>>>> private Logger LOG = Logger.getLogger(getClass().getName());
>>>>>>>
>>>>>>> @Override
>>>>>>> + @CheckForNull
>>>>>>> public Boolean convert(String value) {
>>>>>>> String ignoreCaseValue = Objects.requireNonNull(value)
>>>>>>> .trim()
>>>>>>> @@ -51,6 +53,7 @@ public class BooleanConverter implements
>>>>>>> PropertyConverter<Boolean> {
>>>>>>> default:
>>>>>>> LOG.warning("Unknown boolean value
>>>> encountered: " +
>>>>>>> value);
>>>>>>> }
>>>>>>> - return Boolean.FALSE;
>>>>>>> +
>>>>>>> + return null;
>>>>>>> }
>>>>>>> }
>>>>>>>
>>>>>>>
>>>>>>
>>>>>
>>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/pom.xml
>>>>>>>
>>>> ----------------------------------------------------------------------
>>>>>>> diff --git a/pom.xml b/pom.xml
>>>>>>> index 8f1f46f..384bf2e 100644
>>>>>>> --- a/pom.xml
>>>>>>> +++ b/pom.xml
>>>>>>> @@ -215,6 +215,13 @@ under the License.
>>>>>>>
>>>> <version>${junit.version}</version>
>>>>>>> <scope>test</scope>
>>>>>>> </dependency>
>>>>>>> +
>>>>>>> + <dependency>
>>>>>>> +
>>>> <groupId>com.google.code.findbugs</groupId>
>>>>>>> + <artifactId>annotations</artifactId>
>>>>>>> +
>>>> <version>${findbugs.version}</version>
>>>>>>> + </dependency>
>>>>>>> +
>>>>>>> <dependency>
>>>>>>> <groupId>org.hamcrest</groupId>
>>>>>>>
>>>> <artifactId>hamcrest-core</artifactId>
>>>>>>>
>>>>>>
>>>>>
>>>>
>>>
>>
>>
>>
Re: incubator-tamaya git commit: BooleanConverter returns now null if
it is not able to convert a property.
Posted by Werner Keil <we...@gmail.com>.
Well I know even in the JCP EC nobody cares about the API any more, it's a
"black hole" between the written document "Spec" and the RI/TCK, so from
JSR to JSR some interpret it as a manifestation of the Spec, hence the JCP
Spec License applies to "javax.annotation" even if they did not explicitly
mention it.
Those are just a bunch of annotations anyway and the dormant JSR failed to
produce a RI or TCK so far.
However, since the only "standard implementations" look like e.g. the
FindBugs project http://findbugs.sourceforge.net/ that clearly states it's
under LGPL, so in the absence of a true RI for this unfinished JSR that
seems the case.
Werner
On Thu, Jan 22, 2015 at 12:17 PM, Mark Struberg <st...@yahoo.de> wrote:
> That is really a grey area and up to the lawyer.
>
> LGPL is only widely agreed to be non-viral if you have it as runtime
> linked library.For larger work and direct compile inclusion it is partly
> assumed to be viral.
>
> See our licensing matrix:
>
> http://www.apache.org/legal/resolved.html
>
>
> LieGrue,
> strub
>
>
> On Thursday, 22 January 2015, 12:10, Andres Almiray <aa...@gmail.com>
> wrote:
>
>
> >
> >
> >Hi Mark,
> >
> >Perhaps I'm too naive and misunderstood the implications, but I thought
> that LGPL was compatible with ASL2. GPL is the viral one.
> >
> >Anyhow, the jsr305 binary I'm referring to is published under ASL2 :-)
> >See
> https://repository.sonatype.org/service/local/repositories/atlassian/content/com/google/code/findbugs/jsr305/3.0.0/jsr305-3.0.0.pom
> >
> >Cheers,
> >Andres
> >
> >
> >
> >
> >-------------------------------------------
> >Java Champion; Groovy Enthusiast
> >http://jroller.com/aalmiray
> >http://www.linkedin.com/in/aalmiray
> >--
> >What goes up, must come down. Ask any system administrator.
> >There are 10 types of people in the world: Those who understand binary,
> and those who don't.
> >To understand recursion, we must first understand recursion.
> >
> >On Thu, Jan 22, 2015 at 12:03 PM, Mark Struberg <st...@yahoo.de>
> wrote:
> >
> >Hi Andres!
> >>
> >>The problem I have with this package is that it is LGPL. Thus we MUST
> NOT use it in ALv2 licensed code... This is a strict no-go!
> >>
> >>
> >>Is there a JSR-305 jar which has a better license? EPL, ALv2, MIT,
> BSD,...
> >>
> >>LieGrue,
> >>strub
> >>
> >>
> >>
> >>
> >>
> >>
> >>> On Thursday, 22 January 2015, 11:45, Andres Almiray <
> aalmiray@gmail.com> wrote:
> >>> > FWIW even if JSR305 is marked as dormant and never had an official
> release
> >>> facts are
> >>>
> >>> 1. there's a working binary release that can be used
> >>> 2. IntelliJ IDEA recognizes the annotations and gives you proper
> feedback.
> >>> Most likely NetBeans follows the same pattern. If using Eclipse then
> >>> consider switching to a better IDE ;-)
> >>>
> >>> My preferred artifact definition for the binaries is
> >>> "com.google.code.findbugs:jsr305:3.0.0" btw. We make extensive use of
> >>> these
> >>> annotations in the Griffon framework and its plugins.
> >>> Considering that Griffon may become the RI of JSR377 in the not so
> distant
> >>> future I think we may be able to "defibrillate" JSR305 into action
> >>> *crosses
> >>> fingers*.
> >>>
> >>> Cheers,
> >>> Andres
> >>>
> >>> -------------------------------------------
> >>> Java Champion; Groovy Enthusiast
> >>> http://jroller.com/aalmiray
> >>> http://www.linkedin.com/in/aalmiray
> >>> --
> >>> What goes up, must come down. Ask any system administrator.
> >>> There are 10 types of people in the world: Those who understand
> binary, and
> >>> those who don't.
> >>> To understand recursion, we must first understand recursion.
> >>>
> >>>
> >>> On Thu, Jan 22, 2015 at 11:39 AM, Werner Keil <we...@gmail.com>
> >>> wrote:
> >>>
> >>>> If we do, then it at least puts Java SE 8 and Optional very much in
> >>>> question, the two try to scratch the same itch;-)
> >>>>
> >>>> You are right, there has been little activity putting life back into
> any of
> >>>> these annotations and despite the underlying compiler has some
> further
> >>>> annotation support now in SE 8 (JSR 308) nobody cares and nobody
> uses it,
> >>>> especially Oracle or others who could have used this JSR/annotation
> to
> >>>> facilitate 308. So far it's a "Compiler Zombie" barely ever
> >>> used outside a
> >>>> very small niche of "wacky academics";-)
> >>>>
> >>>> Werner
> >>>>
> >>>> On Thu, Jan 22, 2015 at 10:41 AM, Mark Struberg <st...@yahoo.de>
> >>> wrote:
> >>>>
> >>>> > I don't understand why we need javax.annotation.CheckForNull?
> >>>> >
> >>>> > This JSR is dormant and not widely adopted. It didn't even get
> >>> officially
> >>>> > released, right?
> >>>> >
> >>>> > LieGrue,
> >>>> > strub
> >>>> >
> >>>> >
> >>>> >
> >>>> >
> >>>> > > On Wednesday, 21 January 2015, 22:19,
> >>> "plexus@apache.org" <
> >>>> > plexus@apache.org> wrote:
> >>>> > > > Repository: incubator-tamaya
> >>>> > > Updated Branches:
> >>>> > > refs/heads/master ebe237cb9 -> 3ca337ebe
> >>>> > >
> >>>> > >
> >>>> > > BooleanConverter returns now null if it is not able to convert a
> >>>> > property.
> >>>> > >
> >>>> > >
> >>>> > > Project:
> >>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
> >>>> > > Commit:
> >>>> >
> >>>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/3ca337eb
> >>>> > > Tree:
> >>>> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/3ca337eb
> >>>> > > Diff:
> >>>> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/3ca337eb
> >>>> > >
> >>>> > > Branch: refs/heads/master
> >>>> > > Commit: 3ca337ebe22b75d32332aac211efd3e418163af3
> >>>> > > Parents: ebe237c
> >>>> > > Author: Oliver B. Fischer <pl...@apache.org>
> >>>> > > Authored: Wed Jan 21 22:17:41 2015 +0100
> >>>> > > Committer: Oliver B. Fischer <pl...@apache.org>
> >>>> > > Committed: Wed Jan 21 22:17:41 2015 +0100
> >>>> > >
> >>>> > >
> >>> ----------------------------------------------------------------------
> >>>> > > java8/core/pom.xml | 5
> >>> +++++
> >>>> > > .../tamaya/core/internal/converters/BooleanConverter.java | 5
> >>> ++++-
> >>>> > > pom.xml | 7
> >>>> +++++++
> >>>> > > 3 files changed, 16 insertions(+), 1 deletion(-)
> >>>> > >
> >>> ----------------------------------------------------------------------
> >>>> > >
> >>>> > >
> >>>> > >
> >>>> >
> >>>>
> >>>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/pom.xml
> >>>> > >
> >>> ----------------------------------------------------------------------
> >>>> > > diff --git a/java8/core/pom.xml b/java8/core/pom.xml
> >>>> > > index 029b2ff..d9be79f 100644
> >>>> > > --- a/java8/core/pom.xml
> >>>> > > +++ b/java8/core/pom.xml
> >>>> > > @@ -38,6 +38,11 @@ under the License.
> >>>> > > </dependency>
> >>>> > >
> >>>> > > <dependency>
> >>>> > > +
> >>> <groupId>com.google.code.findbugs</groupId>
> >>>> > > + <artifactId>annotations</artifactId>
> >>>> > > + </dependency>
> >>>> > > +
> >>>> > > + <dependency>
> >>>> > > <groupId>junit</groupId>
> >>>> > > <artifactId>junit</artifactId>
> >>>> > > </dependency>
> >>>> > >
> >>>> > >
> >>>> >
> >>>>
> >>>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> >>>> > >
> >>> ----------------------------------------------------------------------
> >>>> > > diff --git
> >>>> > >
> >>>> >
> >>>>
> >>>
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> >>>> > >
> >>>> >
> >>>>
> >>>
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> >>>> > > index a9cb5ad..76fd4d7 100644
> >>>> > > ---
> >>>> > >
> >>>> >
> >>>>
> >>>
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> >>>> > > +++
> >>>> > >
> >>>> >
> >>>>
> >>>
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> >>>> > > @@ -20,6 +20,7 @@ package
> >>> org.apache.tamaya.core.internal.converters;
> >>>> > >
> >>>> > > import org.apache.tamaya.spi.PropertyConverter;
> >>>> > >
> >>>> > > +import javax.annotation.CheckForNull;
> >>>> > > import java.util.Locale;
> >>>> > > import java.util.Objects;
> >>>> > > import java.util.logging.Logger;
> >>>> > > @@ -32,6 +33,7 @@ public class BooleanConverter implements
> >>>> > > PropertyConverter<Boolean> {
> >>>> > > private Logger LOG = Logger.getLogger(getClass().getName());
> >>>> > >
> >>>> > > @Override
> >>>> > > + @CheckForNull
> >>>> > > public Boolean convert(String value) {
> >>>> > > String ignoreCaseValue = Objects.requireNonNull(value)
> >>>> > > .trim()
> >>>> > > @@ -51,6 +53,7 @@ public class BooleanConverter implements
> >>>> > > PropertyConverter<Boolean> {
> >>>> > > default:
> >>>> > > LOG.warning("Unknown boolean value
> >>> encountered: " +
> >>>> > > value);
> >>>> > > }
> >>>> > > - return Boolean.FALSE;
> >>>> > > +
> >>>> > > + return null;
> >>>> > > }
> >>>> > > }
> >>>> > >
> >>>> > >
> >>>> >
> >>>>
> >>>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/pom.xml
> >>>> > >
> >>> ----------------------------------------------------------------------
> >>>> > > diff --git a/pom.xml b/pom.xml
> >>>> > > index 8f1f46f..384bf2e 100644
> >>>> > > --- a/pom.xml
> >>>> > > +++ b/pom.xml
> >>>> > > @@ -215,6 +215,13 @@ under the License.
> >>>> > >
> >>> <version>${junit.version}</version>
> >>>> > > <scope>test</scope>
> >>>> > > </dependency>
> >>>> > > +
> >>>> > > + <dependency>
> >>>> > > +
> >>> <groupId>com.google.code.findbugs</groupId>
> >>>> > > + <artifactId>annotations</artifactId>
> >>>> > > +
> >>> <version>${findbugs.version}</version>
> >>>> > > + </dependency>
> >>>> > > +
> >>>> > > <dependency>
> >>>> > > <groupId>org.hamcrest</groupId>
> >>>> > >
> >>> <artifactId>hamcrest-core</artifactId>
> >>>> > >
> >>>> >
> >>>>
> >>>
> >>
> >
> >
> >
>
Re: incubator-tamaya git commit: BooleanConverter returns now null
if it is not able to convert a property.
Posted by Mark Struberg <st...@yahoo.de>.
That is really a grey area and up to the lawyer.
LGPL is only widely agreed to be non-viral if you have it as runtime linked library.For larger work and direct compile inclusion it is partly assumed to be viral.
See our licensing matrix:
http://www.apache.org/legal/resolved.html
LieGrue,
strub
On Thursday, 22 January 2015, 12:10, Andres Almiray <aa...@gmail.com> wrote:
>
>
>Hi Mark,
>
>Perhaps I'm too naive and misunderstood the implications, but I thought that LGPL was compatible with ASL2. GPL is the viral one.
>
>Anyhow, the jsr305 binary I'm referring to is published under ASL2 :-)
>See https://repository.sonatype.org/service/local/repositories/atlassian/content/com/google/code/findbugs/jsr305/3.0.0/jsr305-3.0.0.pom
>
>Cheers,
>Andres
>
>
>
>
>-------------------------------------------
>Java Champion; Groovy Enthusiast
>http://jroller.com/aalmiray
>http://www.linkedin.com/in/aalmiray
>--
>What goes up, must come down. Ask any system administrator.
>There are 10 types of people in the world: Those who understand binary, and those who don't.
>To understand recursion, we must first understand recursion.
>
>On Thu, Jan 22, 2015 at 12:03 PM, Mark Struberg <st...@yahoo.de> wrote:
>
>Hi Andres!
>>
>>The problem I have with this package is that it is LGPL. Thus we MUST NOT use it in ALv2 licensed code... This is a strict no-go!
>>
>>
>>Is there a JSR-305 jar which has a better license? EPL, ALv2, MIT, BSD,...
>>
>>LieGrue,
>>strub
>>
>>
>>
>>
>>
>>
>>> On Thursday, 22 January 2015, 11:45, Andres Almiray <aa...@gmail.com> wrote:
>>> > FWIW even if JSR305 is marked as dormant and never had an official release
>>> facts are
>>>
>>> 1. there's a working binary release that can be used
>>> 2. IntelliJ IDEA recognizes the annotations and gives you proper feedback.
>>> Most likely NetBeans follows the same pattern. If using Eclipse then
>>> consider switching to a better IDE ;-)
>>>
>>> My preferred artifact definition for the binaries is
>>> "com.google.code.findbugs:jsr305:3.0.0" btw. We make extensive use of
>>> these
>>> annotations in the Griffon framework and its plugins.
>>> Considering that Griffon may become the RI of JSR377 in the not so distant
>>> future I think we may be able to "defibrillate" JSR305 into action
>>> *crosses
>>> fingers*.
>>>
>>> Cheers,
>>> Andres
>>>
>>> -------------------------------------------
>>> Java Champion; Groovy Enthusiast
>>> http://jroller.com/aalmiray
>>> http://www.linkedin.com/in/aalmiray
>>> --
>>> What goes up, must come down. Ask any system administrator.
>>> There are 10 types of people in the world: Those who understand binary, and
>>> those who don't.
>>> To understand recursion, we must first understand recursion.
>>>
>>>
>>> On Thu, Jan 22, 2015 at 11:39 AM, Werner Keil <we...@gmail.com>
>>> wrote:
>>>
>>>> If we do, then it at least puts Java SE 8 and Optional very much in
>>>> question, the two try to scratch the same itch;-)
>>>>
>>>> You are right, there has been little activity putting life back into any of
>>>> these annotations and despite the underlying compiler has some further
>>>> annotation support now in SE 8 (JSR 308) nobody cares and nobody uses it,
>>>> especially Oracle or others who could have used this JSR/annotation to
>>>> facilitate 308. So far it's a "Compiler Zombie" barely ever
>>> used outside a
>>>> very small niche of "wacky academics";-)
>>>>
>>>> Werner
>>>>
>>>> On Thu, Jan 22, 2015 at 10:41 AM, Mark Struberg <st...@yahoo.de>
>>> wrote:
>>>>
>>>> > I don't understand why we need javax.annotation.CheckForNull?
>>>> >
>>>> > This JSR is dormant and not widely adopted. It didn't even get
>>> officially
>>>> > released, right?
>>>> >
>>>> > LieGrue,
>>>> > strub
>>>> >
>>>> >
>>>> >
>>>> >
>>>> > > On Wednesday, 21 January 2015, 22:19,
>>> "plexus@apache.org" <
>>>> > plexus@apache.org> wrote:
>>>> > > > Repository: incubator-tamaya
>>>> > > Updated Branches:
>>>> > > refs/heads/master ebe237cb9 -> 3ca337ebe
>>>> > >
>>>> > >
>>>> > > BooleanConverter returns now null if it is not able to convert a
>>>> > property.
>>>> > >
>>>> > >
>>>> > > Project:
>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
>>>> > > Commit:
>>>> >
>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/3ca337eb
>>>> > > Tree:
>>>> > http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/3ca337eb
>>>> > > Diff:
>>>> > http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/3ca337eb
>>>> > >
>>>> > > Branch: refs/heads/master
>>>> > > Commit: 3ca337ebe22b75d32332aac211efd3e418163af3
>>>> > > Parents: ebe237c
>>>> > > Author: Oliver B. Fischer <pl...@apache.org>
>>>> > > Authored: Wed Jan 21 22:17:41 2015 +0100
>>>> > > Committer: Oliver B. Fischer <pl...@apache.org>
>>>> > > Committed: Wed Jan 21 22:17:41 2015 +0100
>>>> > >
>>>> > >
>>> ----------------------------------------------------------------------
>>>> > > java8/core/pom.xml | 5
>>> +++++
>>>> > > .../tamaya/core/internal/converters/BooleanConverter.java | 5
>>> ++++-
>>>> > > pom.xml | 7
>>>> +++++++
>>>> > > 3 files changed, 16 insertions(+), 1 deletion(-)
>>>> > >
>>> ----------------------------------------------------------------------
>>>> > >
>>>> > >
>>>> > >
>>>> >
>>>>
>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/pom.xml
>>>> > >
>>> ----------------------------------------------------------------------
>>>> > > diff --git a/java8/core/pom.xml b/java8/core/pom.xml
>>>> > > index 029b2ff..d9be79f 100644
>>>> > > --- a/java8/core/pom.xml
>>>> > > +++ b/java8/core/pom.xml
>>>> > > @@ -38,6 +38,11 @@ under the License.
>>>> > > </dependency>
>>>> > >
>>>> > > <dependency>
>>>> > > +
>>> <groupId>com.google.code.findbugs</groupId>
>>>> > > + <artifactId>annotations</artifactId>
>>>> > > + </dependency>
>>>> > > +
>>>> > > + <dependency>
>>>> > > <groupId>junit</groupId>
>>>> > > <artifactId>junit</artifactId>
>>>> > > </dependency>
>>>> > >
>>>> > >
>>>> >
>>>>
>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>> > >
>>> ----------------------------------------------------------------------
>>>> > > diff --git
>>>> > >
>>>> >
>>>>
>>> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>> > >
>>>> >
>>>>
>>> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>> > > index a9cb5ad..76fd4d7 100644
>>>> > > ---
>>>> > >
>>>> >
>>>>
>>> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>> > > +++
>>>> > >
>>>> >
>>>>
>>> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>>>> > > @@ -20,6 +20,7 @@ package
>>> org.apache.tamaya.core.internal.converters;
>>>> > >
>>>> > > import org.apache.tamaya.spi.PropertyConverter;
>>>> > >
>>>> > > +import javax.annotation.CheckForNull;
>>>> > > import java.util.Locale;
>>>> > > import java.util.Objects;
>>>> > > import java.util.logging.Logger;
>>>> > > @@ -32,6 +33,7 @@ public class BooleanConverter implements
>>>> > > PropertyConverter<Boolean> {
>>>> > > private Logger LOG = Logger.getLogger(getClass().getName());
>>>> > >
>>>> > > @Override
>>>> > > + @CheckForNull
>>>> > > public Boolean convert(String value) {
>>>> > > String ignoreCaseValue = Objects.requireNonNull(value)
>>>> > > .trim()
>>>> > > @@ -51,6 +53,7 @@ public class BooleanConverter implements
>>>> > > PropertyConverter<Boolean> {
>>>> > > default:
>>>> > > LOG.warning("Unknown boolean value
>>> encountered: " +
>>>> > > value);
>>>> > > }
>>>> > > - return Boolean.FALSE;
>>>> > > +
>>>> > > + return null;
>>>> > > }
>>>> > > }
>>>> > >
>>>> > >
>>>> >
>>>>
>>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/pom.xml
>>>> > >
>>> ----------------------------------------------------------------------
>>>> > > diff --git a/pom.xml b/pom.xml
>>>> > > index 8f1f46f..384bf2e 100644
>>>> > > --- a/pom.xml
>>>> > > +++ b/pom.xml
>>>> > > @@ -215,6 +215,13 @@ under the License.
>>>> > >
>>> <version>${junit.version}</version>
>>>> > > <scope>test</scope>
>>>> > > </dependency>
>>>> > > +
>>>> > > + <dependency>
>>>> > > +
>>> <groupId>com.google.code.findbugs</groupId>
>>>> > > + <artifactId>annotations</artifactId>
>>>> > > +
>>> <version>${findbugs.version}</version>
>>>> > > + </dependency>
>>>> > > +
>>>> > > <dependency>
>>>> > > <groupId>org.hamcrest</groupId>
>>>> > >
>>> <artifactId>hamcrest-core</artifactId>
>>>> > >
>>>> >
>>>>
>>>
>>
>
>
>
Re: incubator-tamaya git commit: BooleanConverter returns now null if
it is not able to convert a property.
Posted by Andres Almiray <aa...@gmail.com>.
Hi Mark,
Perhaps I'm too naive and misunderstood the implications, but I thought
that LGPL was compatible with ASL2. GPL is the viral one.
Anyhow, the jsr305 binary I'm referring to is published under ASL2 :-)
See
https://repository.sonatype.org/service/local/repositories/atlassian/content/com/google/code/findbugs/jsr305/3.0.0/jsr305-3.0.0.pom
Cheers,
Andres
-------------------------------------------
Java Champion; Groovy Enthusiast
http://jroller.com/aalmiray
http://www.linkedin.com/in/aalmiray
--
What goes up, must come down. Ask any system administrator.
There are 10 types of people in the world: Those who understand binary, and
those who don't.
To understand recursion, we must first understand recursion.
On Thu, Jan 22, 2015 at 12:03 PM, Mark Struberg <st...@yahoo.de> wrote:
> Hi Andres!
>
> The problem I have with this package is that it is LGPL. Thus we MUST NOT
> use it in ALv2 licensed code... This is a strict no-go!
>
>
> Is there a JSR-305 jar which has a better license? EPL, ALv2, MIT, BSD,...
>
> LieGrue,
> strub
>
>
>
>
>
> > On Thursday, 22 January 2015, 11:45, Andres Almiray <aa...@gmail.com>
> wrote:
> > > FWIW even if JSR305 is marked as dormant and never had an official
> release
> > facts are
> >
> > 1. there's a working binary release that can be used
> > 2. IntelliJ IDEA recognizes the annotations and gives you proper
> feedback.
> > Most likely NetBeans follows the same pattern. If using Eclipse then
> > consider switching to a better IDE ;-)
> >
> > My preferred artifact definition for the binaries is
> > "com.google.code.findbugs:jsr305:3.0.0" btw. We make extensive use of
> > these
> > annotations in the Griffon framework and its plugins.
> > Considering that Griffon may become the RI of JSR377 in the not so
> distant
> > future I think we may be able to "defibrillate" JSR305 into action
> > *crosses
> > fingers*.
> >
> > Cheers,
> > Andres
> >
> > -------------------------------------------
> > Java Champion; Groovy Enthusiast
> > http://jroller.com/aalmiray
> > http://www.linkedin.com/in/aalmiray
> > --
> > What goes up, must come down. Ask any system administrator.
> > There are 10 types of people in the world: Those who understand binary,
> and
> > those who don't.
> > To understand recursion, we must first understand recursion.
> >
> >
> > On Thu, Jan 22, 2015 at 11:39 AM, Werner Keil <we...@gmail.com>
> > wrote:
> >
> >> If we do, then it at least puts Java SE 8 and Optional very much in
> >> question, the two try to scratch the same itch;-)
> >>
> >> You are right, there has been little activity putting life back into
> any of
> >> these annotations and despite the underlying compiler has some further
> >> annotation support now in SE 8 (JSR 308) nobody cares and nobody uses
> it,
> >> especially Oracle or others who could have used this JSR/annotation to
> >> facilitate 308. So far it's a "Compiler Zombie" barely ever
> > used outside a
> >> very small niche of "wacky academics";-)
> >>
> >> Werner
> >>
> >> On Thu, Jan 22, 2015 at 10:41 AM, Mark Struberg <st...@yahoo.de>
> > wrote:
> >>
> >> > I don't understand why we need javax.annotation.CheckForNull?
> >> >
> >> > This JSR is dormant and not widely adopted. It didn't even get
> > officially
> >> > released, right?
> >> >
> >> > LieGrue,
> >> > strub
> >> >
> >> >
> >> >
> >> >
> >> > > On Wednesday, 21 January 2015, 22:19,
> > "plexus@apache.org" <
> >> > plexus@apache.org> wrote:
> >> > > > Repository: incubator-tamaya
> >> > > Updated Branches:
> >> > > refs/heads/master ebe237cb9 -> 3ca337ebe
> >> > >
> >> > >
> >> > > BooleanConverter returns now null if it is not able to convert a
> >> > property.
> >> > >
> >> > >
> >> > > Project:
> > http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
> >> > > Commit:
> >> >
> > http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/3ca337eb
> >> > > Tree:
> >> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/3ca337eb
> >> > > Diff:
> >> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/3ca337eb
> >> > >
> >> > > Branch: refs/heads/master
> >> > > Commit: 3ca337ebe22b75d32332aac211efd3e418163af3
> >> > > Parents: ebe237c
> >> > > Author: Oliver B. Fischer <pl...@apache.org>
> >> > > Authored: Wed Jan 21 22:17:41 2015 +0100
> >> > > Committer: Oliver B. Fischer <pl...@apache.org>
> >> > > Committed: Wed Jan 21 22:17:41 2015 +0100
> >> > >
> >> > >
> > ----------------------------------------------------------------------
> >> > > java8/core/pom.xml | 5
> > +++++
> >> > > .../tamaya/core/internal/converters/BooleanConverter.java | 5
> > ++++-
> >> > > pom.xml | 7
> >> +++++++
> >> > > 3 files changed, 16 insertions(+), 1 deletion(-)
> >> > >
> > ----------------------------------------------------------------------
> >> > >
> >> > >
> >> > >
> >> >
> >>
> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/pom.xml
> >> > >
> > ----------------------------------------------------------------------
> >> > > diff --git a/java8/core/pom.xml b/java8/core/pom.xml
> >> > > index 029b2ff..d9be79f 100644
> >> > > --- a/java8/core/pom.xml
> >> > > +++ b/java8/core/pom.xml
> >> > > @@ -38,6 +38,11 @@ under the License.
> >> > > </dependency>
> >> > >
> >> > > <dependency>
> >> > > +
> > <groupId>com.google.code.findbugs</groupId>
> >> > > + <artifactId>annotations</artifactId>
> >> > > + </dependency>
> >> > > +
> >> > > + <dependency>
> >> > > <groupId>junit</groupId>
> >> > > <artifactId>junit</artifactId>
> >> > > </dependency>
> >> > >
> >> > >
> >> >
> >>
> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> >> > >
> > ----------------------------------------------------------------------
> >> > > diff --git
> >> > >
> >> >
> >>
> >
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> >> > >
> >> >
> >>
> >
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> >> > > index a9cb5ad..76fd4d7 100644
> >> > > ---
> >> > >
> >> >
> >>
> >
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> >> > > +++
> >> > >
> >> >
> >>
> >
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> >> > > @@ -20,6 +20,7 @@ package
> > org.apache.tamaya.core.internal.converters;
> >> > >
> >> > > import org.apache.tamaya.spi.PropertyConverter;
> >> > >
> >> > > +import javax.annotation.CheckForNull;
> >> > > import java.util.Locale;
> >> > > import java.util.Objects;
> >> > > import java.util.logging.Logger;
> >> > > @@ -32,6 +33,7 @@ public class BooleanConverter implements
> >> > > PropertyConverter<Boolean> {
> >> > > private Logger LOG = Logger.getLogger(getClass().getName());
> >> > >
> >> > > @Override
> >> > > + @CheckForNull
> >> > > public Boolean convert(String value) {
> >> > > String ignoreCaseValue = Objects.requireNonNull(value)
> >> > > .trim()
> >> > > @@ -51,6 +53,7 @@ public class BooleanConverter implements
> >> > > PropertyConverter<Boolean> {
> >> > > default:
> >> > > LOG.warning("Unknown boolean value
> > encountered: " +
> >> > > value);
> >> > > }
> >> > > - return Boolean.FALSE;
> >> > > +
> >> > > + return null;
> >> > > }
> >> > > }
> >> > >
> >> > >
> >> >
> >>
> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/pom.xml
> >> > >
> > ----------------------------------------------------------------------
> >> > > diff --git a/pom.xml b/pom.xml
> >> > > index 8f1f46f..384bf2e 100644
> >> > > --- a/pom.xml
> >> > > +++ b/pom.xml
> >> > > @@ -215,6 +215,13 @@ under the License.
> >> > >
> > <version>${junit.version}</version>
> >> > > <scope>test</scope>
> >> > > </dependency>
> >> > > +
> >> > > + <dependency>
> >> > > +
> > <groupId>com.google.code.findbugs</groupId>
> >> > > + <artifactId>annotations</artifactId>
> >> > > +
> > <version>${findbugs.version}</version>
> >> > > + </dependency>
> >> > > +
> >> > > <dependency>
> >> > > <groupId>org.hamcrest</groupId>
> >> > >
> > <artifactId>hamcrest-core</artifactId>
> >> > >
> >> >
> >>
> >
>
Re: incubator-tamaya git commit: BooleanConverter returns now null
if it is not able to convert a property.
Posted by Mark Struberg <st...@yahoo.de>.
Hi Andres!
The problem I have with this package is that it is LGPL. Thus we MUST NOT use it in ALv2 licensed code... This is a strict no-go!
Is there a JSR-305 jar which has a better license? EPL, ALv2, MIT, BSD,...
LieGrue,
strub
> On Thursday, 22 January 2015, 11:45, Andres Almiray <aa...@gmail.com> wrote:
> > FWIW even if JSR305 is marked as dormant and never had an official release
> facts are
>
> 1. there's a working binary release that can be used
> 2. IntelliJ IDEA recognizes the annotations and gives you proper feedback.
> Most likely NetBeans follows the same pattern. If using Eclipse then
> consider switching to a better IDE ;-)
>
> My preferred artifact definition for the binaries is
> "com.google.code.findbugs:jsr305:3.0.0" btw. We make extensive use of
> these
> annotations in the Griffon framework and its plugins.
> Considering that Griffon may become the RI of JSR377 in the not so distant
> future I think we may be able to "defibrillate" JSR305 into action
> *crosses
> fingers*.
>
> Cheers,
> Andres
>
> -------------------------------------------
> Java Champion; Groovy Enthusiast
> http://jroller.com/aalmiray
> http://www.linkedin.com/in/aalmiray
> --
> What goes up, must come down. Ask any system administrator.
> There are 10 types of people in the world: Those who understand binary, and
> those who don't.
> To understand recursion, we must first understand recursion.
>
>
> On Thu, Jan 22, 2015 at 11:39 AM, Werner Keil <we...@gmail.com>
> wrote:
>
>> If we do, then it at least puts Java SE 8 and Optional very much in
>> question, the two try to scratch the same itch;-)
>>
>> You are right, there has been little activity putting life back into any of
>> these annotations and despite the underlying compiler has some further
>> annotation support now in SE 8 (JSR 308) nobody cares and nobody uses it,
>> especially Oracle or others who could have used this JSR/annotation to
>> facilitate 308. So far it's a "Compiler Zombie" barely ever
> used outside a
>> very small niche of "wacky academics";-)
>>
>> Werner
>>
>> On Thu, Jan 22, 2015 at 10:41 AM, Mark Struberg <st...@yahoo.de>
> wrote:
>>
>> > I don't understand why we need javax.annotation.CheckForNull?
>> >
>> > This JSR is dormant and not widely adopted. It didn't even get
> officially
>> > released, right?
>> >
>> > LieGrue,
>> > strub
>> >
>> >
>> >
>> >
>> > > On Wednesday, 21 January 2015, 22:19,
> "plexus@apache.org" <
>> > plexus@apache.org> wrote:
>> > > > Repository: incubator-tamaya
>> > > Updated Branches:
>> > > refs/heads/master ebe237cb9 -> 3ca337ebe
>> > >
>> > >
>> > > BooleanConverter returns now null if it is not able to convert a
>> > property.
>> > >
>> > >
>> > > Project:
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
>> > > Commit:
>> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/3ca337eb
>> > > Tree:
>> > http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/3ca337eb
>> > > Diff:
>> > http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/3ca337eb
>> > >
>> > > Branch: refs/heads/master
>> > > Commit: 3ca337ebe22b75d32332aac211efd3e418163af3
>> > > Parents: ebe237c
>> > > Author: Oliver B. Fischer <pl...@apache.org>
>> > > Authored: Wed Jan 21 22:17:41 2015 +0100
>> > > Committer: Oliver B. Fischer <pl...@apache.org>
>> > > Committed: Wed Jan 21 22:17:41 2015 +0100
>> > >
>> > >
> ----------------------------------------------------------------------
>> > > java8/core/pom.xml | 5
> +++++
>> > > .../tamaya/core/internal/converters/BooleanConverter.java | 5
> ++++-
>> > > pom.xml | 7
>> +++++++
>> > > 3 files changed, 16 insertions(+), 1 deletion(-)
>> > >
> ----------------------------------------------------------------------
>> > >
>> > >
>> > >
>> >
>>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/pom.xml
>> > >
> ----------------------------------------------------------------------
>> > > diff --git a/java8/core/pom.xml b/java8/core/pom.xml
>> > > index 029b2ff..d9be79f 100644
>> > > --- a/java8/core/pom.xml
>> > > +++ b/java8/core/pom.xml
>> > > @@ -38,6 +38,11 @@ under the License.
>> > > </dependency>
>> > >
>> > > <dependency>
>> > > +
> <groupId>com.google.code.findbugs</groupId>
>> > > + <artifactId>annotations</artifactId>
>> > > + </dependency>
>> > > +
>> > > + <dependency>
>> > > <groupId>junit</groupId>
>> > > <artifactId>junit</artifactId>
>> > > </dependency>
>> > >
>> > >
>> >
>>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>> > >
> ----------------------------------------------------------------------
>> > > diff --git
>> > >
>> >
>>
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>> > >
>> >
>>
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>> > > index a9cb5ad..76fd4d7 100644
>> > > ---
>> > >
>> >
>>
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>> > > +++
>> > >
>> >
>>
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>> > > @@ -20,6 +20,7 @@ package
> org.apache.tamaya.core.internal.converters;
>> > >
>> > > import org.apache.tamaya.spi.PropertyConverter;
>> > >
>> > > +import javax.annotation.CheckForNull;
>> > > import java.util.Locale;
>> > > import java.util.Objects;
>> > > import java.util.logging.Logger;
>> > > @@ -32,6 +33,7 @@ public class BooleanConverter implements
>> > > PropertyConverter<Boolean> {
>> > > private Logger LOG = Logger.getLogger(getClass().getName());
>> > >
>> > > @Override
>> > > + @CheckForNull
>> > > public Boolean convert(String value) {
>> > > String ignoreCaseValue = Objects.requireNonNull(value)
>> > > .trim()
>> > > @@ -51,6 +53,7 @@ public class BooleanConverter implements
>> > > PropertyConverter<Boolean> {
>> > > default:
>> > > LOG.warning("Unknown boolean value
> encountered: " +
>> > > value);
>> > > }
>> > > - return Boolean.FALSE;
>> > > +
>> > > + return null;
>> > > }
>> > > }
>> > >
>> > >
>> >
>>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/pom.xml
>> > >
> ----------------------------------------------------------------------
>> > > diff --git a/pom.xml b/pom.xml
>> > > index 8f1f46f..384bf2e 100644
>> > > --- a/pom.xml
>> > > +++ b/pom.xml
>> > > @@ -215,6 +215,13 @@ under the License.
>> > >
> <version>${junit.version}</version>
>> > > <scope>test</scope>
>> > > </dependency>
>> > > +
>> > > + <dependency>
>> > > +
> <groupId>com.google.code.findbugs</groupId>
>> > > + <artifactId>annotations</artifactId>
>> > > +
> <version>${findbugs.version}</version>
>> > > + </dependency>
>> > > +
>> > > <dependency>
>> > > <groupId>org.hamcrest</groupId>
>> > >
> <artifactId>hamcrest-core</artifactId>
>> > >
>> >
>>
>
Re: incubator-tamaya git commit: BooleanConverter returns now null if
it is not able to convert a property.
Posted by Werner Keil <we...@gmail.com>.
Actually some parts under Eclipse JDT even support JSR 308 Type Annotations
at least unofficially (not at Eclipse Labs or Eclipse.org AFAIK), so
Eclipse in that area looks like the best IDE to use;-)
I spoke to people at Oracle including some of the senior architects and
they said so far they're not aware NetBeans cares about JSR 308 or 305.
Cheers,
Werner
On Thu, Jan 22, 2015 at 11:45 AM, Andres Almiray <aa...@gmail.com> wrote:
> FWIW even if JSR305 is marked as dormant and never had an official release
> facts are
>
> 1. there's a working binary release that can be used
> 2. IntelliJ IDEA recognizes the annotations and gives you proper feedback.
> Most likely NetBeans follows the same pattern. If using Eclipse then
> consider switching to a better IDE ;-)
>
> My preferred artifact definition for the binaries is
> "com.google.code.findbugs:jsr305:3.0.0" btw. We make extensive use of these
> annotations in the Griffon framework and its plugins.
> Considering that Griffon may become the RI of JSR377 in the not so distant
> future I think we may be able to "defibrillate" JSR305 into action *crosses
> fingers*.
>
> Cheers,
> Andres
>
> -------------------------------------------
> Java Champion; Groovy Enthusiast
> http://jroller.com/aalmiray
> http://www.linkedin.com/in/aalmiray
> --
> What goes up, must come down. Ask any system administrator.
> There are 10 types of people in the world: Those who understand binary, and
> those who don't.
> To understand recursion, we must first understand recursion.
>
> On Thu, Jan 22, 2015 at 11:39 AM, Werner Keil <we...@gmail.com>
> wrote:
>
> > If we do, then it at least puts Java SE 8 and Optional very much in
> > question, the two try to scratch the same itch;-)
> >
> > You are right, there has been little activity putting life back into any
> of
> > these annotations and despite the underlying compiler has some further
> > annotation support now in SE 8 (JSR 308) nobody cares and nobody uses it,
> > especially Oracle or others who could have used this JSR/annotation to
> > facilitate 308. So far it's a "Compiler Zombie" barely ever used outside
> a
> > very small niche of "wacky academics";-)
> >
> > Werner
> >
> > On Thu, Jan 22, 2015 at 10:41 AM, Mark Struberg <st...@yahoo.de>
> wrote:
> >
> > > I don't understand why we need javax.annotation.CheckForNull?
> > >
> > > This JSR is dormant and not widely adopted. It didn't even get
> officially
> > > released, right?
> > >
> > > LieGrue,
> > > strub
> > >
> > >
> > >
> > >
> > > > On Wednesday, 21 January 2015, 22:19, "plexus@apache.org" <
> > > plexus@apache.org> wrote:
> > > > > Repository: incubator-tamaya
> > > > Updated Branches:
> > > > refs/heads/master ebe237cb9 -> 3ca337ebe
> > > >
> > > >
> > > > BooleanConverter returns now null if it is not able to convert a
> > > property.
> > > >
> > > >
> > > > Project:
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
> > > > Commit:
> > >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/3ca337eb
> > > > Tree:
> > > http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/3ca337eb
> > > > Diff:
> > > http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/3ca337eb
> > > >
> > > > Branch: refs/heads/master
> > > > Commit: 3ca337ebe22b75d32332aac211efd3e418163af3
> > > > Parents: ebe237c
> > > > Author: Oliver B. Fischer <pl...@apache.org>
> > > > Authored: Wed Jan 21 22:17:41 2015 +0100
> > > > Committer: Oliver B. Fischer <pl...@apache.org>
> > > > Committed: Wed Jan 21 22:17:41 2015 +0100
> > > >
> > > >
> ----------------------------------------------------------------------
> > > > java8/core/pom.xml | 5
> +++++
> > > > .../tamaya/core/internal/converters/BooleanConverter.java | 5
> ++++-
> > > > pom.xml | 7
> > +++++++
> > > > 3 files changed, 16 insertions(+), 1 deletion(-)
> > > >
> ----------------------------------------------------------------------
> > > >
> > > >
> > > >
> > >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/pom.xml
> > > >
> ----------------------------------------------------------------------
> > > > diff --git a/java8/core/pom.xml b/java8/core/pom.xml
> > > > index 029b2ff..d9be79f 100644
> > > > --- a/java8/core/pom.xml
> > > > +++ b/java8/core/pom.xml
> > > > @@ -38,6 +38,11 @@ under the License.
> > > > </dependency>
> > > >
> > > > <dependency>
> > > > + <groupId>com.google.code.findbugs</groupId>
> > > > + <artifactId>annotations</artifactId>
> > > > + </dependency>
> > > > +
> > > > + <dependency>
> > > > <groupId>junit</groupId>
> > > > <artifactId>junit</artifactId>
> > > > </dependency>
> > > >
> > > >
> > >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > > >
> ----------------------------------------------------------------------
> > > > diff --git
> > > >
> > >
> >
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > > >
> > >
> >
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > > > index a9cb5ad..76fd4d7 100644
> > > > ---
> > > >
> > >
> >
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > > > +++
> > > >
> > >
> >
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > > > @@ -20,6 +20,7 @@ package org.apache.tamaya.core.internal.converters;
> > > >
> > > > import org.apache.tamaya.spi.PropertyConverter;
> > > >
> > > > +import javax.annotation.CheckForNull;
> > > > import java.util.Locale;
> > > > import java.util.Objects;
> > > > import java.util.logging.Logger;
> > > > @@ -32,6 +33,7 @@ public class BooleanConverter implements
> > > > PropertyConverter<Boolean> {
> > > > private Logger LOG = Logger.getLogger(getClass().getName());
> > > >
> > > > @Override
> > > > + @CheckForNull
> > > > public Boolean convert(String value) {
> > > > String ignoreCaseValue = Objects.requireNonNull(value)
> > > > .trim()
> > > > @@ -51,6 +53,7 @@ public class BooleanConverter implements
> > > > PropertyConverter<Boolean> {
> > > > default:
> > > > LOG.warning("Unknown boolean value encountered: " +
> > > > value);
> > > > }
> > > > - return Boolean.FALSE;
> > > > +
> > > > + return null;
> > > > }
> > > > }
> > > >
> > > >
> > >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/pom.xml
> > > >
> ----------------------------------------------------------------------
> > > > diff --git a/pom.xml b/pom.xml
> > > > index 8f1f46f..384bf2e 100644
> > > > --- a/pom.xml
> > > > +++ b/pom.xml
> > > > @@ -215,6 +215,13 @@ under the License.
> > > > <version>${junit.version}</version>
> > > > <scope>test</scope>
> > > > </dependency>
> > > > +
> > > > + <dependency>
> > > > + <groupId>com.google.code.findbugs</groupId>
> > > > + <artifactId>annotations</artifactId>
> > > > + <version>${findbugs.version}</version>
> > > > + </dependency>
> > > > +
> > > > <dependency>
> > > > <groupId>org.hamcrest</groupId>
> > > > <artifactId>hamcrest-core</artifactId>
> > > >
> > >
> >
>
Re: incubator-tamaya git commit: BooleanConverter returns now null if
it is not able to convert a property.
Posted by Andres Almiray <aa...@gmail.com>.
FWIW even if JSR305 is marked as dormant and never had an official release
facts are
1. there's a working binary release that can be used
2. IntelliJ IDEA recognizes the annotations and gives you proper feedback.
Most likely NetBeans follows the same pattern. If using Eclipse then
consider switching to a better IDE ;-)
My preferred artifact definition for the binaries is
"com.google.code.findbugs:jsr305:3.0.0" btw. We make extensive use of these
annotations in the Griffon framework and its plugins.
Considering that Griffon may become the RI of JSR377 in the not so distant
future I think we may be able to "defibrillate" JSR305 into action *crosses
fingers*.
Cheers,
Andres
-------------------------------------------
Java Champion; Groovy Enthusiast
http://jroller.com/aalmiray
http://www.linkedin.com/in/aalmiray
--
What goes up, must come down. Ask any system administrator.
There are 10 types of people in the world: Those who understand binary, and
those who don't.
To understand recursion, we must first understand recursion.
On Thu, Jan 22, 2015 at 11:39 AM, Werner Keil <we...@gmail.com> wrote:
> If we do, then it at least puts Java SE 8 and Optional very much in
> question, the two try to scratch the same itch;-)
>
> You are right, there has been little activity putting life back into any of
> these annotations and despite the underlying compiler has some further
> annotation support now in SE 8 (JSR 308) nobody cares and nobody uses it,
> especially Oracle or others who could have used this JSR/annotation to
> facilitate 308. So far it's a "Compiler Zombie" barely ever used outside a
> very small niche of "wacky academics";-)
>
> Werner
>
> On Thu, Jan 22, 2015 at 10:41 AM, Mark Struberg <st...@yahoo.de> wrote:
>
> > I don't understand why we need javax.annotation.CheckForNull?
> >
> > This JSR is dormant and not widely adopted. It didn't even get officially
> > released, right?
> >
> > LieGrue,
> > strub
> >
> >
> >
> >
> > > On Wednesday, 21 January 2015, 22:19, "plexus@apache.org" <
> > plexus@apache.org> wrote:
> > > > Repository: incubator-tamaya
> > > Updated Branches:
> > > refs/heads/master ebe237cb9 -> 3ca337ebe
> > >
> > >
> > > BooleanConverter returns now null if it is not able to convert a
> > property.
> > >
> > >
> > > Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
> > > Commit:
> > http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/3ca337eb
> > > Tree:
> > http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/3ca337eb
> > > Diff:
> > http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/3ca337eb
> > >
> > > Branch: refs/heads/master
> > > Commit: 3ca337ebe22b75d32332aac211efd3e418163af3
> > > Parents: ebe237c
> > > Author: Oliver B. Fischer <pl...@apache.org>
> > > Authored: Wed Jan 21 22:17:41 2015 +0100
> > > Committer: Oliver B. Fischer <pl...@apache.org>
> > > Committed: Wed Jan 21 22:17:41 2015 +0100
> > >
> > > ----------------------------------------------------------------------
> > > java8/core/pom.xml | 5 +++++
> > > .../tamaya/core/internal/converters/BooleanConverter.java | 5 ++++-
> > > pom.xml | 7
> +++++++
> > > 3 files changed, 16 insertions(+), 1 deletion(-)
> > > ----------------------------------------------------------------------
> > >
> > >
> > >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/pom.xml
> > > ----------------------------------------------------------------------
> > > diff --git a/java8/core/pom.xml b/java8/core/pom.xml
> > > index 029b2ff..d9be79f 100644
> > > --- a/java8/core/pom.xml
> > > +++ b/java8/core/pom.xml
> > > @@ -38,6 +38,11 @@ under the License.
> > > </dependency>
> > >
> > > <dependency>
> > > + <groupId>com.google.code.findbugs</groupId>
> > > + <artifactId>annotations</artifactId>
> > > + </dependency>
> > > +
> > > + <dependency>
> > > <groupId>junit</groupId>
> > > <artifactId>junit</artifactId>
> > > </dependency>
> > >
> > >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > > ----------------------------------------------------------------------
> > > diff --git
> > >
> >
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > >
> >
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > > index a9cb5ad..76fd4d7 100644
> > > ---
> > >
> >
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > > +++
> > >
> >
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > > @@ -20,6 +20,7 @@ package org.apache.tamaya.core.internal.converters;
> > >
> > > import org.apache.tamaya.spi.PropertyConverter;
> > >
> > > +import javax.annotation.CheckForNull;
> > > import java.util.Locale;
> > > import java.util.Objects;
> > > import java.util.logging.Logger;
> > > @@ -32,6 +33,7 @@ public class BooleanConverter implements
> > > PropertyConverter<Boolean> {
> > > private Logger LOG = Logger.getLogger(getClass().getName());
> > >
> > > @Override
> > > + @CheckForNull
> > > public Boolean convert(String value) {
> > > String ignoreCaseValue = Objects.requireNonNull(value)
> > > .trim()
> > > @@ -51,6 +53,7 @@ public class BooleanConverter implements
> > > PropertyConverter<Boolean> {
> > > default:
> > > LOG.warning("Unknown boolean value encountered: " +
> > > value);
> > > }
> > > - return Boolean.FALSE;
> > > +
> > > + return null;
> > > }
> > > }
> > >
> > >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/pom.xml
> > > ----------------------------------------------------------------------
> > > diff --git a/pom.xml b/pom.xml
> > > index 8f1f46f..384bf2e 100644
> > > --- a/pom.xml
> > > +++ b/pom.xml
> > > @@ -215,6 +215,13 @@ under the License.
> > > <version>${junit.version}</version>
> > > <scope>test</scope>
> > > </dependency>
> > > +
> > > + <dependency>
> > > + <groupId>com.google.code.findbugs</groupId>
> > > + <artifactId>annotations</artifactId>
> > > + <version>${findbugs.version}</version>
> > > + </dependency>
> > > +
> > > <dependency>
> > > <groupId>org.hamcrest</groupId>
> > > <artifactId>hamcrest-core</artifactId>
> > >
> >
>
Re: incubator-tamaya git commit: BooleanConverter returns now null if
it is not able to convert a property.
Posted by Werner Keil <we...@gmail.com>.
If we do, then it at least puts Java SE 8 and Optional very much in
question, the two try to scratch the same itch;-)
You are right, there has been little activity putting life back into any of
these annotations and despite the underlying compiler has some further
annotation support now in SE 8 (JSR 308) nobody cares and nobody uses it,
especially Oracle or others who could have used this JSR/annotation to
facilitate 308. So far it's a "Compiler Zombie" barely ever used outside a
very small niche of "wacky academics";-)
Werner
On Thu, Jan 22, 2015 at 10:41 AM, Mark Struberg <st...@yahoo.de> wrote:
> I don't understand why we need javax.annotation.CheckForNull?
>
> This JSR is dormant and not widely adopted. It didn't even get officially
> released, right?
>
> LieGrue,
> strub
>
>
>
>
> > On Wednesday, 21 January 2015, 22:19, "plexus@apache.org" <
> plexus@apache.org> wrote:
> > > Repository: incubator-tamaya
> > Updated Branches:
> > refs/heads/master ebe237cb9 -> 3ca337ebe
> >
> >
> > BooleanConverter returns now null if it is not able to convert a
> property.
> >
> >
> > Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
> > Commit:
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/3ca337eb
> > Tree:
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/3ca337eb
> > Diff:
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/3ca337eb
> >
> > Branch: refs/heads/master
> > Commit: 3ca337ebe22b75d32332aac211efd3e418163af3
> > Parents: ebe237c
> > Author: Oliver B. Fischer <pl...@apache.org>
> > Authored: Wed Jan 21 22:17:41 2015 +0100
> > Committer: Oliver B. Fischer <pl...@apache.org>
> > Committed: Wed Jan 21 22:17:41 2015 +0100
> >
> > ----------------------------------------------------------------------
> > java8/core/pom.xml | 5 +++++
> > .../tamaya/core/internal/converters/BooleanConverter.java | 5 ++++-
> > pom.xml | 7 +++++++
> > 3 files changed, 16 insertions(+), 1 deletion(-)
> > ----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/java8/core/pom.xml b/java8/core/pom.xml
> > index 029b2ff..d9be79f 100644
> > --- a/java8/core/pom.xml
> > +++ b/java8/core/pom.xml
> > @@ -38,6 +38,11 @@ under the License.
> > </dependency>
> >
> > <dependency>
> > + <groupId>com.google.code.findbugs</groupId>
> > + <artifactId>annotations</artifactId>
> > + </dependency>
> > +
> > + <dependency>
> > <groupId>junit</groupId>
> > <artifactId>junit</artifactId>
> > </dependency>
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > ----------------------------------------------------------------------
> > diff --git
> >
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> >
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > index a9cb5ad..76fd4d7 100644
> > ---
> >
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > +++
> >
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> > @@ -20,6 +20,7 @@ package org.apache.tamaya.core.internal.converters;
> >
> > import org.apache.tamaya.spi.PropertyConverter;
> >
> > +import javax.annotation.CheckForNull;
> > import java.util.Locale;
> > import java.util.Objects;
> > import java.util.logging.Logger;
> > @@ -32,6 +33,7 @@ public class BooleanConverter implements
> > PropertyConverter<Boolean> {
> > private Logger LOG = Logger.getLogger(getClass().getName());
> >
> > @Override
> > + @CheckForNull
> > public Boolean convert(String value) {
> > String ignoreCaseValue = Objects.requireNonNull(value)
> > .trim()
> > @@ -51,6 +53,7 @@ public class BooleanConverter implements
> > PropertyConverter<Boolean> {
> > default:
> > LOG.warning("Unknown boolean value encountered: " +
> > value);
> > }
> > - return Boolean.FALSE;
> > +
> > + return null;
> > }
> > }
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/pom.xml
> > ----------------------------------------------------------------------
> > diff --git a/pom.xml b/pom.xml
> > index 8f1f46f..384bf2e 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -215,6 +215,13 @@ under the License.
> > <version>${junit.version}</version>
> > <scope>test</scope>
> > </dependency>
> > +
> > + <dependency>
> > + <groupId>com.google.code.findbugs</groupId>
> > + <artifactId>annotations</artifactId>
> > + <version>${findbugs.version}</version>
> > + </dependency>
> > +
> > <dependency>
> > <groupId>org.hamcrest</groupId>
> > <artifactId>hamcrest-core</artifactId>
> >
>
Re: incubator-tamaya git commit: BooleanConverter returns now null
if it is not able to convert a property.
Posted by "Oliver B. Fischer" <o....@swe-blog.net>.
Hi, it is only used for FindBugs. But it is right that we shouldn't use
LGPL code if possible. I will replace it by
com.google.code.findbugs:jsr305
It is ASLv2 licensed.
BYe,
Oliver
Am 22.01.15 um 10:41 schrieb Mark Struberg:
> I don't understand why we need javax.annotation.CheckForNull?
>
> This JSR is dormant and not widely adopted. It didn't even get officially released, right?
>
> LieGrue,
> strub
>
>
>
>
>> On Wednesday, 21 January 2015, 22:19, "plexus@apache.org" <pl...@apache.org> wrote:
>> Updated Branches:
>> refs/heads/master ebe237cb9 -> 3ca337ebe
>>
>>
>> BooleanConverter returns now null if it is not able to convert a property.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/3ca337eb
>> Tree: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/3ca337eb
>> Diff: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/3ca337eb
>>
>> Branch: refs/heads/master
>> Commit: 3ca337ebe22b75d32332aac211efd3e418163af3
>> Parents: ebe237c
>> Author: Oliver B. Fischer <pl...@apache.org>
>> Authored: Wed Jan 21 22:17:41 2015 +0100
>> Committer: Oliver B. Fischer <pl...@apache.org>
>> Committed: Wed Jan 21 22:17:41 2015 +0100
>>
>> ----------------------------------------------------------------------
>> java8/core/pom.xml | 5 +++++
>> .../tamaya/core/internal/converters/BooleanConverter.java | 5 ++++-
>> pom.xml | 7 +++++++
>> 3 files changed, 16 insertions(+), 1 deletion(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/pom.xml
>> ----------------------------------------------------------------------
>> diff --git a/java8/core/pom.xml b/java8/core/pom.xml
>> index 029b2ff..d9be79f 100644
>> --- a/java8/core/pom.xml
>> +++ b/java8/core/pom.xml
>> @@ -38,6 +38,11 @@ under the License.
>> </dependency>
>>
>> <dependency>
>> + <groupId>com.google.code.findbugs</groupId>
>> + <artifactId>annotations</artifactId>
>> + </dependency>
>> +
>> + <dependency>
>> <groupId>junit</groupId>
>> <artifactId>junit</artifactId>
>> </dependency>
>>
>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>> ----------------------------------------------------------------------
>> diff --git
>> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>> index a9cb5ad..76fd4d7 100644
>> ---
>> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>> +++
>> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
>> @@ -20,6 +20,7 @@ package org.apache.tamaya.core.internal.converters;
>>
>> import org.apache.tamaya.spi.PropertyConverter;
>>
>> +import javax.annotation.CheckForNull;
>> import java.util.Locale;
>> import java.util.Objects;
>> import java.util.logging.Logger;
>> @@ -32,6 +33,7 @@ public class BooleanConverter implements
>> PropertyConverter<Boolean> {
>> private Logger LOG = Logger.getLogger(getClass().getName());
>>
>> @Override
>> + @CheckForNull
>> public Boolean convert(String value) {
>> String ignoreCaseValue = Objects.requireNonNull(value)
>> .trim()
>> @@ -51,6 +53,7 @@ public class BooleanConverter implements
>> PropertyConverter<Boolean> {
>> default:
>> LOG.warning("Unknown boolean value encountered: " +
>> value);
>> }
>> - return Boolean.FALSE;
>> +
>> + return null;
>> }
>> }
>>
>> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/pom.xml
>> ----------------------------------------------------------------------
>> diff --git a/pom.xml b/pom.xml
>> index 8f1f46f..384bf2e 100644
>> --- a/pom.xml
>> +++ b/pom.xml
>> @@ -215,6 +215,13 @@ under the License.
>> <version>${junit.version}</version>
>> <scope>test</scope>
>> </dependency>
>> +
>> + <dependency>
>> + <groupId>com.google.code.findbugs</groupId>
>> + <artifactId>annotations</artifactId>
>> + <version>${findbugs.version}</version>
>> + </dependency>
>> +
>> <dependency>
>> <groupId>org.hamcrest</groupId>
>> <artifactId>hamcrest-core</artifactId>
>>
--
N Oliver B. Fischer
A Schönhauser Allee 64, 10437 Berlin, Deutschland/Germany
P +49 30 44793251
M +49 178 7903538
E o.b.fischer@swe-blog.net
S oliver.b.fischer
J oliver.b.fischer@jabber.org
X http://xing.to/obf
Re: incubator-tamaya git commit: BooleanConverter returns now null
if it is not able to convert a property.
Posted by Mark Struberg <st...@yahoo.de>.
I don't understand why we need javax.annotation.CheckForNull?
This JSR is dormant and not widely adopted. It didn't even get officially released, right?
LieGrue,
strub
> On Wednesday, 21 January 2015, 22:19, "plexus@apache.org" <pl...@apache.org> wrote:
> > Repository: incubator-tamaya
> Updated Branches:
> refs/heads/master ebe237cb9 -> 3ca337ebe
>
>
> BooleanConverter returns now null if it is not able to convert a property.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/repo
> Commit: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/commit/3ca337eb
> Tree: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/tree/3ca337eb
> Diff: http://git-wip-us.apache.org/repos/asf/incubator-tamaya/diff/3ca337eb
>
> Branch: refs/heads/master
> Commit: 3ca337ebe22b75d32332aac211efd3e418163af3
> Parents: ebe237c
> Author: Oliver B. Fischer <pl...@apache.org>
> Authored: Wed Jan 21 22:17:41 2015 +0100
> Committer: Oliver B. Fischer <pl...@apache.org>
> Committed: Wed Jan 21 22:17:41 2015 +0100
>
> ----------------------------------------------------------------------
> java8/core/pom.xml | 5 +++++
> .../tamaya/core/internal/converters/BooleanConverter.java | 5 ++++-
> pom.xml | 7 +++++++
> 3 files changed, 16 insertions(+), 1 deletion(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/pom.xml
> ----------------------------------------------------------------------
> diff --git a/java8/core/pom.xml b/java8/core/pom.xml
> index 029b2ff..d9be79f 100644
> --- a/java8/core/pom.xml
> +++ b/java8/core/pom.xml
> @@ -38,6 +38,11 @@ under the License.
> </dependency>
>
> <dependency>
> + <groupId>com.google.code.findbugs</groupId>
> + <artifactId>annotations</artifactId>
> + </dependency>
> +
> + <dependency>
> <groupId>junit</groupId>
> <artifactId>junit</artifactId>
> </dependency>
>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> ----------------------------------------------------------------------
> diff --git
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> index a9cb5ad..76fd4d7 100644
> ---
> a/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> +++
> b/java8/core/src/main/java/org/apache/tamaya/core/internal/converters/BooleanConverter.java
> @@ -20,6 +20,7 @@ package org.apache.tamaya.core.internal.converters;
>
> import org.apache.tamaya.spi.PropertyConverter;
>
> +import javax.annotation.CheckForNull;
> import java.util.Locale;
> import java.util.Objects;
> import java.util.logging.Logger;
> @@ -32,6 +33,7 @@ public class BooleanConverter implements
> PropertyConverter<Boolean> {
> private Logger LOG = Logger.getLogger(getClass().getName());
>
> @Override
> + @CheckForNull
> public Boolean convert(String value) {
> String ignoreCaseValue = Objects.requireNonNull(value)
> .trim()
> @@ -51,6 +53,7 @@ public class BooleanConverter implements
> PropertyConverter<Boolean> {
> default:
> LOG.warning("Unknown boolean value encountered: " +
> value);
> }
> - return Boolean.FALSE;
> +
> + return null;
> }
> }
>
> http://git-wip-us.apache.org/repos/asf/incubator-tamaya/blob/3ca337eb/pom.xml
> ----------------------------------------------------------------------
> diff --git a/pom.xml b/pom.xml
> index 8f1f46f..384bf2e 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -215,6 +215,13 @@ under the License.
> <version>${junit.version}</version>
> <scope>test</scope>
> </dependency>
> +
> + <dependency>
> + <groupId>com.google.code.findbugs</groupId>
> + <artifactId>annotations</artifactId>
> + <version>${findbugs.version}</version>
> + </dependency>
> +
> <dependency>
> <groupId>org.hamcrest</groupId>
> <artifactId>hamcrest-core</artifactId>
>