You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2014/06/03 17:32:28 UTC
Review Request 22208: Incorrect behaviour when trying to execute
upgradestack to nonexistent HDP version
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22208/
-----------------------------------------------------------
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-6008
https://issues.apache.org/jira/browse/AMBARI-6008
Repository: ambari
Description
-------
[root@dev01 ~]# ambari-server upgradestack HDP-2.3.4
Using python /usr/bin/python2.6
Upgrading stack of ambari-server
WARNING: could not change directory to "/root"
Ambari Server 'upgradestack' completed successfully.
Ambari should consider the validity of the data if was specified the invalid
HDP version and give the correct message about this.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java 77ec069
ambari-server/src/main/python/ambari-server.py 6ad94d5
ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java PRE-CREATION
ambari-server/src/test/python/TestAmbariServer.py c2d868d
Diff: https://reviews.apache.org/r/22208/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 22208: Incorrect behaviour when trying to execute
upgradestack to nonexistent HDP version
Posted by Nate Cole <nc...@hortonworks.com>.
> On June 3, 2014, 11:44 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java, lines 121-124
> > <https://reviews.apache.org/r/22208/diff/1/?file=602879#file602879line121>
> >
> > This change will not have proper behavior for stacks other than HDP. It's not guaranteed of a .repo file at that location, nor that it will be named with these assumptions. Also HEAD may not be served either.
I don't think we have to verify the URL. When making this call, the user should know if it is valid or not. I really like what was done to verify the stack version is correct.
- Nate
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22208/#review44630
-----------------------------------------------------------
On June 3, 2014, 11:32 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22208/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:32 a.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-6008
> https://issues.apache.org/jira/browse/AMBARI-6008
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> [root@dev01 ~]# ambari-server upgradestack HDP-2.3.4
> Using python /usr/bin/python2.6
> Upgrading stack of ambari-server
> WARNING: could not change directory to "/root"
>
> Ambari Server 'upgradestack' completed successfully.
>
>
> Ambari should consider the validity of the data if was specified the invalid
> HDP version and give the correct message about this.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java 77ec069
> ambari-server/src/main/python/ambari-server.py 6ad94d5
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py c2d868d
>
> Diff: https://reviews.apache.org/r/22208/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 22208: Incorrect behaviour when trying to execute
upgradestack to nonexistent HDP version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22208/#review44630
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java
<https://reviews.apache.org/r/22208/#comment79045>
This change will not have proper behavior for stacks other than HDP. It's not guaranteed of a .repo file at that location, nor that it will be named with these assumptions. Also HEAD may not be served either.
- Nate Cole
On June 3, 2014, 11:32 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22208/
> -----------------------------------------------------------
>
> (Updated June 3, 2014, 11:32 a.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-6008
> https://issues.apache.org/jira/browse/AMBARI-6008
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> [root@dev01 ~]# ambari-server upgradestack HDP-2.3.4
> Using python /usr/bin/python2.6
> Upgrading stack of ambari-server
> WARNING: could not change directory to "/root"
>
> Ambari Server 'upgradestack' completed successfully.
>
>
> Ambari should consider the validity of the data if was specified the invalid
> HDP version and give the correct message about this.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java 77ec069
> ambari-server/src/main/python/ambari-server.py 6ad94d5
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py c2d868d
>
> Diff: https://reviews.apache.org/r/22208/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 22208: Incorrect behaviour when trying to execute
upgradestack to nonexistent HDP version
Posted by Dmytro Shkvyra <ds...@hortonworks.com>.
> On June 4, 2014, 4:17 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java, lines 138-149
> > <https://reviews.apache.org/r/22208/diff/2/?file=603472#file603472line138>
> >
> > Can just propagate the IOException. A generic Exception is thrown when this function is false anyway. At very least write a log statement showing what happened to help the user make it right.
I agree with you. I'll throw Exception with more informative message
- Dmytro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22208/#review44719
-----------------------------------------------------------
On June 4, 2014, 4:07 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22208/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 4:07 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-6008
> https://issues.apache.org/jira/browse/AMBARI-6008
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> [root@dev01 ~]# ambari-server upgradestack HDP-2.3.4
> Using python /usr/bin/python2.6
> Upgrading stack of ambari-server
> WARNING: could not change directory to "/root"
>
> Ambari Server 'upgradestack' completed successfully.
>
>
> Ambari should consider the validity of the data if was specified the invalid
> HDP version and give the correct message about this.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java 77ec069
> ambari-server/src/main/python/ambari-server.py 6ad94d5
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py c2d868d
>
> Diff: https://reviews.apache.org/r/22208/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 22208: Incorrect behaviour when trying to execute
upgradestack to nonexistent HDP version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22208/#review44719
-----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java
<https://reviews.apache.org/r/22208/#comment79193>
Can just propagate the IOException. A generic Exception is thrown when this function is false anyway. At very least write a log statement showing what happened to help the user make it right.
- Nate Cole
On June 4, 2014, 12:07 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22208/
> -----------------------------------------------------------
>
> (Updated June 4, 2014, 12:07 p.m.)
>
>
> Review request for Ambari and Dmitro Lisnichenko.
>
>
> Bugs: AMBARI-6008
> https://issues.apache.org/jira/browse/AMBARI-6008
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> [root@dev01 ~]# ambari-server upgradestack HDP-2.3.4
> Using python /usr/bin/python2.6
> Upgrading stack of ambari-server
> WARNING: could not change directory to "/root"
>
> Ambari Server 'upgradestack' completed successfully.
>
>
> Ambari should consider the validity of the data if was specified the invalid
> HDP version and give the correct message about this.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java 77ec069
> ambari-server/src/main/python/ambari-server.py 6ad94d5
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py c2d868d
>
> Diff: https://reviews.apache.org/r/22208/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 22208: Incorrect behaviour when trying to execute
upgradestack to nonexistent HDP version
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22208/#review44891
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On June 6, 2014, 9:53 a.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22208/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 9:53 a.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-6008
> https://issues.apache.org/jira/browse/AMBARI-6008
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> [root@dev01 ~]# ambari-server upgradestack HDP-2.3.4
> Using python /usr/bin/python2.6
> Upgrading stack of ambari-server
> WARNING: could not change directory to "/root"
>
> Ambari Server 'upgradestack' completed successfully.
>
>
> Ambari should consider the validity of the data if was specified the invalid
> HDP version and give the correct message about this.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java 77ec069
> ambari-server/src/main/python/ambari-server.py d580634
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py 0ed238a
>
> Diff: https://reviews.apache.org/r/22208/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 22208: Incorrect behaviour when trying to execute
upgradestack to nonexistent HDP version
Posted by Dmitro Lisnichenko <dl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22208/#review44894
-----------------------------------------------------------
Ship it!
Ship It!
- Dmitro Lisnichenko
On June 6, 2014, 1:53 p.m., Andrew Onischuk wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/22208/
> -----------------------------------------------------------
>
> (Updated June 6, 2014, 1:53 p.m.)
>
>
> Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
>
>
> Bugs: AMBARI-6008
> https://issues.apache.org/jira/browse/AMBARI-6008
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> [root@dev01 ~]# ambari-server upgradestack HDP-2.3.4
> Using python /usr/bin/python2.6
> Upgrading stack of ambari-server
> WARNING: could not change directory to "/root"
>
> Ambari Server 'upgradestack' completed successfully.
>
>
> Ambari should consider the validity of the data if was specified the invalid
> HDP version and give the correct message about this.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java 77ec069
> ambari-server/src/main/python/ambari-server.py d580634
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java PRE-CREATION
> ambari-server/src/test/python/TestAmbariServer.py 0ed238a
>
> Diff: https://reviews.apache.org/r/22208/diff/
>
>
> Testing
> -------
>
> mvn clean test
>
>
> Thanks,
>
> Andrew Onischuk
>
>
Re: Review Request 22208: Incorrect behaviour when trying to execute
upgradestack to nonexistent HDP version
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22208/
-----------------------------------------------------------
(Updated June 6, 2014, 1:53 p.m.)
Review request for Ambari, Dmitro Lisnichenko and Nate Cole.
Bugs: AMBARI-6008
https://issues.apache.org/jira/browse/AMBARI-6008
Repository: ambari
Description
-------
[root@dev01 ~]# ambari-server upgradestack HDP-2.3.4
Using python /usr/bin/python2.6
Upgrading stack of ambari-server
WARNING: could not change directory to "/root"
Ambari Server 'upgradestack' completed successfully.
Ambari should consider the validity of the data if was specified the invalid
HDP version and give the correct message about this.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java 77ec069
ambari-server/src/main/python/ambari-server.py d580634
ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java PRE-CREATION
ambari-server/src/test/python/TestAmbariServer.py 0ed238a
Diff: https://reviews.apache.org/r/22208/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 22208: Incorrect behaviour when trying to execute
upgradestack to nonexistent HDP version
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22208/
-----------------------------------------------------------
(Updated June 6, 2014, 1:52 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Changes
-------
Exception changes made
Bugs: AMBARI-6008
https://issues.apache.org/jira/browse/AMBARI-6008
Repository: ambari
Description
-------
[root@dev01 ~]# ambari-server upgradestack HDP-2.3.4
Using python /usr/bin/python2.6
Upgrading stack of ambari-server
WARNING: could not change directory to "/root"
Ambari Server 'upgradestack' completed successfully.
Ambari should consider the validity of the data if was specified the invalid
HDP version and give the correct message about this.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java 77ec069
ambari-server/src/main/python/ambari-server.py d580634
ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java PRE-CREATION
ambari-server/src/test/python/TestAmbariServer.py 0ed238a
Diff: https://reviews.apache.org/r/22208/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk
Re: Review Request 22208: Incorrect behaviour when trying to execute
upgradestack to nonexistent HDP version
Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22208/
-----------------------------------------------------------
(Updated June 4, 2014, 4:07 p.m.)
Review request for Ambari and Dmitro Lisnichenko.
Bugs: AMBARI-6008
https://issues.apache.org/jira/browse/AMBARI-6008
Repository: ambari
Description
-------
[root@dev01 ~]# ambari-server upgradestack HDP-2.3.4
Using python /usr/bin/python2.6
Upgrading stack of ambari-server
WARNING: could not change directory to "/root"
Ambari Server 'upgradestack' completed successfully.
Ambari should consider the validity of the data if was specified the invalid
HDP version and give the correct message about this.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/StackUpgradeHelper.java 77ec069
ambari-server/src/main/python/ambari-server.py 6ad94d5
ambari-server/src/test/java/org/apache/ambari/server/upgrade/StackUpgradeHelperTest.java PRE-CREATION
ambari-server/src/test/python/TestAmbariServer.py c2d868d
Diff: https://reviews.apache.org/r/22208/diff/
Testing
-------
mvn clean test
Thanks,
Andrew Onischuk