You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by st...@apache.org on 2010/11/03 21:01:38 UTC

svn commit: r1030637 - /subversion/trunk/subversion/libsvn_repos/dump.c

Author: stsp
Date: Wed Nov  3 20:01:38 2010
New Revision: 1030637

URL: http://svn.apache.org/viewvc?rev=1030637&view=rev
Log:
* subversion/libsvn_repos/dump.c
  (dump_node): Don't force creation of checksums for file content.
   The dump file should reflect contents of the repository, and not
   contain checksums generated on the fly if checksums are missing
   from the repository.

Suggested by: cmpilato

See for related discussion:
  Date: Thu, 22 Jul 2010 10:56:11 -0400
  From: C. Michael Pilato
  To: Philip Martin, dev@
  Subject: Re: svn commit: r965892 - in /subversion/trunk:
          notes/dump-load-format.txt subversion/include/svn_repos.h
          subversion/libsvn_repos/dump.c
  Message-ID: <4C...@collab.net>
  http://svn.haxx.se/dev/archive-2010-07/0426.shtml

Modified:
    subversion/trunk/subversion/libsvn_repos/dump.c

Modified: subversion/trunk/subversion/libsvn_repos/dump.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_repos/dump.c?rev=1030637&r1=1030636&r2=1030637&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_repos/dump.c (original)
+++ subversion/trunk/subversion/libsvn_repos/dump.c Wed Nov  3 20:01:38 2010
@@ -386,7 +386,7 @@ dump_node(struct edit_baton *eb,
 
               SVN_ERR(svn_fs_file_checksum(&checksum, svn_checksum_md5,
                                            compare_root, compare_path,
-                                           TRUE, pool));
+                                           FALSE, pool));
               hex_digest = svn_checksum_to_cstring(checksum, pool);
               if (hex_digest)
                 SVN_ERR(svn_stream_printf(eb->stream, pool,
@@ -395,7 +395,7 @@ dump_node(struct edit_baton *eb,
 
               SVN_ERR(svn_fs_file_checksum(&checksum, svn_checksum_sha1,
                                            compare_root, compare_path,
-                                           TRUE, pool));
+                                           FALSE, pool));
               hex_digest = svn_checksum_to_cstring(checksum, pool);
               if (hex_digest)
                 SVN_ERR(svn_stream_printf(eb->stream, pool,
@@ -513,7 +513,7 @@ dump_node(struct edit_baton *eb,
             {
               SVN_ERR(svn_fs_file_checksum(&checksum, svn_checksum_md5,
                                            compare_root, compare_path,
-                                           TRUE, pool));
+                                           FALSE, pool));
               hex_digest = svn_checksum_to_cstring(checksum, pool);
               if (hex_digest)
                 SVN_ERR(svn_stream_printf(eb->stream, pool,
@@ -522,7 +522,7 @@ dump_node(struct edit_baton *eb,
 
               SVN_ERR(svn_fs_file_checksum(&checksum, svn_checksum_sha1,
                                            compare_root, compare_path,
-                                           TRUE, pool));
+                                           FALSE, pool));
               hex_digest = svn_checksum_to_cstring(checksum, pool);
               if (hex_digest)
                 SVN_ERR(svn_stream_printf(eb->stream, pool,
@@ -542,7 +542,7 @@ dump_node(struct edit_baton *eb,
                                 ": %" SVN_FILESIZE_T_FMT "\n", textlen));
 
       SVN_ERR(svn_fs_file_checksum(&checksum, svn_checksum_md5,
-                                   eb->fs_root, path, TRUE, pool));
+                                   eb->fs_root, path, FALSE, pool));
       hex_digest = svn_checksum_to_cstring(checksum, pool);
       if (hex_digest)
         SVN_ERR(svn_stream_printf(eb->stream, pool,
@@ -550,7 +550,7 @@ dump_node(struct edit_baton *eb,
                                   ": %s\n", hex_digest));
 
       SVN_ERR(svn_fs_file_checksum(&checksum, svn_checksum_sha1,
-                                   eb->fs_root, path, TRUE, pool));
+                                   eb->fs_root, path, FALSE, pool));
       hex_digest = svn_checksum_to_cstring(checksum, pool);
       if (hex_digest)
         SVN_ERR(svn_stream_printf(eb->stream, pool,



Re: svn commit: r1030637 - /subversion/trunk/subversion/libsvn_repos/dump.c

Posted by "C. Michael Pilato" <cm...@collab.net>.
On 11/03/2010 04:01 PM, stsp@apache.org wrote:
> Author: stsp
> Date: Wed Nov  3 20:01:38 2010
> New Revision: 1030637
> 
> URL: http://svn.apache.org/viewvc?rev=1030637&view=rev
> Log:
> * subversion/libsvn_repos/dump.c
>   (dump_node): Don't force creation of checksums for file content.
>    The dump file should reflect contents of the repository, and not
>    contain checksums generated on the fly if checksums are missing
>    from the repository.
> 
> Suggested by: cmpilato

Thanks, Stefan.

-- 
C. Michael Pilato <cm...@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand