[GitHub] aboganas commented on a change in pull request #6445: fix Calendar Heatmap

[GitBox <gi...@apache.org>]

aboganas commented on a change in pull request #6445: fix Calendar Heatmap
URL: https://github.com/apache/incubator-superset/pull/6445#discussion_r236785510
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -790,7 +790,7 @@ def get_data(self, df):
         records = df.to_dict('records')
         for metric in self.metric_labels:
             data[metric] = {
-                str(obj[DTTM_ALIAS] / 10**9): obj.get(metric)
+                str(obj[DTTM_ALIAS].value / 10**9): obj.get(metric)
 
 Review comment:
   Yes I'm on the latest pandas version 0.23.1 and Pytho: 3.6.6.final.0 , and without `.value` you get the following error
   ```TypeError: unsupported operand type(s) for /: 'Timestamp' and 'int'```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org