You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by vo...@apache.org on 2024/03/20 20:37:44 UTC

(druid) branch master updated: Web console: fix Azure icon not rendering (#16173)

This is an automated email from the ASF dual-hosted git repository.

vogievetsky pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git


The following commit(s) were added to refs/heads/master by this push:
     new e769ec7b964 Web console: fix Azure icon not rendering (#16173)
e769ec7b964 is described below

commit e769ec7b96415f26426a1661407d7894d73d3c98
Author: Vadim Ogievetsky <va...@ogievetsky.com>
AuthorDate: Wed Mar 20 13:37:39 2024 -0700

    Web console: fix Azure icon not rendering (#16173)
    
    * do not lowercase the icon name
    
    * missing icon
    
    * update test
---
 web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx         | 3 ++-
 web-console/src/utils/types.ts                                         | 1 +
 .../views/load-data-view/__snapshots__/load-data-view.spec.tsx.snap    | 2 +-
 3 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx b/web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx
index fa3fd905be3..ec765b9c345 100644
--- a/web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx
+++ b/web-console/src/druid-models/ingestion-spec/ingestion-spec.tsx
@@ -208,7 +208,7 @@ export function getIngestionTitle(ingestionType: IngestionComboTypeWithExtra): s
 
 export function getIngestionImage(ingestionType: IngestionComboTypeWithExtra): string {
   const parts = ingestionType.split(':');
-  if (parts.length === 2) return parts[1].toLowerCase();
+  if (parts.length === 2) return parts[1];
   return ingestionType;
 }
 
@@ -2071,6 +2071,7 @@ const TUNING_FORM_FIELDS: Field<IngestionSpec>[] = [
   {
     name: 'spec.tuningConfig.maxPendingPersists',
     type: 'number',
+    defaultValue: 0,
     hideInMore: true,
     info: (
       <>
diff --git a/web-console/src/utils/types.ts b/web-console/src/utils/types.ts
index d164d46138b..76437e58327 100644
--- a/web-console/src/utils/types.ts
+++ b/web-console/src/utils/types.ts
@@ -80,6 +80,7 @@ export function dataTypeToIcon(dataType: string): IconName {
       return IconNames.SNOWFLAKE;
 
     case 'COMPLEX<QUANTILESDOUBLESSKETCH>':
+    case 'COMPLEX<APPROXIMATEHISTOGRAM>':
       return IconNames.HORIZONTAL_DISTRIBUTION;
 
     case 'COMPLEX<VARIANCE>':
diff --git a/web-console/src/views/load-data-view/__snapshots__/load-data-view.spec.tsx.snap b/web-console/src/views/load-data-view/__snapshots__/load-data-view.spec.tsx.snap
index 3d1d2ec93ec..266bfc9c05c 100644
--- a/web-console/src/views/load-data-view/__snapshots__/load-data-view.spec.tsx.snap
+++ b/web-console/src/views/load-data-view/__snapshots__/load-data-view.spec.tsx.snap
@@ -182,7 +182,7 @@ exports[`LoadDataView matches snapshot batch 1`] = `
           >
             <img
               alt="Ingestion tile for index_parallel:azureStorage"
-              src="/some/base_url/assets/azurestorage.png"
+              src="/some/base_url/assets/azureStorage.png"
             />
             <p>
               Azure Data Lake


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org