You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "AetherUnbound (via GitHub)" <gi...@apache.org> on 2023/04/07 21:07:09 UTC
[GitHub] [airflow] AetherUnbound opened a new pull request, #30536: Make AWS RDS operator page title consistent
AetherUnbound opened a new pull request, #30536:
URL: https://github.com/apache/airflow/pull/30536
This PR changes the title of the RDS documentation page from "Amazon Relational Database Service Documentation (RDS)" to "Amazon Relational Database Service (RDS)". This page was the only one with the word "Documentation" in its title, and several other services had a similar title format of ("Amazon <full service name> (<acronym>)"), for example ["Amazon Simple Notification Service (SNS)"](https://airflow.apache.org/docs/apache-airflow-providers-amazon/stable/operators/sns.html).
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #30536: Make AWS RDS operator page title consistent
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #30536:
URL: https://github.com/apache/airflow/pull/30536#issuecomment-1500863921
merging failure is not related and already fixed in main
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on pull request #30536: Make AWS RDS operator page title consistent
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on PR #30536:
URL: https://github.com/apache/airflow/pull/30536#issuecomment-1500663641
Not sure also why some are AWS and some are Amazon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AetherUnbound commented on pull request #30536: Make AWS RDS operator page title consistent
Posted by "AetherUnbound (via GitHub)" <gi...@apache.org>.
AetherUnbound commented on PR #30536:
URL: https://github.com/apache/airflow/pull/30536#issuecomment-1500681514
It's worth noting that Amazon _itself_ doesn't even seem to have consistency with their naming convention:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal merged pull request #30536: Make AWS RDS operator page title consistent
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal merged PR #30536:
URL: https://github.com/apache/airflow/pull/30536
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] AetherUnbound commented on pull request #30536: Make AWS RDS operator page title consistent
Posted by "AetherUnbound (via GitHub)" <gi...@apache.org>.
AetherUnbound commented on PR #30536:
URL: https://github.com/apache/airflow/pull/30536#issuecomment-1500681026
I'm not sure why either 😅 but that seemed like a larger change than what I wanted to make with this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org