You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/02/12 20:01:42 UTC

[GitHub] roywei opened a new pull request #14134: follow up on fix nightly test

roywei opened a new pull request #14134: follow up on fix nightly test
URL: https://github.com/apache/incubator-mxnet/pull/14134
 
 
   ## Description ##
   This is a followup on https://github.com/apache/incubator-mxnet/pull/14119
   fixes #14026 
   
   Thanks for the help from the CI team, I was able to reproduce the docker environment and test the fix.
   ```
   ----------------------------------------------------------------------
   Ran 47 tests in 2199.521s
   
   OK
   build.py: 2019-02-12 19:42:10,706Z INFO Waiting for status of container a41697b9f1f0 for 600 s.
   build.py: 2019-02-12 19:42:10,877Z INFO Container exit status: {'StatusCode': 0, 'Error': None}
   build.py: 2019-02-12 19:42:10,878Z INFO Container exited with success 👍
   build.py: 2019-02-12 19:42:10,878Z INFO Stopping container: a41697b9f1f0
   build.py: 2019-02-12 19:42:10,879Z INFO Removing container: a41697b9f1f0
   ```
   
   
   ## Checklist ##
   ### Essentials ###
   Please feel free to remove inapplicable items for your PR.
   - [ ] The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant [JIRA issue](https://issues.apache.org/jira/projects/MXNET/issues) created (except PRs with tiny changes)
   - [ ] Changes are complete (i.e. I finished coding on this PR)
   - [ ] All changes have test coverage:
   - Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
   - Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
   - Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
   - [ ] Code is well-documented: 
   - For user-facing API changes, API doc string has been updated. 
   - For new C++ functions in header files, their functionalities and arguments are documented. 
   - For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
   - Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
   - [ ] To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
   
   ### Changes ###
   - [ ] Feature1, tests, (and when applicable, API doc)
   - [ ] Feature2, tests, (and when applicable, API doc)
   
   ## Comments ##
   - If this change is a backward incompatible change, why must this change be made.
   - Interesting edge cases to note here
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services