[GitHub] flink pull request #5841: [FLINK-9163[e2e-tests] harden signal traps and con...

[NicoK <gi...@git.apache.org>]

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/5841

    [FLINK-9163[e2e-tests] harden signal traps and config restoration

    ## What is the purpose of the change
    
    Signal traps on certain systems, e.g. Linux, may be called concurrently when the trap is caught during its own execution. In that case, our cleanup may just be wrong and may also overly eagerly delete `flink-conf.yaml`.
    
    ## Brief change log
    
    - place pattern `rm <file>; mv <file.bak> <file>` with the more atomic `mv -f <file.bak> <file>`
    - reduce unnecessary error messages in the output during early (manual) test aborts
    - stop complaining about `md5sum` or `md5` not being available if the error is from something else
    - stop complaining about not being able to delete non-existing log files
    - disable signal traps while in signal handling (needs to be done in each e2e test that was using this pattern)
    
    ## Verifying this change
    
    This change adapts the e2e tests and was tested with them also manually by aborting (CTRL-C) during different phases of the execution.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    
    ## Documentation
    
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **not applicable**


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-9163

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5841.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5841
    
----
commit 316355fa7c141cf78d47c86caa9f5156860699c5
Author: Nico Kruber <ni...@...>
Date:   2018-04-06T10:36:41Z

    [FLINK-9163[e2e-tests] harden signal traps and config restoration

----


---

[GitHub] flink pull request #5841: [FLINK-9163[e2e-tests] harden signal traps and con...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5841


---

[GitHub] flink issue #5841: [FLINK-9163[e2e-tests] harden signal traps and config res...

[tzulitai <gi...@git.apache.org>]

Github user tzulitai commented on the issue:

    https://github.com/apache/flink/pull/5841
  
    Thanks for the contribution @NicoK!
    These are nice fixes for the end-to-end tests.
    
    +1, merging this ...


---