[GitHub] [cordova-android] raphinesse opened a new pull request #860: Don't filter gradle's stderr anymore

[GitBox <gi...@apache.org>]

raphinesse opened a new pull request #860: Don't filter gradle's stderr anymore
URL: https://github.com/apache/cordova-android/pull/860
 
 
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   When building the project by running `gradlew`, we filter its output on `stderr` to omit a specific diagnostic message. This complicated refactorings in the past and also affects upcoming refactorings regarding `Q` and `superspawn`.
   
   The [reason this code exists](https://issues.apache.org/jira/browse/CB-9971) is a weak one IMHO. The Visual Studio integration deemed the build to have failed if anything has been output on `stderr`. Thus the aforementioned diagnostic message on `stderr` caused successful builds to count as failed ones.
   
   IMHO, the current behavior should be removed for various reasons:
   - Diagnostics on `stderr` are not uncommon, so the success of the command should be determined from the returned `Promise` or the process' exit code respectively
   - Unclear if code works correctly & reliably: the code is written as if only complete lines were passed into `progress`. But `superspawn` calls `notify` for every `chunk` it receives in a `data` event on `stderr`. AFAIK it is not guaranteed that these chunks will be individual and complete lines.
   - Unclear if code is up-to-date
   - Code is untested
   - Complicates refactorings
   
   
   ### Description
   <!-- Describe your changes in detail -->
   This PR removes all output filtering in `ProjectBuilder.prototype.build`.
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Automated tests still pass.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org