[GitHub] [hbase] saintstack commented on a change in pull request #2800: HBASE-25249 Adding StoreContext

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #2800:
URL: https://github.com/apache/hbase/pull/2800#discussion_r552254130



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -246,6 +234,8 @@
   private AtomicLong compactedCellsSize = new AtomicLong();
   private AtomicLong majorCompactedCellsSize = new AtomicLong();
 
+  private HStoreContext storeContext;

Review comment:
       @taklwu
   
   Sorry for late reply (Thanks for pinging).
   
   > let's try to clarify your suggestion
   
   I was asking a question, not making a suggestion -- smile.
   
   One thing I notice is that you and @z-york talk of the Store 'info' or 'information'. So, would StoreInfo make more sense than StoreContext? It would align with ScanInfo (Yeah, StoreInfo looks like it should have ScanInfo since it a superset or should subsume ScanInfo).
   
   Above you say this... "...we're trying to group those read-only reference such that we don't have to always use HStore object in the lower classes."  Seems like you could use a version of this to answer my question (ScanInfo is 'Immutable information for scans over a store'... so StoreInfo could be Store immutable info?).
   
   Back to your comments...
   
   I was trying to figure when to pass Store and when I'd pass StoreInfo/StoreContext only.
   
   Lets just have a StoreContext/StoreInfo. Lets NOT have a StoreWriterContext; i.e. a context for write-side only.
   
   One sec.... let me look at the PR here.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org