You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by harshach <gi...@git.apache.org> on 2014/06/10 21:58:35 UTC
[GitHub] incubator-storm pull request: Storm 344
GitHub user harshach opened a pull request:
https://github.com/apache/incubator-storm/pull/138
Storm 344
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/harshach/incubator-storm STORM-344
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/138.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #138
----
commit d82b25c1c416b1a53f1fd10c311104960ac026d9
Author: Sriharsha Chintalapani <ma...@harsha.io>
Date: 2014-06-10T19:52:30Z
STORM-344. (Security) nimbus renew-credentials not calling ICredentialsRenewer.renew
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Storm 344. (Security) nimbus renew-c...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-storm/pull/138
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Storm 344. (Security) nimbus renew-c...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/incubator-storm/pull/138#issuecomment-45667887
looks like my last update didn't worked will send a new update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Storm 344. (Security) nimbus renew-c...
Posted by d2r <gi...@git.apache.org>.
Github user d2r commented on the pull request:
https://github.com/apache/incubator-storm/pull/138#issuecomment-45665445
Would you eliminate the white-space changes? Looks like the overall diff should be pretty small.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Storm 344. (Security) nimbus renew-c...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/138#issuecomment-45924583
Oh I guess the jira github link is smart enough to not need the '-'. My previous comment showed up in JIRA.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: Storm 344. (Security) nimbus renew-c...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/incubator-storm/pull/138#issuecomment-45924430
If you update the title of this pull request to have STORM-344 in it the JIRA and pull request will be linked. As it stands now the change looks good to me. +1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---