You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Charlie Carson <cc...@twitter.com> on 2014/01/17 01:39:06 UTC

Review Request 17001: template for .gitignore

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17001/
-----------------------------------------------------------

Review request for mesos.


Bugs: https://issues.apache.org/jira/browse/MESOS-916
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-916


Repository: mesos-git


Description
-------

    template for .gitignore

    This files contains the 38 files and directories
    that are generated by running ./bootstrap.

    It also masks out .gitignore and the recommended
    ./build directory.

    To use run:
    cp .gitignore-template .gitignore

    in the route of your enlistment

    Review: https://reviews.apache.org/r/17001


Diffs
-----

  .gitignore-template PRE-CREATION 

Diff: https://reviews.apache.org/r/17001/diff/


Testing
-------

make check


Thanks,

Charlie Carson

Re: Review Request 17001: template for .gitignore

Posted by Benjamin Hindman <be...@berkeley.edu>.

> On Jan. 17, 2014, 5:46 p.m., Benjamin Hindman wrote:
> > Ship It!

This is committed, thanks Charlie!


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17001/#review32150
-----------------------------------------------------------


On Jan. 17, 2014, 5:13 p.m., Charlie Carson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17001/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 5:13 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-916
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-916
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
>     template for .gitignore
> 
>     This files contains the 38 files and directories
>     that are generated by running ./bootstrap.
> 
>     It also masks out .gitignore and the recommended
>     ./build directory.
> 
>     To use run:
>     cp .gitignore-template .gitignore
> 
>     in the route of your enlistment
> 
>     Review: https://reviews.apache.org/r/17001
> 
> 
> Diffs
> -----
> 
>   .gitignore-template PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17001/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Charlie Carson
> 
>

Re: Review Request 17001: template for .gitignore

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17001/#review32150
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On Jan. 17, 2014, 5:13 p.m., Charlie Carson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17001/
> -----------------------------------------------------------
> 
> (Updated Jan. 17, 2014, 5:13 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: https://issues.apache.org/jira/browse/MESOS-916
>     https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-916
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
>     template for .gitignore
> 
>     This files contains the 38 files and directories
>     that are generated by running ./bootstrap.
> 
>     It also masks out .gitignore and the recommended
>     ./build directory.
> 
>     To use run:
>     cp .gitignore-template .gitignore
> 
>     in the route of your enlistment
> 
>     Review: https://reviews.apache.org/r/17001
> 
> 
> Diffs
> -----
> 
>   .gitignore-template PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/17001/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Charlie Carson
> 
>

Re: Review Request 17001: template for .gitignore

Posted by Charlie Carson <cc...@twitter.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17001/
-----------------------------------------------------------

(Updated Jan. 17, 2014, 5:13 p.m.)


Review request for mesos.


Changes
-------

switched to filespec pattern instead of speicific filepaths


Bugs: https://issues.apache.org/jira/browse/MESOS-916
    https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/MESOS-916


Repository: mesos-git


Description
-------

    template for .gitignore

    This files contains the 38 files and directories
    that are generated by running ./bootstrap.

    It also masks out .gitignore and the recommended
    ./build directory.

    To use run:
    cp .gitignore-template .gitignore

    in the route of your enlistment

    Review: https://reviews.apache.org/r/17001


Diffs (updated)
-----

  .gitignore-template PRE-CREATION 

Diff: https://reviews.apache.org/r/17001/diff/


Testing
-------

make check


Thanks,

Charlie Carson