You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@storm.apache.org by "Aaron.Dossett" <Aa...@target.com> on 2015/07/16 16:46:32 UTC

STORM-799 PR available, feedback requested.

Hi,

I took a look at this issue as a learning exercise.  The change was pretty trivial, but one unexpected benefit of the change was removing a minor, but potentially risky, runtime type-check from MetricsConsumerBolt.java.

_metricsConsumer.prepare(stormConf, _registrationArgument, context, (IErrorReporter)collector);
_metricsConsumer.prepare(stormConf, _registrationArgument, context, collector);

https://issues.apache.org/jira/browse/STORM-799

I would appreciate any feedback on this change.  If the STORM-799 issue isn’t that significant, should be it be closed?

Thanks, Aaron