You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/24 21:02:28 UTC

[GitHub] [arrow] nealrichardson commented on pull request #14461: ARROW-15460: [R] Add as.data.frame.Dataset method

nealrichardson commented on PR #14461:
URL: https://github.com/apache/arrow/pull/14461#issuecomment-1289612858

   > Changes seem reasonable, but I'm still not super familiar with the metadata stuff. So would like to see that encoded in the unit tests, if possible.
   
   The schema metadata stuff is already tested, I would guess mostly in test-metadata.R and test-dplyr-group-by.R. This change redirects some codepaths to go through it rather than relying on `arrow_dplyr_query` attributes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org