[GitHub] spark pull request #11974: [SPARK-14174][ML] Accelerate KMeans via Mini-Batc...

[MLnick <gi...@git.apache.org>]

Github user MLnick commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11974#discussion_r118546602
  
    --- Diff: mllib/src/test/scala/org/apache/spark/ml/clustering/KMeansSuite.scala ---
    @@ -89,6 +92,9 @@ class KMeansSuite extends SparkFunSuite with MLlibTestSparkContext with DefaultR
         intercept[IllegalArgumentException] {
           new KMeans().setInitSteps(0)
         }
    +    intercept[IllegalArgumentException] {
    +      new KMeans().setMiniBatchFraction(0)
    --- End diff --
    
    Minor nit but we should probably check a few edge cases - <0, >1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org