You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/02/28 22:10:55 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #23241: refactor: Organizes the pages in their own folder
michael-s-molina opened a new pull request, #23241:
URL: https://github.com/apache/superset/pull/23241
### SUMMARY
This PR organizes the pages in their own folder following the discussion outlined [here](https://github.com/apache/superset/discussions/22330#discussioncomment-4410665). One of this change's objectives is to standardize page nomenclatures and localization in the codebase. There was no route changed in this PR.
This work is part of [SIP-61](https://github.com/apache/superset/issues/13632)
### TESTING INSTRUCTIONS
Make sure all routes continue to work as before.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23241: refactor: Organizes the pages in their own folder
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23241:
URL: https://github.com/apache/superset/pull/23241#issuecomment-1449062986
# [Codecov](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23241](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ee6012) into [master](https://codecov.io/gh/apache/superset/commit/473a69a7048719d706307fe7d6906026e68d427f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (473a69a) will **not change** coverage.
> The diff coverage is `52.63%`.
> :exclamation: Current head 9ee6012 differs from pull request most recent head 0ddaf1d. Consider uploading reports for the commit 0ddaf1d to get more accurate results
```diff
@@ Coverage Diff @@
## master #23241 +/- ##
=======================================
Coverage 67.49% 67.49%
=======================================
Files 1906 1906
Lines 73414 73414
Branches 7958 7958
=======================================
Hits 49553 49553
Misses 21820 21820
Partials 2041 2041
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.73% <52.63%> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...erset-frontend/src/pages/AlertReportList/index.tsx](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0FsZXJ0UmVwb3J0TGlzdC9pbmRleC50c3g=) | `59.64% <ø> (ø)` | |
| [superset-frontend/src/pages/AllEntities/index.tsx](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0FsbEVudGl0aWVzL2luZGV4LnRzeA==) | `0.00% <ø> (ø)` | |
| [...t-frontend/src/pages/AnnotationLayerList/index.tsx](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0Fubm90YXRpb25MYXllckxpc3QvaW5kZXgudHN4) | `68.05% <ø> (ø)` | |
| [...perset-frontend/src/pages/AnnotationList/index.tsx](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0Fubm90YXRpb25MaXN0L2luZGV4LnRzeA==) | `69.35% <ø> (ø)` | |
| [superset-frontend/src/pages/Chart/index.tsx](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0NoYXJ0L2luZGV4LnRzeA==) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/pages/ChartList/index.tsx](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0NoYXJ0TGlzdC9pbmRleC50c3g=) | `55.31% <ø> (ø)` | |
| [...erset-frontend/src/pages/CssTemplateList/index.tsx](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0Nzc1RlbXBsYXRlTGlzdC9pbmRleC50c3g=) | `66.66% <ø> (ø)` | |
| [superset-frontend/src/pages/Dashboard/index.tsx](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0Rhc2hib2FyZC9pbmRleC50c3g=) | `0.00% <ø> (ø)` | |
| [...uperset-frontend/src/pages/DashboardList/index.tsx](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0Rhc2hib2FyZExpc3QvaW5kZXgudHN4) | `55.73% <ø> (ø)` | |
| [superset-frontend/src/pages/DatabaseList/index.tsx](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3BhZ2VzL0RhdGFiYXNlTGlzdC9pbmRleC50c3g=) | `66.01% <ø> (ø)` | |
| ... and [13 more](https://codecov.io/gh/apache/superset/pull/23241?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #23241: refactor: Organizes the pages in their own folder
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #23241:
URL: https://github.com/apache/superset/pull/23241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org