You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/06/10 09:29:29 UTC
[GitHub] [incubator-nuttx] fjpanag opened a new pull request #3890: setjmp.h: Added missing include.
fjpanag opened a new pull request #3890:
URL: https://github.com/apache/incubator-nuttx/pull/3890
## Summary
Added missing include in setjmp.h.
## Impact
Code that uses this file now can be build without errors.
## Testing
Build test only.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] fjpanag commented on a change in pull request #3890: setjmp.h: Added missing include.
Posted by GitBox <gi...@apache.org>.
fjpanag commented on a change in pull request #3890:
URL: https://github.com/apache/incubator-nuttx/pull/3890#discussion_r649101911
##########
File path: arch/arm/include/setjmp.h
##########
@@ -25,6 +25,7 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler.h>
Review comment:
Does it make a difference?
Are there any rules in NuttX for the includes order?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #3890: setjmp.h: Added missing include.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #3890:
URL: https://github.com/apache/incubator-nuttx/pull/3890
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3890: setjmp.h: Added missing include.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3890:
URL: https://github.com/apache/incubator-nuttx/pull/3890#discussion_r649113870
##########
File path: arch/arm/include/setjmp.h
##########
@@ -25,6 +25,7 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler.h>
Review comment:
Since config.h include the important setting, all most source always include config.h first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #3890: setjmp.h: Added missing include.
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #3890:
URL: https://github.com/apache/incubator-nuttx/pull/3890#discussion_r649100963
##########
File path: arch/arm/include/setjmp.h
##########
@@ -25,6 +25,7 @@
* Included Files
****************************************************************************/
+#include <nuttx/compiler.h>
Review comment:
should we mvoe it after nuttx/config.h?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org