[jira] [Created] (STORM-1958) storm-config.cmd doesn't handle spaces in JAVA_HOME

["Paul Milliken (JIRA)" <ji...@apache.org>]

Paul Milliken created STORM-1958:
------------------------------------

             Summary: storm-config.cmd doesn't handle spaces in JAVA_HOME
                 Key: STORM-1958
                 URL: https://issues.apache.org/jira/browse/STORM-1958
             Project: Apache Storm
          Issue Type: Bug
          Components: storm-core
    Affects Versions: 1.0.1
         Environment: Windows Server 2008 R2
Java 1.7.0 update 67 (64 bit)
            Reporter: Paul Milliken
            Priority: Critical


We are currently upgrading the version of Storm we use in our environment to 1.0.1 (from 0.10.0). We have discovered that Storm does not start properly as JAVA_HOME has a space in it.

Investigating this, I have found that the main problem (in this case) seems to be in storm-config.cmd. In 0.10.0, line 128 contained:

{code}
set STORM_OPTS=-Dstorm.options= -Dstorm.home=%STORM_HOME% -Djava.library.path=%JAVA_LIBRARY_PATH%
{code}

The equivalent line in 1.0.1 (line 136) has:

{code}
set STORM_OPTS=%STORM_OPTS% -Dstorm.home=%STORM_HOME% -Djava.library.path=%JAVA_LIBRARY_PATH%;%JAVA_HOME%\bin;%JAVA_HOME%\lib;%JAVA_HOME%\jre\bin;%JAVA_HOME%\jre\lib
{code}

If JAVA_HOME has a space in it (as is frequently the case on Windows due to Java by default being installed under Program Files) this breaks the subsequent JVM command line.

This is an out of the box blocker to running Storm on Windows in commons configurations. I have not raised this as a blocker issue however, as there is a simple fix/workaround. We have changed storm-config.cmd in our local copy to add quotes around the java.library.path option:

{code}
set STORM_OPTS=%STORM_OPTS% -Dstorm.home=%STORM_HOME% "-Djava.library.path=%JAVA_LIBRARY_PATH%;%JAVA_HOME%\bin;%JAVA_HOME%\lib;%JAVA_HOME%\jre\bin;%JAVA_HOME%\jre\lib"
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)