You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "tdiesler (via GitHub)" <gi...@apache.org> on 2024/10/22 20:27:53 UTC
[PR] [CAMEL-21361] fabric8 kubernetes-client fails to connect to openshift [camel]
tdiesler opened a new pull request, #16053:
URL: https://github.com/apache/camel/pull/16053
https://issues.apache.org/jira/browse/CAMEL-21361
The root cause was a convoluted TCCL issue. In general, when you work with TCCL, you SHOULD reset it to its original value - like so ...
```
var tccLoader = Thread.currentThread().getContextClassLoader();
try {
ClassLoader cl = createClassLoader();
Thread.currentThread().setContextClassLoader(cl);
// do stuff
} finally {
Thread.currentThread().setContextClassLoader(tccLoader);
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21361] fabric8 kubernetes-client fails to connect to openshift [camel]
Posted by "tdiesler (via GitHub)" <gi...@apache.org>.
tdiesler commented on code in PR #16053:
URL: https://github.com/apache/camel/pull/16053#discussion_r1811957893
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/pom.xml:
##########
@@ -55,6 +55,11 @@
</dependency>
<!-- OpenShift -->
+ <dependency>
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21361] fabric8 kubernetes-client fails to connect to openshift [camel]
Posted by "tdiesler (via GitHub)" <gi...@apache.org>.
tdiesler commented on code in PR #16053:
URL: https://github.com/apache/camel/pull/16053#discussion_r1811868227
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/pom.xml:
##########
@@ -55,6 +55,11 @@
</dependency>
<!-- OpenShift -->
+ <dependency>
Review Comment:
It's use run `run` as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21361] fabric8 kubernetes-client fails to connect to openshift [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #16053:
URL: https://github.com/apache/camel/pull/16053#discussion_r1811888762
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/pom.xml:
##########
@@ -55,6 +55,11 @@
</dependency>
<!-- OpenShift -->
+ <dependency>
Review Comment:
where is it needed - it was not there before
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21361] fabric8 kubernetes-client fails to connect to openshift [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #16053:
URL: https://github.com/apache/camel/pull/16053
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21361] fabric8 kubernetes-client fails to connect to openshift [camel]
Posted by "tdiesler (via GitHub)" <gi...@apache.org>.
tdiesler commented on code in PR #16053:
URL: https://github.com/apache/camel/pull/16053#discussion_r1811901848
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/pom.xml:
##########
@@ -55,6 +55,11 @@
</dependency>
<!-- OpenShift -->
+ <dependency>
Review Comment:
I looked again ... and actually no, the run code uses the k8s API. Let me see if it actually works with scope test ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CAMEL-21361] fabric8 kubernetes-client fails to connect to openshift [camel]
Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus commented on code in PR #16053:
URL: https://github.com/apache/camel/pull/16053#discussion_r1811862689
##########
dsl/camel-jbang/camel-jbang-plugin-kubernetes/pom.xml:
##########
@@ -55,6 +55,11 @@
</dependency>
<!-- OpenShift -->
+ <dependency>
Review Comment:
Is this only used for testing then set test scope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org