You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by benkeen <gi...@git.apache.org> on 2014/12/12 01:08:59 UTC

[GitHub] couchdb-fauxton pull request: Add confirmation modal component

GitHub user benkeen opened a pull request:

    https://github.com/apache/couchdb-fauxton/pull/199

    Add confirmation modal component

    This ticket adds a simple confirmation modal that can be used in
    place of window.confirm().
    
    Closes COUCHDB-2445

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/benkeen/couchdb-fauxton 2445-confirmation-modal

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/couchdb-fauxton/pull/199.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #199
    
----
commit e5b846741c3597395aa156e4efd8986382061d33
Author: Benjamin Keen <be...@gmail.com>
Date:   2014-12-11T21:34:46Z

    Add confirmation modal component
    
    This ticket adds a simple confirmation modal that can be used in
    place of window.confirm().
    
    Closes COUCHDB-2445

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Add confirmation modal component

Posted by benkeen <gi...@git.apache.org>.
Github user benkeen closed the pull request at:

    https://github.com/apache/couchdb-fauxton/pull/199


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Add confirmation modal component

Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/199#issuecomment-66824159
  
    Merged as 47b2fec


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Add confirmation modal component

Posted by benkeen <gi...@git.apache.org>.
Github user benkeen commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/199#issuecomment-66712676
  
    N.B. This isn't being used anywhere yet. I'm using it for COUCHDB-2507 for the delete doc modal. Screenshot below.
    
    ![screen shot 2014-12-11 at 1 27 43 pm](https://cloud.githubusercontent.com/assets/512116/5404799/3dd449ba-8150-11e4-9eb1-7581d7d55612.png)
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] couchdb-fauxton pull request: Add confirmation modal component

Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:

    https://github.com/apache/couchdb-fauxton/pull/199#issuecomment-66807606
  
    +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---