[GitHub] [pulsar-client-go] zzzming commented on pull request #451: Issue #448 make state thread safe in consumer_partition and connection

[GitBox <gi...@apache.org>]

zzzming commented on pull request #451:
URL: https://github.com/apache/pulsar-client-go/pull/451#issuecomment-767134745


   > I'm not particularly attached to uber's atomic, I used it for expediency's sake, but direct calls to atomic always make me nervous if I'm doing them from multiple places, so guarding it in a (probably inlined) method is usually the way I like to go. YMMV. But, if it works and it's consistent with other code, who am I to judge? ¯_ʕ◔ϖ◔ʔ_/¯ Aside from that, LGTM
   
   @flowchartsman I share the same sentiment that I would tend to forget about add sync.atomic too. Let's wait for Matteo to weight in. It's a minor change either way. cheers


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org