[jira] [Resolved] (CRYPTO-103) NativeCodeLoader.getVersion() is not needed

["Sebb (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CRYPTO-103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Sebb resolved CRYPTO-103.
-------------------------
       Resolution: Fixed
    Fix Version/s: 1.0.0

CRYPTO-103 NativeCodeLoader.getVersion() is not needed

Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/fd2b9347
Tree: http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/fd2b9347
Diff: http://git-wip-us.apache.org/repos/asf/commons-crypto/diff/fd2b9347


> NativeCodeLoader.getVersion() is not needed
> -------------------------------------------
>
>                 Key: CRYPTO-103
>                 URL: https://issues.apache.org/jira/browse/CRYPTO-103
>             Project: Commons Crypto
>          Issue Type: Bug
>            Reporter: Sebb
>             Fix For: 1.0.0
>
>
> The NativeCodeLoader.getVersion() method seems badly named, as it has nothing to do with the native code that has been loaded.
> It only relates to the version of the Java code in the jar.
> I would expect the method to return the version details from the library itself.
> If there is a need to return the Java code version, it should be done from a method in another class, e.g. Utils or Crypto. Note: also the extraction should be done once, e.g. using IODH or using a synchronised/volatile lock.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)