You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by md...@apache.org on 2017/10/25 10:16:58 UTC
svn commit: r1813264 -
/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/FileStore.java
Author: mduerig
Date: Wed Oct 25 10:16:58 2017
New Revision: 1813264
URL: http://svn.apache.org/viewvc?rev=1813264&view=rev
Log:
OAK-6868: Simplify setup of access tracking of the file store caches
Set access tracking up in the constructor of the FileStore
Modified:
jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/FileStore.java
Modified: jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/FileStore.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/FileStore.java?rev=1813264&r1=1813263&r2=1813264&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/FileStore.java (original)
+++ jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/file/FileStore.java Wed Oct 25 10:16:58 2017
@@ -92,7 +92,6 @@ import org.apache.jackrabbit.oak.segment
import org.apache.jackrabbit.oak.spi.state.ChildNodeEntry;
import org.apache.jackrabbit.oak.spi.state.NodeBuilder;
import org.apache.jackrabbit.oak.spi.state.NodeState;
-import org.apache.jackrabbit.oak.stats.StatisticsProvider;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -186,8 +185,8 @@ public class FileStore extends AbstractF
builder.getGcOptions(),
builder.getGcListener(),
new GCJournal(directory),
- builder.getCacheManager(),
- builder.getStatsProvider());
+ builder.getCacheManager()
+ .withAccessTracking("COMPACT", builder.getStatsProvider()));
newManifestChecker(directory, builder.getStrictVersionCheck()).checkAndUpdateManifest();
@@ -569,9 +568,6 @@ public class FileStore extends AbstractF
private final WriterCacheManager cacheManager;
@Nonnull
- private final StatisticsProvider statisticsProvider;
-
- @Nonnull
private GCNodeWriteMonitor compactionMonitor = GCNodeWriteMonitor.EMPTY;
private volatile boolean cancelled;
@@ -586,13 +582,11 @@ public class FileStore extends AbstractF
@Nonnull SegmentGCOptions gcOptions,
@Nonnull GCListener gcListener,
@Nonnull GCJournal gcJournal,
- @Nonnull WriterCacheManager cacheManager,
- @Nonnull StatisticsProvider statisticsProvider) {
+ @Nonnull WriterCacheManager cacheManager) {
this.gcOptions = gcOptions;
this.gcListener = gcListener;
this.gcJournal = gcJournal;
this.cacheManager = cacheManager;
- this.statisticsProvider = statisticsProvider;
}
GCNodeWriteMonitor getGCNodeWriteMonitor() {
@@ -748,8 +742,7 @@ public class FileStore extends AbstractF
SegmentNodeState before = getHead();
CancelCompactionSupplier cancel = new CancelCompactionSupplier(FileStore.this);
SegmentWriter writer = defaultSegmentWriterBuilder("c")
- .with(cacheManager
- .withAccessTracking("COMPACT", statisticsProvider))
+ .with(cacheManager)
.withGeneration(newGeneration)
.withoutWriterPool()
.build(FileStore.this);