You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2020/01/27 03:31:00 UTC

[kudu-CR] [cmake modules] fix linker probing on macOS

Hello Kudu Jenkins, Andrew Wong, Todd Lipcon, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/15107

to look at the new patch set (#3).

Change subject: [cmake_modules] fix linker probing on macOS
......................................................................

[cmake_modules] fix linker probing on macOS

Fixed linkage on macOS: as of now, using system ld64 linker.  It turned
out that LLD linker from thirdparty ld64.lld not fully functional yet
to link Kudu binaries.  At least, it doesn't support the -U flag which
is used for the KRB5_REALM_OVERRIDE hack.

This is a follow-up to 638d95d295da0bddf3fa157792ec7de8889ac919.

Change-Id: I5c0ef0104388438f444b1f8ac76ca5ebf4cc2928
---
M cmake_modules/KuduLinker.cmake
1 file changed, 58 insertions(+), 31 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/07/15107/3
-- 
To view, visit http://gerrit.cloudera.org:8080/15107
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5c0ef0104388438f444b1f8ac76ca5ebf4cc2928
Gerrit-Change-Number: 15107
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>