You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "Bowrna (via GitHub)" <gi...@apache.org> on 2023/12/27 08:12:47 UTC

[PR] added cli command to list auth managers under `airflow providers` [airflow]

Bowrna opened a new pull request, #36445:
URL: https://github.com/apache/airflow/pull/36445

   related: #36193 
   closes: #36193 
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] added cli command to list auth managers under `airflow providers` [airflow]

Posted by "Bowrna (via GitHub)" <gi...@apache.org>.
Bowrna commented on code in PR #36445:
URL: https://github.com/apache/airflow/pull/36445#discussion_r1438242691


##########
tests/always/test_providers_manager.py:
##########
@@ -384,6 +384,11 @@ def test_notification(self):
         notification_class_names = list(provider_manager.notification)
         assert len(notification_class_names) > 5
 
+    def test_auth_managers(self):
+        provider_manager = ProvidersManager()
+        notification_class_names = list(provider_manager.auth_managers)
+        assert len(notification_class_names) > 0

Review Comment:
   yes we can check if the name contains auth_manager in it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] added cli command to list auth managers under `airflow providers` [airflow]

Posted by "Bowrna (via GitHub)" <gi...@apache.org>.
Bowrna commented on code in PR #36445:
URL: https://github.com/apache/airflow/pull/36445#discussion_r1438242540


##########
airflow/cli/commands/provider_command.py:
##########
@@ -189,7 +189,20 @@ def auth_backend_list(args):
         data=list(ProvidersManager().auth_backend_module_names),
         output=args.output,
         mapper=lambda x: {
-            "api_auth_backand_module": x,
+            "api_auth_backend_module": x,
+        },
+    )
+
+
+@suppress_logs_and_warning
+@providers_configuration_loaded
+def auth_managers_list(args):
+    """List all auth managers at the command line."""
+    AirflowConsole().print_as(
+        data=list(ProvidersManager().auth_managers),

Review Comment:
   i will fix this changes @Lee-W 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] added cli command to list auth managers under `airflow providers` [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #36445:
URL: https://github.com/apache/airflow/pull/36445


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] added cli command to list auth managers under `airflow providers` [airflow]

Posted by "vincbeck (via GitHub)" <gi...@apache.org>.
vincbeck commented on PR #36445:
URL: https://github.com/apache/airflow/pull/36445#issuecomment-1874279845

   Nice! 🥳 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] added cli command to list auth managers under `airflow providers` [airflow]

Posted by "pankajastro (via GitHub)" <gi...@apache.org>.
pankajastro commented on code in PR #36445:
URL: https://github.com/apache/airflow/pull/36445#discussion_r1438547228


##########
tests/always/test_providers_manager.py:
##########
@@ -384,6 +384,11 @@ def test_notification(self):
         notification_class_names = list(provider_manager.notification)
         assert len(notification_class_names) > 5
 
+    def test_auth_managers(self):
+        provider_manager = ProvidersManager()
+        notification_class_names = list(provider_manager.auth_managers)
+        assert len(notification_class_names) > 0

Review Comment:
   ```suggestion
           auth_manager_class_names = list(provider_manager.auth_managers)
           assert len(auth_manager_class_names) > 0
   ```
   nit: variable name is a bit misleading here



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] added cli command to list auth managers under `airflow providers` [airflow]

Posted by "Lee-W (via GitHub)" <gi...@apache.org>.
Lee-W commented on code in PR #36445:
URL: https://github.com/apache/airflow/pull/36445#discussion_r1437975093


##########
tests/always/test_providers_manager.py:
##########
@@ -384,6 +384,11 @@ def test_notification(self):
         notification_class_names = list(provider_manager.notification)
         assert len(notification_class_names) > 5
 
+    def test_auth_managers(self):
+        provider_manager = ProvidersManager()
+        notification_class_names = list(provider_manager.auth_managers)
+        assert len(notification_class_names) > 0

Review Comment:
   Should we check the names contain the expected content?



##########
airflow/cli/commands/provider_command.py:
##########
@@ -189,7 +189,20 @@ def auth_backend_list(args):
         data=list(ProvidersManager().auth_backend_module_names),
         output=args.output,
         mapper=lambda x: {
-            "api_auth_backand_module": x,
+            "api_auth_backend_module": x,
+        },
+    )
+
+
+@suppress_logs_and_warning
+@providers_configuration_loaded
+def auth_managers_list(args):
+    """List all auth managers at the command line."""
+    AirflowConsole().print_as(
+        data=list(ProvidersManager().auth_managers),

Review Comment:
   looks like `auth_managers` property return `list[str]`. Do we still need the `list` wrap here?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] added cli command to list auth managers under `airflow providers` [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #36445:
URL: https://github.com/apache/airflow/pull/36445#discussion_r1438545904


##########
tests/always/test_providers_manager.py:
##########
@@ -384,6 +384,11 @@ def test_notification(self):
         notification_class_names = list(provider_manager.notification)
         assert len(notification_class_names) > 5
 
+    def test_auth_managers(self):
+        provider_manager = ProvidersManager()
+        notification_class_names = list(provider_manager.auth_managers)
+        assert len(notification_class_names) > 0

Review Comment:
   We could - but this would be merely a convention. I think this test is mostly there to test that the command does not crash and produces "some" responses.  So it's quite ok to leve it as-is.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] added cli command to list auth managers under `airflow providers` [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #36445:
URL: https://github.com/apache/airflow/pull/36445#discussion_r1438547823


##########
tests/always/test_providers_manager.py:
##########
@@ -384,6 +384,11 @@ def test_notification(self):
         notification_class_names = list(provider_manager.notification)
         assert len(notification_class_names) > 5
 
+    def test_auth_managers(self):
+        provider_manager = ProvidersManager()
+        notification_class_names = list(provider_manager.auth_managers)
+        assert len(notification_class_names) > 0

Review Comment:
   Indeed. Committed it straight away



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org